From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported
Date: Wed, 06 Sep 2017 00:00:01 +0200 [thread overview]
Message-ID: <87d174kdr2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170810215111.32360-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Thu, 10 Aug 2017 23:51:11 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Currently, the comment that "valgrind needs shared libs" is not hidden
> when the architecture dependencies are not met, which can confuse some
> users (as recently seen on IRC).
> Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
> the comment and the symbol depend on that.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> Note: Cc-ing the people that have touched valgrind in the past 12
> months-or-so...
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2017-09-05 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 21:51 [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported Yann E. MORIN
2017-08-10 22:16 ` Arnout Vandecappelle
2017-08-11 12:08 ` Arnout Vandecappelle
2017-09-05 22:00 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-10 22:20 Pedro Ribeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d174kdr2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox