* [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported
@ 2017-08-10 21:51 Yann E. MORIN
2017-08-10 22:16 ` Arnout Vandecappelle
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Yann E. MORIN @ 2017-08-10 21:51 UTC (permalink / raw)
To: buildroot
Currently, the comment that "valgrind needs shared libs" is not hidden
when the architecture dependencies are not met, which can confuse some
users (as recently seen on IRC).
Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
the comment and the symbol depend on that.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
Cc: J?r?me Pouiller <jezz@sysmic.org>
Cc: Peter Seiderer <ps.report@gmx.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
Note: Cc-ing the people that have touched valgrind in the past 12
months-or-so...
---
package/valgrind/Config.in | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 40e219d95a..919bd1afb5 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -1,14 +1,19 @@
comment "valgrind needs a toolchain w/ dynamic library"
+ depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
depends on BR2_STATIC_LIBS
+config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
+ bool
+ default y if BR2_ARM_CPU_ARMV7A
+ default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+ default y if BR2_i386 || BR2_x86_64
+ default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
+ depends on !BR2_MIPS_SOFT_FLOAT
+
config BR2_PACKAGE_VALGRIND
bool "valgrind"
- depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
- BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
- BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
- BR2_x86_64
+ depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
depends on !BR2_STATIC_LIBS
- depends on !BR2_MIPS_SOFT_FLOAT
help
Tool for debugging and profiling Linux programs.
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported
2017-08-10 21:51 [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported Yann E. MORIN
@ 2017-08-10 22:16 ` Arnout Vandecappelle
2017-08-11 12:08 ` Arnout Vandecappelle
2017-09-05 22:00 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2017-08-10 22:16 UTC (permalink / raw)
To: buildroot
On 10-08-17 23:51, Yann E. MORIN wrote:
> Currently, the comment that "valgrind needs shared libs" is not hidden
> when the architecture dependencies are not met, which can confuse some
> users (as recently seen on IRC).
>
> Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
> the comment and the symbol depend on that.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
with one small nit:
>
> ---
> Note: Cc-ing the people that have touched valgrind in the past 12
> months-or-so...
> ---
> package/valgrind/Config.in | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
> index 40e219d95a..919bd1afb5 100644
> --- a/package/valgrind/Config.in
> +++ b/package/valgrind/Config.in
> @@ -1,14 +1,19 @@
> comment "valgrind needs a toolchain w/ dynamic library"
> + depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
> depends on BR2_STATIC_LIBS
>
> +config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
_ARCH_SUPPORTS is always the first thing in the file, even if the comment comes
before the main symbol (cfr. e.g. package/canfestival/Config.in,
package/erlang/Config.in)
Regards,
Arnout
> + bool
> + default y if BR2_ARM_CPU_ARMV7A
> + default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
> + default y if BR2_i386 || BR2_x86_64
> + default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
> + depends on !BR2_MIPS_SOFT_FLOAT
> +
> config BR2_PACKAGE_VALGRIND
> bool "valgrind"
> - depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
> - BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
> - BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
> - BR2_x86_64
> + depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
> depends on !BR2_STATIC_LIBS
> - depends on !BR2_MIPS_SOFT_FLOAT
> help
> Tool for debugging and profiling Linux programs.
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported
2017-08-10 21:51 [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported Yann E. MORIN
2017-08-10 22:16 ` Arnout Vandecappelle
@ 2017-08-11 12:08 ` Arnout Vandecappelle
2017-09-05 22:00 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2017-08-11 12:08 UTC (permalink / raw)
To: buildroot
On 10-08-17 23:51, Yann E. MORIN wrote:
> Currently, the comment that "valgrind needs shared libs" is not hidden
> when the architecture dependencies are not met, which can confuse some
> users (as recently seen on IRC).
>
> Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
> the comment and the symbol depend on that.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Applied to master after moving the _ARCH_SUPPORTS to the top of the file and
adding Pedro's Rev-by and Tested-by, thanks.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported
2017-08-10 21:51 [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported Yann E. MORIN
2017-08-10 22:16 ` Arnout Vandecappelle
2017-08-11 12:08 ` Arnout Vandecappelle
@ 2017-09-05 22:00 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2017-09-05 22:00 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Currently, the comment that "valgrind needs shared libs" is not hidden
> when the architecture dependencies are not met, which can confuse some
> users (as recently seen on IRC).
> Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
> the comment and the symbol depend on that.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> Note: Cc-ing the people that have touched valgrind in the past 12
> months-or-so...
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported
@ 2017-08-10 22:20 Pedro Ribeiro
0 siblings, 0 replies; 5+ messages in thread
From: Pedro Ribeiro @ 2017-08-10 22:20 UTC (permalink / raw)
To: buildroot
Patch works fine.
Reviewed-and-tested-by: Pedro Ribeiro <pedrib@gmail.com>
--
Pedro Ribeiro
pedrib at gmail.com
PGP: 17EE 7884 06C9 DCA3 76A6 99E9 BC04 BAD1 DDF2 A2CE
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-05 22:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-10 21:51 [Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported Yann E. MORIN
2017-08-10 22:16 ` Arnout Vandecappelle
2017-08-11 12:08 ` Arnout Vandecappelle
2017-09-05 22:00 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2017-08-10 22:20 Pedro Ribeiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox