[Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported

[Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported

[Yann E. MORIN]

Currently, the comment that "valgrind needs shared libs" is not hidden
when the architecture dependencies are not met, which can confuse some
users (as recently seen on IRC).

Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
the comment and the symbol depend on that.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
Cc: J?r?me Pouiller <jezz@sysmic.org>
Cc: Peter Seiderer <ps.report@gmx.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

---
Note: Cc-ing the people that have touched valgrind in the past 12
months-or-so...
---
 package/valgrind/Config.in | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 40e219d95a..919bd1afb5 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -1,14 +1,19 @@
 comment "valgrind needs a toolchain w/ dynamic library"
+	depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS
 
+config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
+	bool
+	default y if BR2_ARM_CPU_ARMV7A
+	default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+	default y if BR2_i386 || BR2_x86_64
+	default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
+	depends on !BR2_MIPS_SOFT_FLOAT
+
 config BR2_PACKAGE_VALGRIND
 	bool "valgrind"
-	depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
-		   BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
-		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
-		   BR2_x86_64
+	depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
 	depends on !BR2_STATIC_LIBS
-	depends on !BR2_MIPS_SOFT_FLOAT
 	help
 	  Tool for debugging and profiling Linux programs.
 
-- 
2.11.0

[Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported

[Arnout Vandecappelle]

On 10-08-17 23:51, Yann E. MORIN wrote:
> Currently, the comment that "valgrind needs shared libs" is not hidden
> when the architecture dependencies are not met, which can confuse some
> users (as recently seen on IRC).
> 
> Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
> the comment and the symbol depend on that.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
with one small nit:

> 
> ---
> Note: Cc-ing the people that have touched valgrind in the past 12
> months-or-so...
> ---
>  package/valgrind/Config.in | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
> index 40e219d95a..919bd1afb5 100644
> --- a/package/valgrind/Config.in
> +++ b/package/valgrind/Config.in
> @@ -1,14 +1,19 @@
>  comment "valgrind needs a toolchain w/ dynamic library"
> +	depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
>  	depends on BR2_STATIC_LIBS
>  
> +config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS

 _ARCH_SUPPORTS is always the first thing in the file, even if the comment comes
before the main symbol (cfr. e.g. package/canfestival/Config.in,
package/erlang/Config.in)


 Regards,
 Arnout

> +	bool
> +	default y if BR2_ARM_CPU_ARMV7A
> +	default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
> +	default y if BR2_i386 || BR2_x86_64
> +	default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
> +	depends on !BR2_MIPS_SOFT_FLOAT
> +
>  config BR2_PACKAGE_VALGRIND
>  	bool "valgrind"
> -	depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
> -		   BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
> -		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
> -		   BR2_x86_64
> +	depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
>  	depends on !BR2_STATIC_LIBS
> -	depends on !BR2_MIPS_SOFT_FLOAT
>  	help
>  	  Tool for debugging and profiling Linux programs.
>  
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported

[Pedro Ribeiro]

Patch works fine.

Reviewed-and-tested-by: Pedro Ribeiro <pedrib@gmail.com>
-- 
Pedro Ribeiro

pedrib at gmail.com
PGP: 17EE 7884 06C9 DCA3 76A6 99E9 BC04 BAD1 DDF2 A2CE

[Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported

[Arnout Vandecappelle]

On 10-08-17 23:51, Yann E. MORIN wrote:
> Currently, the comment that "valgrind needs shared libs" is not hidden
> when the architecture dependencies are not met, which can confuse some
> users (as recently seen on IRC).
> 
> Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
> the comment and the symbol depend on that.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

 Applied to master after moving the _ARCH_SUPPORTS to the top of the file and
adding Pedro's Rev-by and Tested-by, thanks.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] package/valgrind: hide comment when arch is not supported

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Currently, the comment that "valgrind needs shared libs" is not hidden
 > when the architecture dependencies are not met, which can confuse some
 > users (as recently seen on IRC).

 > Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
 > the comment and the symbol depend on that.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
 > Cc: J?r?me Pouiller <jezz@sysmic.org>
 > Cc: Peter Seiderer <ps.report@gmx.net>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

 > ---
 > Note: Cc-ing the people that have touched valgrind in the past 12
 > months-or-so...

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard