[Buildroot] [PATCH] rsh-redone: new package for rsh/rlogin clients

[Buildroot] [PATCH] rsh-redone: new package for rsh/rlogin clients

[Mike Frysinger]

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 package/Config.in                |    1 +
 package/rsh-redone/Config.in     |   31 +++++++++++++++++++++++++++++++
 package/rsh-redone/rsh-redone.mk |   36 ++++++++++++++++++++++++++++++++++++
 3 files changed, 68 insertions(+), 0 deletions(-)
 create mode 100644 package/rsh-redone/Config.in
 create mode 100644 package/rsh-redone/rsh-redone.mk

diff --git a/package/Config.in b/package/Config.in
index 03e580a..d3629ff 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -415,6 +415,7 @@ source "package/rp-pppoe/Config.in"
 source "package/pptp-linux/Config.in"
 source "package/proftpd/Config.in"
 source "package/quagga/Config.in"
+source "package/rsh-redone/Config.in"
 source "package/rsync/Config.in"
 source "package/samba/Config.in"
 source "package/ser2net/Config.in"
diff --git a/package/rsh-redone/Config.in b/package/rsh-redone/Config.in
new file mode 100644
index 0000000..454bf30
--- /dev/null
+++ b/package/rsh-redone/Config.in
@@ -0,0 +1,31 @@
+config BR2_PACKAGE_RSH_REDONE
+	bool "rsh-redone"
+	help
+	  Rsh-redone is a reimplementation of the remote shell clients and
+	  servers.  It is written from the ground up to avoid the bugs found
+	  in the standard clients and servers.  It also fully supports IPv6.
+
+	  http://packages.debian.org/source/sid/rsh-redone
+
+# this is incomplete in the source
+#config BR2_PACKAGE_RSH_REDONE_RCP
+#	bool "rcp"
+#	depends on BR2_PACKAGE_RSH_REDONE
+
+config BR2_PACKAGE_RSH_REDONE_RLOGIN
+	bool "rlogin"
+	depends on BR2_PACKAGE_RSH_REDONE
+
+# requires PAM
+#config BR2_PACKAGE_RSH_REDONE_RLOGIND
+#	bool "rlogind"
+#	depends on BR2_PACKAGE_RSH_REDONE
+
+config BR2_PACKAGE_RSH_REDONE_RSH
+	bool "rsh"
+	depends on BR2_PACKAGE_RSH_REDONE
+
+# requires PAM
+#config BR2_PACKAGE_RSH_REDONE_RSHD
+#	bool "rshd"
+#	depends on BR2_PACKAGE_RSH_REDONE
diff --git a/package/rsh-redone/rsh-redone.mk b/package/rsh-redone/rsh-redone.mk
new file mode 100644
index 0000000..e90de37
--- /dev/null
+++ b/package/rsh-redone/rsh-redone.mk
@@ -0,0 +1,36 @@
+#############################################################
+#
+# rsh-redone
+#
+#############################################################
+
+RSH_REDONE_VERSION = 85
+RSH_REDONE_SOURCE = rsh-redone_$(RSH_REDONE_VERSION).orig.tar.gz
+RSH_REDONE_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/r/rsh-redone
+
+rsh-redone-bin-y :=
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RCP) += rcp
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RLOGIN) += rlogin
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RSH) += rsh
+rsh-redone-sbin-y :=
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RLOGIND) += rlogind
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RSHD) += rshd
+
+define RSH_REDONE_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" -C $(@D) BIN="$(rsh-redone-bin-y)" SBIN="$(rsh-redone-sbin-y)"
+endef
+
+define RSH_REDONE_INSTALL_TARGET_CMDS
+ifneq ($(rsh-redone-bin-y)$(rsh-redone-sbin-y),)
+	$(RSH_REDONE_BUILD_CMDS) DESTDIR=$(TARGET_DIR) \
+		$(if $(rsh-redone-bin-y),install-bin) \
+		$(if $(rsh-redone-sbin-y),install-sbin)
+endif
+endef
+
+define RSH_REDONE_UNINSTALL_TARGET_CMDS
+	rm -f $(patsubst %,$(TARGET_DIR)/usr/bin/%,$(rsh-redone-bin-y))
+	rm -f $(patsubst %,$(TARGET_DIR)/usr/sbin/%,$(rsh-redone-sbin-y))
+endef
+
+$(eval $(call GENTARGETS,package,rsh-redone))
-- 
1.7.3.2

[Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients

[Mike Frysinger]

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v2
	- the install target didn't work quite right in the empty case

 package/Config.in                |    1 +
 package/rsh-redone/Config.in     |   31 +++++++++++++++++++++++++++++++
 package/rsh-redone/rsh-redone.mk |   36 ++++++++++++++++++++++++++++++++++++
 3 files changed, 68 insertions(+), 0 deletions(-)
 create mode 100644 package/rsh-redone/Config.in
 create mode 100644 package/rsh-redone/rsh-redone.mk

diff --git a/package/Config.in b/package/Config.in
index 03e580a..d3629ff 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -415,6 +415,7 @@ source "package/rp-pppoe/Config.in"
 source "package/pptp-linux/Config.in"
 source "package/proftpd/Config.in"
 source "package/quagga/Config.in"
+source "package/rsh-redone/Config.in"
 source "package/rsync/Config.in"
 source "package/samba/Config.in"
 source "package/ser2net/Config.in"
diff --git a/package/rsh-redone/Config.in b/package/rsh-redone/Config.in
new file mode 100644
index 0000000..454bf30
--- /dev/null
+++ b/package/rsh-redone/Config.in
@@ -0,0 +1,31 @@
+config BR2_PACKAGE_RSH_REDONE
+	bool "rsh-redone"
+	help
+	  Rsh-redone is a reimplementation of the remote shell clients and
+	  servers.  It is written from the ground up to avoid the bugs found
+	  in the standard clients and servers.  It also fully supports IPv6.
+
+	  http://packages.debian.org/source/sid/rsh-redone
+
+# this is incomplete in the source
+#config BR2_PACKAGE_RSH_REDONE_RCP
+#	bool "rcp"
+#	depends on BR2_PACKAGE_RSH_REDONE
+
+config BR2_PACKAGE_RSH_REDONE_RLOGIN
+	bool "rlogin"
+	depends on BR2_PACKAGE_RSH_REDONE
+
+# requires PAM
+#config BR2_PACKAGE_RSH_REDONE_RLOGIND
+#	bool "rlogind"
+#	depends on BR2_PACKAGE_RSH_REDONE
+
+config BR2_PACKAGE_RSH_REDONE_RSH
+	bool "rsh"
+	depends on BR2_PACKAGE_RSH_REDONE
+
+# requires PAM
+#config BR2_PACKAGE_RSH_REDONE_RSHD
+#	bool "rshd"
+#	depends on BR2_PACKAGE_RSH_REDONE
diff --git a/package/rsh-redone/rsh-redone.mk b/package/rsh-redone/rsh-redone.mk
new file mode 100644
index 0000000..4736264
--- /dev/null
+++ b/package/rsh-redone/rsh-redone.mk
@@ -0,0 +1,36 @@
+#############################################################
+#
+# rsh-redone
+#
+#############################################################
+
+RSH_REDONE_VERSION = 85
+RSH_REDONE_SOURCE = rsh-redone_$(RSH_REDONE_VERSION).orig.tar.gz
+RSH_REDONE_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/r/rsh-redone
+
+rsh-redone-bin-y :=
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RCP) += rcp
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RLOGIN) += rlogin
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RSH) += rsh
+rsh-redone-sbin-y :=
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RLOGIND) += rlogind
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RSHD) += rshd
+
+define RSH_REDONE_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" -C $(@D) BIN="$(rsh-redone-bin-y)" SBIN="$(rsh-redone-sbin-y)"
+endef
+
+define RSH_REDONE_INSTALL_TARGET_CMDS
+	if [ -n "$(rsh-redone-bin-y)$(rsh-redone-sbin-y)" ] ; then \
+		$(RSH_REDONE_BUILD_CMDS) DESTDIR=$(TARGET_DIR) \
+			$(if $(rsh-redone-bin-y),install-bin) \
+			$(if $(rsh-redone-sbin-y),install-sbin); \
+	fi
+endef
+
+define RSH_REDONE_UNINSTALL_TARGET_CMDS
+	rm -f $(patsubst %,$(TARGET_DIR)/usr/bin/%,$(rsh-redone-bin-y))
+	rm -f $(patsubst %,$(TARGET_DIR)/usr/sbin/%,$(rsh-redone-sbin-y))
+endef
+
+$(eval $(call GENTARGETS,package,rsh-redone))
-- 
1.7.3.2

[Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients

[Peter Korsgaard]

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

Hi,

 Mike> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
 Mike> ---
 Mike> v2
 Mike> 	- the install target didn't work quite right in the empty case

 Mike> +# this is incomplete in the source
 Mike> +#config BR2_PACKAGE_RSH_REDONE_RCP
 Mike> +#	bool "rcp"
 Mike> +#	depends on BR2_PACKAGE_RSH_REDONE
 Mike> +
 Mike> +config BR2_PACKAGE_RSH_REDONE_RLOGIN
 Mike> +	bool "rlogin"
 Mike> +	depends on BR2_PACKAGE_RSH_REDONE
 Mike> +
 Mike> +# requires PAM
 Mike> +#config BR2_PACKAGE_RSH_REDONE_RLOGIND
 Mike> +#	bool "rlogind"
 Mike> +#	depends on BR2_PACKAGE_RSH_REDONE
 Mike> +
 Mike> +config BR2_PACKAGE_RSH_REDONE_RSH
 Mike> +	bool "rsh"
 Mike> +	depends on BR2_PACKAGE_RSH_REDONE
 Mike> +
 Mike> +# requires PAM
 Mike> +#config BR2_PACKAGE_RSH_REDONE_RSHD
 Mike> +#	bool "rshd"
 Mike> +#	depends on BR2_PACKAGE_RSH_REDONE

How useful is this without the server part?

 Mike> +define RSH_REDONE_BUILD_CMDS
 Mike> +	$(MAKE) CC="$(TARGET_CC)" -C $(@D) BIN="$(rsh-redone-bin-y)" SBIN="$(rsh-redone-sbin-y)"
 Mike> +endef

You seem to be missing TARGET_CFLAGS / TARGET_LDFLAGS?


 Mike> +
 Mike> +define RSH_REDONE_INSTALL_TARGET_CMDS
 Mike> +	if [ -n "$(rsh-redone-bin-y)$(rsh-redone-sbin-y)" ] ; then \
 Mike> +		$(RSH_REDONE_BUILD_CMDS) DESTDIR=$(TARGET_DIR) \
 Mike> +			$(if $(rsh-redone-bin-y),install-bin) \
 Mike> +			$(if $(rsh-redone-sbin-y),install-sbin); \
 Mike> +	fi
 Mike> +endef

Does this do anything else than just copying the binaries? If not, it
might be simpler to just do a

for i in $(rsh-redone-bin-y); do $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/bin/$$i; done
for i in $(rsh-redone-sbin-y); do $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/sbin/$$i; done

 Mike> +
 Mike> +define RSH_REDONE_UNINSTALL_TARGET_CMDS
 Mike> +	rm -f $(patsubst %,$(TARGET_DIR)/usr/bin/%,$(rsh-redone-bin-y))
 Mike> +	rm -f $(patsubst %,$(TARGET_DIR)/usr/sbin/%,$(rsh-redone-sbin-y))

We normally use addprefix rather than patsubst.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients

[Mike Frysinger]

On Tuesday, December 07, 2010 06:07:26 Peter Korsgaard wrote:
>  Mike> +# requires PAM
>  Mike> +#config BR2_PACKAGE_RSH_REDONE_RSHD
>  Mike> +#	bool "rshd"
>  Mike> +#	depends on BR2_PACKAGE_RSH_REDONE
> 
> How useful is this without the server part?

i use rshd from inetutils.  ive never tested rshd from this since it requires 
pam (as already documented).  someone else can if they care.

>  Mike> +
>  Mike> +define RSH_REDONE_INSTALL_TARGET_CMDS
>  Mike> +	if [ -n "$(rsh-redone-bin-y)$(rsh-redone-sbin-y)" ] ; then \
>  Mike> +		$(RSH_REDONE_BUILD_CMDS) DESTDIR=$(TARGET_DIR) \
>  Mike> +			$(if $(rsh-redone-bin-y),install-bin) \
>  Mike> +			$(if $(rsh-redone-sbin-y),install-sbin); \
>  Mike> +	fi
>  Mike> +endef
> 
> Does this do anything else than just copying the binaries? If not, it
> might be simpler to just do a
> 
> for i in $(rsh-redone-bin-y); do $(INSTALL) -m 755 -D $$i
> $(TARGET_DIR)/usr/bin/$$i; done for i in $(rsh-redone-sbin-y); do
> $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/sbin/$$i; done

i prefer to let the package build system do these simple steps to avoid 
worrying about changes in between version bumps.  this proposal for examples 
misses set*id on the binaries, and i'm not entirely sure it is more simple.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101207/032f0e7e/attachment.pgp>

[Buildroot] [PATCH v3] rsh-redone: new package for rsh/rlogin clients

[Mike Frysinger]

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 package/Config.in                |    1 +
 package/rsh-redone/Config.in     |   31 +++++++++++++++++++++++++++++++
 package/rsh-redone/rsh-redone.mk |   36 ++++++++++++++++++++++++++++++++++++
 3 files changed, 68 insertions(+), 0 deletions(-)
 create mode 100644 package/rsh-redone/Config.in
 create mode 100644 package/rsh-redone/rsh-redone.mk

diff --git a/package/Config.in b/package/Config.in
index 03e580a..d3629ff 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -415,6 +415,7 @@ source "package/rp-pppoe/Config.in"
 source "package/pptp-linux/Config.in"
 source "package/proftpd/Config.in"
 source "package/quagga/Config.in"
+source "package/rsh-redone/Config.in"
 source "package/rsync/Config.in"
 source "package/samba/Config.in"
 source "package/ser2net/Config.in"
diff --git a/package/rsh-redone/Config.in b/package/rsh-redone/Config.in
new file mode 100644
index 0000000..454bf30
--- /dev/null
+++ b/package/rsh-redone/Config.in
@@ -0,0 +1,31 @@
+config BR2_PACKAGE_RSH_REDONE
+	bool "rsh-redone"
+	help
+	  Rsh-redone is a reimplementation of the remote shell clients and
+	  servers.  It is written from the ground up to avoid the bugs found
+	  in the standard clients and servers.  It also fully supports IPv6.
+
+	  http://packages.debian.org/source/sid/rsh-redone
+
+# this is incomplete in the source
+#config BR2_PACKAGE_RSH_REDONE_RCP
+#	bool "rcp"
+#	depends on BR2_PACKAGE_RSH_REDONE
+
+config BR2_PACKAGE_RSH_REDONE_RLOGIN
+	bool "rlogin"
+	depends on BR2_PACKAGE_RSH_REDONE
+
+# requires PAM
+#config BR2_PACKAGE_RSH_REDONE_RLOGIND
+#	bool "rlogind"
+#	depends on BR2_PACKAGE_RSH_REDONE
+
+config BR2_PACKAGE_RSH_REDONE_RSH
+	bool "rsh"
+	depends on BR2_PACKAGE_RSH_REDONE
+
+# requires PAM
+#config BR2_PACKAGE_RSH_REDONE_RSHD
+#	bool "rshd"
+#	depends on BR2_PACKAGE_RSH_REDONE
diff --git a/package/rsh-redone/rsh-redone.mk b/package/rsh-redone/rsh-redone.mk
new file mode 100644
index 0000000..6217cb1
--- /dev/null
+++ b/package/rsh-redone/rsh-redone.mk
@@ -0,0 +1,36 @@
+#############################################################
+#
+# rsh-redone
+#
+#############################################################
+
+RSH_REDONE_VERSION = 85
+RSH_REDONE_SOURCE = rsh-redone_$(RSH_REDONE_VERSION).orig.tar.gz
+RSH_REDONE_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/r/rsh-redone
+
+rsh-redone-bin-y =
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RCP) += rcp
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RLOGIN) += rlogin
+rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RSH) += rsh
+rsh-redone-sbin-y =
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RLOGIND) += rlogind
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RSHD) += rshd
+
+define RSH_REDONE_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) BIN="$(rsh-redone-bin-y)" SBIN="$(rsh-redone-sbin-y)"
+endef
+
+define RSH_REDONE_INSTALL_TARGET_CMDS
+	$(if $(rsh-redone-bin-y)$(rsh-redone-sbin-y),
+		$(RSH_REDONE_BUILD_CMDS) DESTDIR=$(TARGET_DIR) \
+			$(if $(rsh-redone-bin-y),install-bin) \
+			$(if $(rsh-redone-sbin-y),install-sbin))
+endef
+
+define RSH_REDONE_UNINSTALL_TARGET_CMDS
+	rm -f \
+		$(addprefix $(TARGET_DIR)/usr/bin/,$(rsh-redone-bin-y)) \
+		$(addprefix $(TARGET_DIR)/usr/sbin/,$(rsh-redone-sbin-y))
+endef
+
+$(eval $(call GENTARGETS,package,rsh-redone))
-- 
1.7.3.2

[Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients

[Peter Korsgaard]

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

 Mike> On Tuesday, December 07, 2010 06:07:26 Peter Korsgaard wrote:
 Mike> +# requires PAM
 Mike> +#config BR2_PACKAGE_RSH_REDONE_RSHD
 Mike> +#	bool "rshd"
 Mike> +#	depends on BR2_PACKAGE_RSH_REDONE
 >> 
 >> How useful is this without the server part?

 Mike> i use rshd from inetutils.  ive never tested rshd from this since
 Mike> it requires pam (as already documented).  someone else can if
 Mike> they care.

Ok.

 >> Does this do anything else than just copying the binaries? If not, it
 >> might be simpler to just do a
 >> 
 >> for i in $(rsh-redone-bin-y); do $(INSTALL) -m 755 -D $$i
 >> $(TARGET_DIR)/usr/bin/$$i; done for i in $(rsh-redone-sbin-y); do
 >> $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/sbin/$$i; done

 Mike> i prefer to let the package build system do these simple steps to
 Mike> avoid worrying about changes in between version bumps.  this
 Mike> proposal for examples misses set*id on the binaries, and i'm not
 Mike> entirely sure it is more simple.

setuid/setgid wouldn't work anyway, as we don't do make install as
root. For that kind of stuff you have to define it in device_table.txt
like it's done for busybox.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients

[Mike Frysinger]

On Tuesday, December 07, 2010 16:20:31 Peter Korsgaard wrote:
>  >> Does this do anything else than just copying the binaries? If not, it
>  >> might be simpler to just do a
>  >> 
>  >> for i in $(rsh-redone-bin-y); do $(INSTALL) -m 755 -D $$i
>  >> $(TARGET_DIR)/usr/bin/$$i; done for i in $(rsh-redone-sbin-y); do
>  >> $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/sbin/$$i; done
> 
>  Mike> i prefer to let the package build system do these simple steps to
>  Mike> avoid worrying about changes in between version bumps.  this
>  Mike> proposal for examples misses set*id on the binaries, and i'm not
>  Mike> entirely sure it is more simple.
> 
> setuid/setgid wouldn't work anyway, as we don't do make install as
> root. For that kind of stuff you have to define it in device_table.txt
> like it's done for busybox.

sounds like a limitation in the build system somewhere.  the file is certainly 
installed into output/target/ with set*id.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101207/83f3f9b1/attachment-0001.pgp>

[Buildroot] [PATCH v3] rsh-redone: new package for rsh/rlogin clients

[Peter Korsgaard]

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

 Mike> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 Mike> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard