* [Buildroot] [git commit] support/tests: print failed command and output on assertRunOK error
@ 2022-12-27 20:40 Thomas Petazzoni via buildroot
2023-01-01 18:35 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-12-27 20:40 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=44161560dd52ebe9a41ee6e5ec8cacb2a9fe48ec
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Currently, when asserting that a command succeeded, we just capture the
return code of the command. If that is not zero, the assertion fails,
but the error message is not very splicit:
AssertionError: 1 != 0
Replace the error message with an explicit message that dumps the failed
command, the error code, and the resulting output.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
support/testing/infra/basetest.py | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/support/testing/infra/basetest.py b/support/testing/infra/basetest.py
index 96c6848dfc..45bcd4c2e2 100644
--- a/support/testing/infra/basetest.py
+++ b/support/testing/infra/basetest.py
@@ -88,7 +88,12 @@ class BRTest(BRConfigTest):
super(BRTest, self).tearDown()
# Run the given 'cmd' with a 'timeout' on the target and
- # assert that the command succeeded
+ # assert that the command succeeded; on error, print the
+ # faulty command and its output
def assertRunOk(self, cmd, timeout=-1):
- _, exit_code = self.emulator.run(cmd, timeout)
- self.assertEqual(exit_code, 0)
+ out, exit_code = self.emulator.run(cmd, timeout)
+ self.assertEqual(
+ exit_code,
+ 0,
+ "\nFailed to run: {}\noutput was:\n{}".format(cmd, ' '+'\n '.join(out))
+ )
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-01 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-27 20:40 [Buildroot] [git commit] support/tests: print failed command and output on assertRunOK error Thomas Petazzoni via buildroot
2023-01-01 18:35 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox