* [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip
@ 2013-09-11 9:12 Jerzy Grzegorek
2013-09-11 9:12 ` [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure Jerzy Grzegorek
2013-09-11 11:02 ` [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Jerzy Grzegorek @ 2013-09-11 9:12 UTC (permalink / raw)
To: buildroot
In BR sub-directory boot/ linux/ and package/ there are a few .mk files which
aren't <package>.mk files. These files shouldn't be taken into account
in package statistics.
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
---
support/scripts/pkg-stats | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
index a65a6ae..4effa59 100755
--- a/support/scripts/pkg-stats
+++ b/support/scripts/pkg-stats
@@ -87,18 +87,21 @@ for i in $(find boot/ linux/ package/ -name '*.mk' | sort) ; do
$i = "boot/common.mk" -o \
$i = "linux/linux-ext-xenomai.mk" -o \
$i = "linux/linux-ext-rtai.mk" -o \
- $i = "linux/linux-ext-ocf-linux.mk" -o \
$i = "package/efl/efl.mk" -o \
- $i = "package/games/games.mk" -o \
+ $i = "package/freescale-imx/freescale-imx.mk" -o \
+ $i = "package/gcc/gcc.mk" -o \
+ $i = "package/gstreamer/gstreamer.mk" -o \
+ $i = "package/gstreamer1/gstreamer1.mk" -o \
$i = "package/gtk2-themes/gtk2-themes.mk" -o \
- $i = "package/multimedia/multimedia.mk" -o \
+ $i = "package/matchbox/matchbox.mk" -o \
+ $i = "package/opengl/opengl.mk" -o \
+ $i = "package/qt5/qt5.mk" -o \
+ $i = "package/x11r7/x11r7.mk" -o \
$i = "package/pkg-autotools.mk" -o \
$i = "package/pkg-cmake.mk" -o \
+ $i = "package/pkg-download.mk" -o \
$i = "package/pkg-generic.mk" -o \
- $i = "package/pkg-utils.mk" -o \
- $i = "package/pkg-download.mk" -o \
- $i = "package/matchbox/matchbox.mk" -o \
- $i = "package/x11r7/x11r7.mk" ; then
+ $i = "package/pkg-utils.mk" ; then
echo "skipping $i" 1>&2
continue
fi
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure
2013-09-11 9:12 [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Jerzy Grzegorek
@ 2013-09-11 9:12 ` Jerzy Grzegorek
2013-09-11 9:53 ` Thomas De Schampheleire
2013-09-11 11:02 ` [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Jerzy Grzegorek @ 2013-09-11 9:12 UTC (permalink / raw)
To: buildroot
Typically each package invokes the macro which generates the Makefile code, in the way
like this: e.g. $(eval $(generic-package)) or $(eval $(autotools-package)) ,
but a few packages have to invoke this macro in other way:
$(eval $(call generic-package)) e.g. dhcpcd.mk
$(eval $(call autotools-package)) e.g. wireshark.mk .
This patch make changes to fix proper identification of package infrastructure.
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
---
support/scripts/pkg-stats | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
index 4effa59..e982d9c 100755
--- a/support/scripts/pkg-stats
+++ b/support/scripts/pkg-stats
@@ -118,7 +118,7 @@ for i in $(find boot/ linux/ package/ -name '*.mk' | sort) ; do
hashost=1
fi
- if grep -E "\(autotools-package\)" $i > /dev/null ; then
+ if grep -E "autotools-package\)" $i > /dev/null ; then
infratype="autotools"
hastarget=1
fi
@@ -128,7 +128,7 @@ for i in $(find boot/ linux/ package/ -name '*.mk' | sort) ; do
hashost=1
fi
- if grep -E "\(generic-package\)" $i > /dev/null ; then
+ if grep -E "generic-package\)" $i > /dev/null ; then
infratype="generic"
hastarget=1
fi
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure
2013-09-11 9:12 ` [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure Jerzy Grzegorek
@ 2013-09-11 9:53 ` Thomas De Schampheleire
2013-09-11 11:06 ` Peter Korsgaard
2013-09-11 11:24 ` Jerzy Grzegorek
0 siblings, 2 replies; 6+ messages in thread
From: Thomas De Schampheleire @ 2013-09-11 9:53 UTC (permalink / raw)
To: buildroot
Hi,
On Wed, Sep 11, 2013 at 11:12 AM, Jerzy Grzegorek
<jerzy.grzegorek@trzebnica.net> wrote:
> Typically each package invokes the macro which generates the Makefile code, in the way
> like this: e.g. $(eval $(generic-package)) or $(eval $(autotools-package)) ,
> but a few packages have to invoke this macro in other way:
> $(eval $(call generic-package)) e.g. dhcpcd.mk
> $(eval $(call autotools-package)) e.g. wireshark.mk .
I rather think that the 'call' is an accident. Arnout removed the need
for the extra $(call) in July 2012, with commit
e1502ebc0c92763896c53d405ee9c7c7a1a33e24, and both dhcpcd and
wireshark were added after that time. So I think this has been missed
during code review.
A quick search shows only three packages with a remaining $(eval
$(call)) construct: dhcpcd, wireshark, jquery-keyboard.
So I'd rather fix those packages...
Best regards,
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip
2013-09-11 9:12 [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Jerzy Grzegorek
2013-09-11 9:12 ` [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure Jerzy Grzegorek
@ 2013-09-11 11:02 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-09-11 11:02 UTC (permalink / raw)
To: buildroot
>>>>> "Jerzy" == Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> writes:
Jerzy> In BR sub-directory boot/ linux/ and package/ there are a few .mk files which
Jerzy> aren't <package>.mk files. These files shouldn't be taken into account
Jerzy> in package statistics.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure
2013-09-11 9:53 ` Thomas De Schampheleire
@ 2013-09-11 11:06 ` Peter Korsgaard
2013-09-11 11:24 ` Jerzy Grzegorek
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-09-11 11:06 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
Thomas> Hi,
Thomas> On Wed, Sep 11, 2013 at 11:12 AM, Jerzy Grzegorek
Thomas> <jerzy.grzegorek@trzebnica.net> wrote:
>> Typically each package invokes the macro which generates the Makefile code, in the way
>> like this: e.g. $(eval $(generic-package)) or $(eval $(autotools-package)) ,
>> but a few packages have to invoke this macro in other way:
>> $(eval $(call generic-package)) e.g. dhcpcd.mk
>> $(eval $(call autotools-package)) e.g. wireshark.mk .
Thomas> I rather think that the 'call' is an accident. Arnout removed the need
Thomas> for the extra $(call) in July 2012, with commit
Thomas> e1502ebc0c92763896c53d405ee9c7c7a1a33e24, and both dhcpcd and
Thomas> wireshark were added after that time. So I think this has been missed
Thomas> during code review.
Thomas> A quick search shows only three packages with a remaining $(eval
Thomas> $(call)) construct: dhcpcd, wireshark, jquery-keyboard.
Thomas> So I'd rather fix those packages...
Agreed, I've fixed those in git now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure
2013-09-11 9:53 ` Thomas De Schampheleire
2013-09-11 11:06 ` Peter Korsgaard
@ 2013-09-11 11:24 ` Jerzy Grzegorek
1 sibling, 0 replies; 6+ messages in thread
From: Jerzy Grzegorek @ 2013-09-11 11:24 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Thanks for the feedback.
> Hi,
>
> On Wed, Sep 11, 2013 at 11:12 AM, Jerzy Grzegorek
> <jerzy.grzegorek@trzebnica.net> wrote:
>> Typically each package invokes the macro which generates the Makefile code, in the way
>> like this: e.g. $(eval $(generic-package)) or $(eval $(autotools-package)) ,
>> but a few packages have to invoke this macro in other way:
>> $(eval $(call generic-package)) e.g. dhcpcd.mk
>> $(eval $(call autotools-package)) e.g. wireshark.mk .
> I rather think that the 'call' is an accident. Arnout removed the need
> for the extra $(call) in July 2012, with commit
> e1502ebc0c92763896c53d405ee9c7c7a1a33e24, and both dhcpcd and
> wireshark were added after that time. So I think this has been missed
> during code review.
>
> A quick search shows only three packages with a remaining $(eval
> $(call)) construct: dhcpcd, wireshark, jquery-keyboard.
> So I'd rather fix those packages...
Ah, I understand now.
Regards,
Jerzy
>
> Best regards,
> Thomas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-11 11:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 9:12 [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Jerzy Grzegorek
2013-09-11 9:12 ` [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure Jerzy Grzegorek
2013-09-11 9:53 ` Thomas De Schampheleire
2013-09-11 11:06 ` Peter Korsgaard
2013-09-11 11:24 ` Jerzy Grzegorek
2013-09-11 11:02 ` [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox