Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build
@ 2023-09-16 12:51 Fabrice Fontaine
  2023-09-16 13:21 ` Yann E. MORIN
  2023-09-24 21:15 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2023-09-16 12:51 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine, Christian Stewart

Drop patch and disable libseccomp when building statically to avoid the
following build failure raised since commit
29834d8a12d984e8efe05398c5aaa6a61f7880e0:

src/seccomp_notify.c: In function 'seccomp_notify_plugins_load':
src/seccomp_notify.c:136:42: warning: implicit declaration of function 'dlopen'; did you mean 'popen'? [-Wimplicit-function-declaration]
  136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
      |                                          ^~~~~~
      |                                          popen
src/seccomp_notify.c:136:53: error: 'RTLD_NOW' undeclared (first use in this function)
  136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
      |                                                     ^~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/13d3b46990720bba8621c922b5dce54ab650e96d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...01-remove-unused-dlfcn.h-header-file.patch | 26 -------------------
 package/conmon/conmon.mk                      |  2 +-
 2 files changed, 1 insertion(+), 27 deletions(-)
 delete mode 100644 package/conmon/0001-remove-unused-dlfcn.h-header-file.patch

diff --git a/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch b/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
deleted file mode 100644
index 14f817942e..0000000000
--- a/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
+++ /dev/null
@@ -1,26 +0,0 @@
-From e28634a0e847a14c58482f962bc9b1d69937387f Mon Sep 17 00:00:00 2001
-From: Waldemar Brodkorb <wbx@openadk.org>
-Date: Sat, 12 Aug 2023 12:53:37 +0200
-Subject: [PATCH] remove unused dlfcn.h header file
-
-Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
-Upstream: https://github.com/containers/conmon/issues/443
----
- src/seccomp_notify.c | 1 -
- 1 file changed, 1 deletion(-)
-
-diff --git a/src/seccomp_notify.c b/src/seccomp_notify.c
-index 8d34d9d..2a8371d 100644
---- a/src/seccomp_notify.c
-+++ b/src/seccomp_notify.c
-@@ -7,7 +7,6 @@
- 
- #include <errno.h>
- #include <sys/ioctl.h>
--#include <dlfcn.h>
- #include <sys/wait.h>
- #include <sys/mount.h>
- #include <signal.h>
--- 
-2.39.2
-
diff --git a/package/conmon/conmon.mk b/package/conmon/conmon.mk
index 29deb2af47..50807f8c6a 100644
--- a/package/conmon/conmon.mk
+++ b/package/conmon/conmon.mk
@@ -11,7 +11,7 @@ CONMON_LICENSE_FILES = LICENSE
 
 CONMON_DEPENDENCIES = host-pkgconf libglib2
 
-ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
+ifeq ($(BR2_PACKAGE_LIBSECCOMP):$(BR2_STATIC_LIBS),y:)
 CONMON_DISABLE_SECCOMP = 0
 CONMON_DEPENDENCIES += libseccomp
 else
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build
  2023-09-16 12:51 [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build Fabrice Fontaine
@ 2023-09-16 13:21 ` Yann E. MORIN
  2023-09-24 21:15 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2023-09-16 13:21 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Christian Stewart, buildroot

Fabrice, All,

On 2023-09-16 14:51 +0200, Fabrice Fontaine spake thusly:
> Drop patch and disable libseccomp when building statically to avoid the
> following build failure raised since commit
> 29834d8a12d984e8efe05398c5aaa6a61f7880e0:
> 
> src/seccomp_notify.c: In function 'seccomp_notify_plugins_load':
> src/seccomp_notify.c:136:42: warning: implicit declaration of function 'dlopen'; did you mean 'popen'? [-Wimplicit-function-declaration]
>   136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
>       |                                          ^~~~~~
>       |                                          popen
> src/seccomp_notify.c:136:53: error: 'RTLD_NOW' undeclared (first use in this function)
>   136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
>       |                                                     ^~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/13d3b46990720bba8621c922b5dce54ab650e96d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  ...01-remove-unused-dlfcn.h-header-file.patch | 26 -------------------
>  package/conmon/conmon.mk                      |  2 +-
>  2 files changed, 1 insertion(+), 27 deletions(-)
>  delete mode 100644 package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
> 
> diff --git a/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch b/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
> deleted file mode 100644
> index 14f817942e..0000000000
> --- a/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -From e28634a0e847a14c58482f962bc9b1d69937387f Mon Sep 17 00:00:00 2001
> -From: Waldemar Brodkorb <wbx@openadk.org>
> -Date: Sat, 12 Aug 2023 12:53:37 +0200
> -Subject: [PATCH] remove unused dlfcn.h header file
> -
> -Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> -Upstream: https://github.com/containers/conmon/issues/443
> ----
> - src/seccomp_notify.c | 1 -
> - 1 file changed, 1 deletion(-)
> -
> -diff --git a/src/seccomp_notify.c b/src/seccomp_notify.c
> -index 8d34d9d..2a8371d 100644
> ---- a/src/seccomp_notify.c
> -+++ b/src/seccomp_notify.c
> -@@ -7,7 +7,6 @@
> - 
> - #include <errno.h>
> - #include <sys/ioctl.h>
> --#include <dlfcn.h>
> - #include <sys/wait.h>
> - #include <sys/mount.h>
> - #include <signal.h>
> --- 
> -2.39.2
> -
> diff --git a/package/conmon/conmon.mk b/package/conmon/conmon.mk
> index 29deb2af47..50807f8c6a 100644
> --- a/package/conmon/conmon.mk
> +++ b/package/conmon/conmon.mk
> @@ -11,7 +11,7 @@ CONMON_LICENSE_FILES = LICENSE
>  
>  CONMON_DEPENDENCIES = host-pkgconf libglib2
>  
> -ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
> +ifeq ($(BR2_PACKAGE_LIBSECCOMP):$(BR2_STATIC_LIBS),y:)
>  CONMON_DISABLE_SECCOMP = 0
>  CONMON_DEPENDENCIES += libseccomp
>  else
> -- 
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build
  2023-09-16 12:51 [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build Fabrice Fontaine
  2023-09-16 13:21 ` Yann E. MORIN
@ 2023-09-24 21:15 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-09-24 21:15 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Christian Stewart, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Drop patch and disable libseccomp when building statically to avoid the
 > following build failure raised since commit
 > 29834d8a12d984e8efe05398c5aaa6a61f7880e0:

 > src/seccomp_notify.c: In function 'seccomp_notify_plugins_load':
 > src/seccomp_notify.c:136:42: warning: implicit declaration of function
 > 'dlopen'; did you mean 'popen'? [-Wimplicit-function-declaration]
 >   136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
 >       |                                          ^~~~~~
 >       |                                          popen
 > src/seccomp_notify.c:136:53: error: 'RTLD_NOW' undeclared (first use in this function)
 >   136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
 >       |                                                     ^~~~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/13d3b46990720bba8621c922b5dce54ab650e96d

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-24 21:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-16 12:51 [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build Fabrice Fontaine
2023-09-16 13:21 ` Yann E. MORIN
2023-09-24 21:15 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox