[Buildroot] Patch review

[Buildroot] Patch review

[Nick Peirson]

Would it be possible for the patch against bug 
http://bugs.uclibc.org/view.php?id=5674 to be reviewed and, hopefully, 
commited to svn?

The patch (attached) bumps the syslinux version and updates the patches 
required for it to compile.

-- 
Thanks

Nick Peirson

--
Internet Central Ltd is a limited company registered in England. 
Registered number: 3079542. Registered office: Ivy House Foundry, 
Hanley, Stoke-on-Trent ST1 3NR.

This message is private and confidential. If you have received this 
message in error, please notify us and remove it from your system.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: syslinux-3.72.patch
Type: text/x-patch
Size: 3521 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20081031/ad373d52/attachment.bin 

[Buildroot] Patch review

[Bernhard Reutner-Fischer]

On Fri, Oct 31, 2008 at 09:50:39AM +0000, Nick Peirson wrote:
> Would it be possible for the patch against bug  
> http://bugs.uclibc.org/view.php?id=5674 to be reviewed and, hopefully,  
> commited to svn?
>
> The patch (attached) bumps the syslinux version and updates the patches  
> required for it to compile.

I did not need any patches to syslinux itself but had to add nasm
support for both the host and the target?

Did you send the non-makefile patch upstream? If you didn't already then
please do now..

[Buildroot] Patch review

[Nick Peirson]

Bernhard Reutner-Fischer wrote:
> I did not need any patches to syslinux itself but had to add nasm
> support for both the host and the target?

I added nasm on the host, but didn't make any changes to the target. The 
error I was getting was due to syslinux makefile specifying "-Wall 
-Werror" and printf throwing a warning when called without a format string.

> Did you send the non-makefile patch upstream? If you didn't already then
> please do now..

I wasn't sure if the bug was related to buildroot/uclibc, which I 
mentioned in the bug notes, but I'll send it upstream and see what's 
made of it.

Thanks
Nick

[Buildroot] Patch review

[Nick Peirson]

Nick Peirson wrote:
> Bernhard Reutner-Fischer wrote:
>> Did you send the non-makefile patch upstream? If you didn't already then
>> please do now..
> 
> I wasn't sure if the bug was related to buildroot/uclibc, which I
> mentioned in the bug notes, but I'll send it upstream and see what's
> made of it.
> 

Posted the patch on the syslinux list, but apparently there's already a 
fix upstream of syslinux.

Can the patch I attached be applied to the buildroot svn? Currently the 
syslinux.mk points to a version of syslinux that isn't available and 
will break the build.

I can create a patch to move to 3.63 if that's preferred, as there 
aren't as many changes, although going to 3.72 seems preferable to me?

-- 
Regards

Nick Peirson

--
Internet Central Ltd is a limited company registered in England. 
Registered number: 3079542. Registered office: Ivy House Foundry, 
Hanley, Stoke-on-Trent ST1 3NR.

This message is private and confidential. If you have received this 
message in error, please notify us and remove it from your system.

[Buildroot] Patch review

[Peter Korsgaard]

>>>>> "Nick" == Nick Peirson <nick@netcentral.co.uk> writes:

Hi,

 Nick> Can the patch I attached be applied to the buildroot svn? Currently the 
 Nick> syslinux.mk points to a version of syslinux that isn't available and 
 Nick> will break the build.

 Nick> I can create a patch to move to 3.63 if that's preferred, as there 
 Nick> aren't as many changes, although going to 3.72 seems preferable to me?