[Buildroot] [PATCH] package/jose: needs shared libraries

[Buildroot] [PATCH] package/jose: needs shared libraries

[Peter Korsgaard]

Fixes https://autobuild.buildroot.net/results/bf23e75461877a4ca3a189626f30cf8cde24de36/

Jose unconditionally builds a shared library since v11 with:

 commit b72f8cad002edc87286dd1f2331c359158c512e8
 Author: Rosen Penev <rosenp@gmail.com>
 Date:   Tue May 30 12:18:30 2023 +0300

   jose: build library only as shared (#119)

   Needed because of constructor usage in library.

So add a dependency on BR2_SHARED_LIBS.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/jose/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/jose/Config.in b/package/jose/Config.in
index 4a9ed8da65..32e17276b6 100644
--- a/package/jose/Config.in
+++ b/package/jose/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_JOSE
 	bool "jose"
+	depends on BR2_SHARED_LIBS # builds .so
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_JANSSON
@@ -10,5 +11,5 @@ config BR2_PACKAGE_JOSE
 
 	  https://github.com/latchset/jose
 
-comment "jose needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "jose needs a toolchain w/ shared libraries, threads"
+	depends on !BR2_SHARED_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/jose: needs shared libraries

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes https://autobuild.buildroot.net/results/bf23e75461877a4ca3a189626f30cf8cde24de36/
 > Jose unconditionally builds a shared library since v11 with:

 >  commit b72f8cad002edc87286dd1f2331c359158c512e8
 >  Author: Rosen Penev <rosenp@gmail.com>
 >  Date:   Tue May 30 12:18:30 2023 +0300

 >    jose: build library only as shared (#119)

 >    Needed because of constructor usage in library.

 > So add a dependency on BR2_SHARED_LIBS.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/jose: needs shared libraries

[Thomas Perale via buildroot]

In reply of:
> Fixes https://autobuild.buildroot.net/results/bf23e75461877a4ca3a189626f30cf8cde24de36/
> 
> Jose unconditionally builds a shared library since v11 with:
> 
>  commit b72f8cad002edc87286dd1f2331c359158c512e8
>  Author: Rosen Penev <rosenp@gmail.com>
>  Date:   Tue May 30 12:18:30 2023 +0300
> 
>    jose: build library only as shared (#119)
> 
>    Needed because of constructor usage in library.
> 
> So add a dependency on BR2_SHARED_LIBS.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to 2025.02.x & 2025.05.x. Thanks

> ---
>  package/jose/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/jose/Config.in b/package/jose/Config.in
> index 4a9ed8da65..32e17276b6 100644
> --- a/package/jose/Config.in
> +++ b/package/jose/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_JOSE
>  	bool "jose"
> +	depends on BR2_SHARED_LIBS # builds .so
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_ZLIB
>  	select BR2_PACKAGE_JANSSON
> @@ -10,5 +11,5 @@ config BR2_PACKAGE_JOSE
>  
>  	  https://github.com/latchset/jose
>  
> -comment "jose needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +comment "jose needs a toolchain w/ shared libraries, threads"
> +	depends on !BR2_SHARED_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
> -- 
> 2.39.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot