[Buildroot] [git commit] CHANGES: add #163 + #473

[Buildroot] [git commit] CHANGES: add #163 + #473

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=0aa7062407d810bcaf999b61d4e2e1974c20632b
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 CHANGES |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/CHANGES b/CHANGES
index 781f5cf..3d61bc7 100644
--- a/CHANGES
+++ b/CHANGES
@@ -3,6 +3,7 @@
 	Issues resolved (http://bugs.uclibc.org):
 
 	#83: liblockfile fails to compile due to eaccess redefinition
+	#163: Xtensa architecture port
 	#241: device mapper + lvm2: build together
 	#271: Library 'libgcc_s.so.1' not installed in search path
 	#333: Bump sqlite package to 3.6.15
@@ -23,6 +24,7 @@
 	#417: New package spawn-fcgi
 	#419: Bump lighttpd package to 1.4.23
 	#467: DirectFB 1.4.1
+	#473: memstat_0.5.tar.gz has install with -D and that fails "make"
 
 2009.05, Released June 1st, 2009:
 
-- 
1.6.3.3

[Buildroot] [git commit] CHANGES: add #163 + #473

[Thomas Petazzoni]

Le Fri, 24 Jul 2009 07:51:16 +0200,
Peter Korsgaard <jacmet@sunsite.dk> a ?crit :

> +	#163: Xtensa architecture port

I might wrong or be missing something, but I haven't seen the
corresponding commits for this (maybe patches too large for the list ?).

But if it was really committed, I was quite worried by the complexity
added by the ? overlay ? mechanism proposed by this new architecture
port, and that a public discussion on this new mechanism could have
been interesting to see if it's the best solution, if it's the way we
want Buildroot to go forward, etc.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] CHANGES: add #163 + #473

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

hi,

 Thomas> Le Fri, 24 Jul 2009 07:51:16 +0200,
 Thomas> Peter Korsgaard <jacmet@sunsite.dk> a ?crit :

 >> +	#163: Xtensa architecture port

 Thomas> I might wrong or be missing something, but I haven't seen the
 Thomas> corresponding commits for this (maybe patches too large for
 Thomas> the list ?).

Yes, they are committed and I haven't seen the mails either - seems
like the commit hook has issues when I push multiple changes at once.

(Or it might be something else, I'm having mail and hw problems
today).

 Thomas> But if it was really committed, I was quite worried by the
 Thomas> complexity added by the ? overlay ? mechanism proposed by
 Thomas> this new architecture port, and that a public discussion on
 Thomas> this new mechanism could have been interesting to see if it's
 Thomas> the best solution, if it's the way we want Buildroot to go
 Thomas> forward, etc.

The patches were discussed on the list when they were first submitted,
afaik without much comments. the xtensa people have been asking about
it several times, and I finally promised to commit after 2009.05 was
released:

http://lists.busybox.net/pipermail/buildroot/2009-May/027503.html

I agree that the xtensa stuff is "special" in various ways, but I
think it's more productive to get it into git and then work on getting
it cleaned up more, instead of having it gather dust in bugzilla.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] CHANGES: add #163 + #473

[Thomas Petazzoni]

Le Fri, 24 Jul 2009 15:02:42 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :

> Yes, they are committed and I haven't seen the mails either - seems
> like the commit hook has issues when I push multiple changes at once.
> 
> (Or it might be something else, I'm having mail and hw problems
> today).

I haven't seen the mails either. So not likely to be a problem on your
side.

> I agree that the xtensa stuff is "special" in various ways, but I
> think it's more productive to get it into git and then work on getting
> it cleaned up more, instead of having it gather dust in bugzilla.

Ok, fair enough. Reading the patches again, they don't look too
invasive after all.

I'm concerned by the licensing of
target/xtensa/xt-buildroot-overlay-install, since this file states:

+# Copyright (c) 2003-2008 by Tensilica Inc. ALL RIGHTS RESERVED.
+# These coded instructions, statements, and computer programs are the
+# copyrighted works and confidential proprietary information of Tensilica Inc.
+# They may not be modified, copied, reproduced, distributed, or disclosed to
+# third parties in any manner, medium, or form, in whole or in part, without
+# the prior written consent of Tensilica Inc.

BTW, was Perl already a host dependency to run Buildroot ?

Sincerly,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] CHANGES: add #163 + #473

[Gustavo Zacarias]

Thomas Petazzoni wrote:

> BTW, was Perl already a host dependency to run Buildroot ?

It probably should be if it's not yet so, some packages depend on it for
building, off the top of my head i'd say openssl, it's Configure script
is integrally made in perl.
Also someone update the TODO, i think it's a bit outdated :)
Regards.

[Buildroot] [git commit] CHANGES: add #163 + #473

[Peter Korsgaard]

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Thomas Petazzoni wrote:
 >> BTW, was Perl already a host dependency to run Buildroot ?

 Gustavo> It probably should be if it's not yet so, some packages
 Gustavo> depend on it for building, off the top of my head i'd say
 Gustavo> openssl, it's Configure script is integrally made in perl.

Exactly. The kernel also needs it.

 Gustavo> Also someone update the TODO, i think it's a bit outdated :)

Thanks, done.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] CHANGES: add #163 + #473

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> I agree that the xtensa stuff is "special" in various ways, but I
 >> think it's more productive to get it into git and then work on
 >> getting it cleaned up more, instead of having it gather dust in
 >> bugzilla.

 Thomas> Ok, fair enough. Reading the patches again, they don't look
 Thomas> too invasive after all.

No, it is pretty much self contained.

 Thomas> I'm concerned by the licensing of
 Thomas> target/xtensa/xt-buildroot-overlay-install, since this file
 Thomas> states:

 Thomas> +# Copyright (c) 2003-2008 by Tensilica Inc. ALL RIGHTS
 Thomas> +RESERVED.  # These coded instructions, statements, and
 Thomas> +computer programs are the # copyrighted works and
 Thomas> +confidential proprietary information of Tensilica Inc.

Yes, that doesn't fly with the GPL requirements. Maxim, is it OK with
you to get rid of that header?

 Thomas> BTW, was Perl already a host dependency to run Buildroot ?

Well, it is indirectly as you need Perl to build Linux + a number of
packages, but nothing in buildroot self was using Perl.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] CHANGES: add #163 + #473

[Maxim Grigoriev]

 Thomas> I'm concerned by the licensing of
 Thomas> target/xtensa/xt-buildroot-overlay-install, since this file
 Thomas> states:

 Thomas> +# Copyright (c) 2003-2008 by Tensilica Inc. ALL RIGHTS
 Thomas> +RESERVED.  # These coded instructions, statements, and
 Thomas> +computer programs are the # copyrighted works and
 Thomas> +confidential proprietary information of Tensilica Inc.

>> Yes, that doesn't fly with the GPL requirements. Maxim, is it OK with
>> you to get rid of that header?

Absolutely. I am sorry for any inconvenience.

-- Maxim

Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>>>>>>             
>
> Hi,
>
>  >> I agree that the xtensa stuff is "special" in various ways, but I
>  >> think it's more productive to get it into git and then work on
>  >> getting it cleaned up more, instead of having it gather dust in
>  >> bugzilla.
>
>  Thomas> Ok, fair enough. Reading the patches again, they don't look
>  Thomas> too invasive after all.
>
> No, it is pretty much self contained.
>
>  Thomas> I'm concerned by the licensing of
>  Thomas> target/xtensa/xt-buildroot-overlay-install, since this file
>  Thomas> states:
>
>  Thomas> +# Copyright (c) 2003-2008 by Tensilica Inc. ALL RIGHTS
>  Thomas> +RESERVED.  # These coded instructions, statements, and
>  Thomas> +computer programs are the # copyrighted works and
>  Thomas> +confidential proprietary information of Tensilica Inc.
>
> Yes, that doesn't fly with the GPL requirements. Maxim, is it OK with
> you to get rid of that header?
>
>  Thomas> BTW, was Perl already a host dependency to run Buildroot ?
>
> Well, it is indirectly as you need Perl to build Linux + a number of
> packages, but nothing in buildroot self was using Perl.
>
>   

[Buildroot] [git commit] CHANGES: add #163 + #473

[Marc Gauthier]

Thomas Petazzoni wrote:
> Ok, fair enough. Reading the patches again, they don't look too
> invasive after all.
>
> I'm concerned by the licensing of
> target/xtensa/xt-buildroot-overlay-install, since this file states:
>
> +# Copyright (c) 2003-2008 by Tensilica Inc. ALL RIGHTS RESERVED.
> +# These coded instructions, statements, and computer programs are the
> +# copyrighted works and confidential proprietary information
> of Tensilica Inc.
> +# They may not be modified, copied, reproduced, distributed,
> or disclosed to
> +# third parties in any manner, medium, or form, in whole or
> in part, without
> +# the prior written consent of Tensilica Inc.

Oops, that license is meant for internal/commercial things,
not for open source obviously.  The file started out outside
buildroot, and I didn't notice when putting it in.

You can certainly take it out other than the copyright line.
Do you want a patch for that?


> BTW, was Perl already a host dependency to run Buildroot ?

That script is not necessary to run buildroot.  It's only
useful when installing a new Xtensa processor configuration
into the buildroot sources.

Otherwise I don't think the Xtensa port has introduced any
perl dependency, although I can live with such a dependency
limited to the Xtensa arch.

Thanks!
-Marc

[Buildroot] [git commit] CHANGES: add #163 + #473

[Peter Korsgaard]

>>>>> "Marc" == Marc Gauthier <marc@tensilica.com> writes:

Hi,

 Marc> Oops, that license is meant for internal/commercial things, not
 Marc> for open source obviously.  The file started out outside
 Marc> buildroot, and I didn't notice when putting it in.

 Marc> You can certainly take it out other than the copyright line.
 Marc> Do you want a patch for that?

Yes please.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] CHANGES: add #163 + #473

[Maxim Grigoriev]

I've attached the patch.

Thanks much for working on this.

-- Maxim

Peter Korsgaard wrote:
>>>>>> "Marc" == Marc Gauthier <marc@tensilica.com> writes:
>>>>>>             
>
> Hi,
>
>  Marc> Oops, that license is meant for internal/commercial things, not
>  Marc> for open source obviously.  The file started out outside
>  Marc> buildroot, and I didn't notice when putting it in.
>
>  Marc> You can certainly take it out other than the copyright line.
>  Marc> Do you want a patch for that?
>
> Yes please.
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PATCH.diff
Type: text/x-patch
Size: 1210 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090724/5138eb8c/attachment-0001.bin>

[Buildroot] [git commit] CHANGES: add #163 + #473

[Peter Korsgaard]

>>>>> "Maxim" == Maxim Grigoriev <maxim@tensilica.com> writes:

 Maxim> I've attached the patch.
 Maxim> Thanks much for working on this.

Great. Your patch seems to have gotten corrupted by the mailer, but I
applied it by hand.

 Maxim> Author: Maxim Grigoriev <maxim@tensilica.com>  2009-07-24 11:10:14
 Maxim> Committer: Maxim Grigoriev <maxim@tensilica.com>  2009-07-24 11:10:14
 Maxim> Parent: 5d79f6caf0d62a3458c4911489d684ba13b52e95 (TODO: remove outdated stuff)
 Maxim> Branch: master
 Maxim> Follows: 2009.05
 Maxim> Precedes: 

 Maxim>     [XTENSA] Remove Copyright notes. They contradict GPL license.
    
 Maxim>     Signed-off-by: Maxim Grigoriev <maxim@tensilica.com>

 Maxim> ------------------ target/xtensa/xt-buildroot-overlay-install ------------------
 Maxim> index 254da10..d2afce1 100644
 Maxim> @@ -19,13 +19,7 @@ exit $?
 Maxim>  #	<xtensa_root>/src/xtensa-config-overlay.tar.gz
 Maxim>  #  where <xtensa_root> is the path to the Tensilica Core Package.
 Maxim>  #
 Maxim> -# Copyright (c) 2003-2008 by Tensilica Inc.  ALL RIGHTS RESERVED.
 Maxim> -# These coded instructions, statements, and computer programs are the
 Maxim> -# copyrighted works and confidential proprietary information of Tensilica Inc.
 Maxim> -# They may not be modified, copied, reproduced, distributed, or disclosed to
 Maxim> -# third parties in any manner, medium, or form, in whole or in part, without
 Maxim> -# the prior written consent of Tensilica Inc.
 Maxim> -#
 Maxim> +# Copyright (c) 2003-2009 by Tensilica Inc.
 Maxim>  #  History:
 Maxim>  #  2007-NOV-08	1.0	meg	Initial version
 Maxim>  #  2007-NOV-21	1.1	meg	Add -k parameter

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] CHANGES: add #163 + #473

[Maxim Grigoriev]

I'm concerned by the licensing of
target/xtensa/xt-buildroot-overlay-install, since this file states:

+# Copyright (c) 2003-2008 by Tensilica Inc. ALL RIGHTS RESERVED.
+# These coded instructions, statements, and computer programs are the
+# copyrighted works and confidential proprietary information of Tensilica Inc.
+# They may not be modified, copied, reproduced, distributed, or disclosed to
+# third parties in any manner, medium, or form, in whole or in part, without
+# the prior written consent of Tensilica Inc.

This one has to be fixed, of course.

If you can, please, simply remove the copyright I'd really appreciate it.

I don't hove a write-access to Buildroot.

-- Maxim

Thomas Petazzoni wrote:
> Le Fri, 24 Jul 2009 15:02:42 +0200,
> Peter Korsgaard <jacmet@uclibc.org> a ?crit :
>
>   
>> Yes, they are committed and I haven't seen the mails either - seems
>> like the commit hook has issues when I push multiple changes at once.
>>
>> (Or it might be something else, I'm having mail and hw problems
>> today).
>>     
>
> I haven't seen the mails either. So not likely to be a problem on your
> side.
>
>   
>> I agree that the xtensa stuff is "special" in various ways, but I
>> think it's more productive to get it into git and then work on getting
>> it cleaned up more, instead of having it gather dust in bugzilla.
>>     
>
> Ok, fair enough. Reading the patches again, they don't look too
> invasive after all.
>
> I'm concerned by the licensing of
> target/xtensa/xt-buildroot-overlay-install, since this file states:
>
> +# Copyright (c) 2003-2008 by Tensilica Inc. ALL RIGHTS RESERVED.
> +# These coded instructions, statements, and computer programs are the
> +# copyrighted works and confidential proprietary information of Tensilica Inc.
> +# They may not be modified, copied, reproduced, distributed, or disclosed to
> +# third parties in any manner, medium, or form, in whole or in part, without
> +# the prior written consent of Tensilica Inc.
>
> BTW, was Perl already a host dependency to run Buildroot ?
>
> Sincerly,
>
> Thomas
>   

[Buildroot] [git commit] CHANGES: add #163 + #473

[Thomas Petazzoni]

Le Fri, 24 Jul 2009 15:02:42 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :

> I agree that the xtensa stuff is "special" in various ways, but I
> think it's more productive to get it into git and then work on getting
> it cleaned up more, instead of having it gather dust in bugzilla.

Wouldn't it be nice to require some documentation together with that
kind of change ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] CHANGES: add #163 + #473

[Maxim Grigoriev]

>> Wouldn't it be nice to require some documentation together with that
>> kind of change ?

Good idea. I will work on it.

Thanks,
-- Maxim


Thomas Petazzoni wrote:
> Le Fri, 24 Jul 2009 15:02:42 +0200,
> Peter Korsgaard <jacmet@uclibc.org> a ?crit :
>
>   
>> I agree that the xtensa stuff is "special" in various ways, but I
>> think it's more productive to get it into git and then work on getting
>> it cleaned up more, instead of having it gather dust in bugzilla.
>>     
>
> Wouldn't it be nice to require some documentation together with that
> kind of change ?
>
> Thomas
>   

[Buildroot] [git commit] CHANGES: add #163 + #473

[Maxim Grigoriev]

Hello Thomas,

 >> Wouldn't it be nice to require some documentation together with that

>> kind of change ?

Can you please, elaborate on this ?

Do you want to see a documentation about how Xtensa source overlays work ?
The rest of the update seems similar to other architectures.

If this is what you meant, where is the best place to put this document ?

Thanks,
-- Maxim

Maxim Grigoriev wrote:
>>> Wouldn't it be nice to require some documentation together with that
>>> kind of change ?
>>>       
>
> Good idea. I will work on it.
>
> Thanks,
> -- Maxim
>
>
> Thomas Petazzoni wrote:
>   
>> Le Fri, 24 Jul 2009 15:02:42 +0200,
>> Peter Korsgaard <jacmet@uclibc.org> a ??crit :
>>
>>   
>>     
>>> I agree that the xtensa stuff is "special" in various ways, but I
>>> think it's more productive to get it into git and then work on getting
>>> it cleaned up more, instead of having it gather dust in bugzilla.
>>>     
>>>       
>> Wouldn't it be nice to require some documentation together with that
>> kind of change ?
>>
>> Thomas
>>   
>>     
>
>
>   

[Buildroot] [git commit] CHANGES: add #163 + #473

[Marc Gauthier]

Maxim Grigoriev wrote:
> Hello Thomas,
>
>  >> Wouldn't it be nice to require some documentation
>  >> together with that kind of change ?
>
> Can you please, elaborate on this ?
>
> Do you want to see a documentation about how Xtensa source
> overlays work ?
> The rest of the update seems similar to other architectures.
>
> If this is what you meant, where is the best place to put
> this document ?


If the request is for info about the use of overlays, here's
a relevant link:

 http://wiki.linux-xtensa.org/index.php/Buildroot_Build_Instructions

-Marc


> Thanks,
> -- Maxim
>
> Maxim Grigoriev wrote:
> >>> Wouldn't it be nice to require some documentation
> together with that
> >>> kind of change ?
> >>>
> >
> > Good idea. I will work on it.
> >
> > Thanks,
> > -- Maxim
> >
> >
> > Thomas Petazzoni wrote:
> >
> >> Le Fri, 24 Jul 2009 15:02:42 +0200,
> >> Peter Korsgaard <jacmet@uclibc.org> a ??crit :
> >>
> >>
> >>
> >>> I agree that the xtensa stuff is "special" in various ways, but I
> >>> think it's more productive to get it into git and then
> work on getting
> >>> it cleaned up more, instead of having it gather dust in bugzilla.
> >>>
> >>>
> >> Wouldn't it be nice to require some documentation together
> with that
> >> kind of change ?
> >>
> >> Thomas
> >>
> >>
> >
> >
> >
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>