* [Buildroot] [PATCH 1/1] package/openssh: fix linux-pam select
@ 2024-02-24 21:30 Fabrice Fontaine
2024-02-25 8:02 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2024-02-24 21:30 UTC (permalink / raw)
To: buildroot; +Cc: Adam Duskett, Fabrice Fontaine
Commit 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb forgot to handle
linux-pam dependencies resulting in the following build failure:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM
Depends on [n]: BR2_ENABLE_LOCALE [=n] && BR2_USE_WCHAR [=n] && !BR2_STATIC_LIBS [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=y]
Selected by [y]:
- BR2_PACKAGE_OPENSSH [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION [=y]
WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM
Depends on [n]: BR2_ENABLE_LOCALE [=n] && BR2_USE_WCHAR [=n] && !BR2_STATIC_LIBS [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=y]
Selected by [y]:
- BR2_PACKAGE_OPENSSH [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION [=y]
[...]
configure: error: in `/home/autobuild/autobuild/instance-12/output-1/build/linux-pam-1.6.0':
configure: error: failed to find dlopen
Fixes: 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb
- http://autobuild.buildroot.org/results/c0aac8bed08850e07cb94f501d754c3c64cdfe07
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/openssh/Config.in | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/openssh/Config.in b/package/openssh/Config.in
index a3038ba01f..c108569547 100644
--- a/package/openssh/Config.in
+++ b/package/openssh/Config.in
@@ -1,7 +1,10 @@
config BR2_PACKAGE_OPENSSH
bool "openssh"
depends on BR2_USE_MMU # fork()
- select BR2_PACKAGE_LINUX_PAM if BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION
+ select BR2_PACKAGE_LINUX_PAM if \
+ BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION && \
+ BR2_ENABLE_LOCALE && BR2_USE_WCHAR && \
+ !BR2_STATIC_LIBS && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
select BR2_PACKAGE_OPENSSL
select BR2_PACKAGE_ZLIB
help
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/openssh: fix linux-pam select
2024-02-24 21:30 [Buildroot] [PATCH 1/1] package/openssh: fix linux-pam select Fabrice Fontaine
@ 2024-02-25 8:02 ` Peter Korsgaard
2024-02-25 9:04 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2024-02-25 8:02 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Adam Duskett, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Commit 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb forgot to handle
> linux-pam dependencies resulting in the following build failure:
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM
> Depends on [n]: BR2_ENABLE_LOCALE [=n] && BR2_USE_WCHAR [=n] && !BR2_STATIC_LIBS [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=y]
> Selected by [y]:
> - BR2_PACKAGE_OPENSSH [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION [=y]
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM
> Depends on [n]: BR2_ENABLE_LOCALE [=n] && BR2_USE_WCHAR [=n] && !BR2_STATIC_LIBS [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=y]
> Selected by [y]:
> - BR2_PACKAGE_OPENSSH [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION [=y]
> [...]
> configure: error: in `/home/autobuild/autobuild/instance-12/output-1/build/linux-pam-1.6.0':
> configure: error: failed to find dlopen
> Fixes: 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb
> - http://autobuild.buildroot.org/results/c0aac8bed08850e07cb94f501d754c3c64cdfe07
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/openssh/Config.in | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/package/openssh/Config.in b/package/openssh/Config.in
> index a3038ba01f..c108569547 100644
> --- a/package/openssh/Config.in
> +++ b/package/openssh/Config.in
> @@ -1,7 +1,10 @@
> config BR2_PACKAGE_OPENSSH
> bool "openssh"
> depends on BR2_USE_MMU # fork()
> - select BR2_PACKAGE_LINUX_PAM if BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION
> + select BR2_PACKAGE_LINUX_PAM if \
> + BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION && \
> + BR2_ENABLE_LOCALE && BR2_USE_WCHAR && \
> + !BR2_STATIC_LIBS && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
This stops kconfig from complaining, but does a openssh + refpolicy build
without (E.G. ) locale support then actually work? Judging from:
commit 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb
Author: Adam Duskett <adam.duskett@amarulasolutions.com>
Date: Mon Oct 9 16:34:40 2023 +0200
package/openssh: select linux-pam if refpolicy upstream is selected
linux-pam is required to login via OpenSSH if the upstream refpolicy for
SELinux is enaabled, as linux-pam handles changing user contexts. If a
user wants to make their own policy and use a refpolicy via git, we of course
should let them do so. As such, only select linux-pam if the upstream version
of refpolicy is selected.
I am not sure what the proper solution is for situations where pam is
not available? Adam?
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/openssh: fix linux-pam select
2024-02-25 8:02 ` Peter Korsgaard
@ 2024-02-25 9:04 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-02-25 9:04 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Adam Duskett, Fabrice Fontaine, buildroot
Peter, Fabrice, All,
On 2024-02-25 09:02 +0100, Peter Korsgaard spake thusly:
> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> > Commit 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb forgot to handle
> > linux-pam dependencies resulting in the following build failure:
[--SNIP--]
> This stops kconfig from complaining, but does a openssh + refpolicy build
> without (E.G. ) locale support then actually work? Judging from:
> commit 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb
[--SNIP--]
> I am not sure what the proper solution is for situations where pam is
> not available? Adam?
I already sent a fix for this a while back, and we discussed it with
Thomas back at the last dev-days, summarised there:
https://lore.kernel.org/buildroot/20240207122726.2aa4be3c@windsurf/
I'll need to send that new iteration soon...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-25 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-24 21:30 [Buildroot] [PATCH 1/1] package/openssh: fix linux-pam select Fabrice Fontaine
2024-02-25 8:02 ` Peter Korsgaard
2024-02-25 9:04 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox