Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit branch/next] Makefile: use /etc/os-release for version info rather than /etc/br-version
@ 2012-02-14 12:08 Peter Korsgaard
  2012-02-14 16:07 ` Luca Ceresoli
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2012-02-14 12:08 UTC (permalink / raw)
  To: buildroot

commit: http://git.buildroot.net/buildroot/commit/?id=451a887894faddef019e9a0628c21b5f2e9eee56
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/next

/etc/os-release is becoming a standard interface for distribution
name/version info, so let's use that instead of the nonstandard
/etc/br-version. Format of the file is something like:

NAME=Buildroot
VERSION=2012.02-rc1-00003-g2d10e81
ID=buildroot
VERSION_ID=2012.02-rc1
PRETTY_NAME="Buildroot 2012.02-rc1"

For more details, see:

http://0pointer.de/public/systemd-man/os-release.html

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 7d8dd2e..8a8b676 100644
--- a/Makefile
+++ b/Makefile
@@ -477,7 +477,13 @@ endif
 	else \
 		/sbin/ldconfig -r $(TARGET_DIR); \
 	fi
-	echo $(BR2_VERSION_FULL) > $(TARGET_DIR)/etc/br-version
+	( \
+		echo "NAME=Buildroot"; \
+		echo "VERSION=$(BR2_VERSION_FULL)"; \
+		echo "ID=buildroot"; \
+		echo "VERSION_ID=$(BR2_VERSION)"; \
+		echo "PRETTY_NAME=\"Buildroot $(BR2_VERSION)\"" \
+	) >  $(TARGET_DIR)/etc/os-release
 
 ifneq ($(BR2_ROOTFS_POST_BUILD_SCRIPT),"")
 	$(BR2_ROOTFS_POST_BUILD_SCRIPT) $(TARGET_DIR)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit branch/next] Makefile: use /etc/os-release for version info rather than /etc/br-version
  2012-02-14 12:08 [Buildroot] [git commit branch/next] Makefile: use /etc/os-release for version info rather than /etc/br-version Peter Korsgaard
@ 2012-02-14 16:07 ` Luca Ceresoli
  2012-02-14 16:18   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Ceresoli @ 2012-02-14 16:07 UTC (permalink / raw)
  To: buildroot

Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=451a887894faddef019e9a0628c21b5f2e9eee56
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/next
>
> /etc/os-release is becoming a standard interface for distribution
> name/version info, so let's use that instead of the nonstandard
> /etc/br-version. Format of the file is something like:
>
> NAME=Buildroot
> VERSION=2012.02-rc1-00003-g2d10e81
> ID=buildroot
> VERSION_ID=2012.02-rc1
> PRETTY_NAME="Buildroot 2012.02-rc1"

Nice.
I just wish PRETTY_NAME had at least a "-dirty" suffix to make it
clear that it is not exactly equal to 2012.02-rc1 (at least when using
a git clone).

Luca

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit branch/next] Makefile: use /etc/os-release for version info rather than /etc/br-version
  2012-02-14 16:07 ` Luca Ceresoli
@ 2012-02-14 16:18   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2012-02-14 16:18 UTC (permalink / raw)
  To: buildroot

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

Hi,

 >> NAME=Buildroot
 >> VERSION=2012.02-rc1-00003-g2d10e81
 >> ID=buildroot
 >> VERSION_ID=2012.02-rc1
 >> PRETTY_NAME="Buildroot 2012.02-rc1"

 Luca> Nice.
 Luca> I just wish PRETTY_NAME had at least a "-dirty" suffix to make it
 Luca> clear that it is not exactly equal to 2012.02-rc1 (at least when using
 Luca> a git clone).

We can make it use BR2_VERSION_FULL, but I didn't find that particulary
"pretty". I normally change the version string to <versionN+1>-git right
after a release, so it's only between -rc1 and the final release that
there can be a bit of confusion (and you always have VERSION to figure
it out).

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-14 16:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-14 12:08 [Buildroot] [git commit branch/next] Makefile: use /etc/os-release for version info rather than /etc/br-version Peter Korsgaard
2012-02-14 16:07 ` Luca Ceresoli
2012-02-14 16:18   ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox