[Buildroot] [PATCH] libarchive package added

[Buildroot] [PATCH] libarchive package added

[Daniel Mack]

See http://code.google.com/p/libarchive/

Signed-off-by: Daniel Mack <daniel@caiaq.de>
---
 package/Config.in                |    1 +
 package/libarchive/Config.in     |   15 +++++++++++++++
 package/libarchive/libarchive.mk |   19 +++++++++++++++++++
 3 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 package/libarchive/Config.in
 create mode 100644 package/libarchive/libarchive.mk

diff --git a/package/Config.in b/package/Config.in
index 02ffb2d..a53e09a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -386,6 +386,7 @@ menu "Compressors / decompressors"
 if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 source "package/gzip/Config.in"
 endif
+source "package/libarchive/Config.in"
 source "package/lzo/Config.in"
 source "package/lzop/Config.in"
 source "package/lzma/Config.in"
diff --git a/package/libarchive/Config.in b/package/libarchive/Config.in
new file mode 100644
index 0000000..93bfec2
--- /dev/null
+++ b/package/libarchive/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_LIBARCHIVE
+	bool "libarchive"
+	help
+	  Libarchive is a reusable C library for reading and writing a
+	  variety of streaming archive formats.
+
+	  http://code.google.com/p/libarchive/
+
+config BR2_LIBARCHIVE_INSTALL_TO_TARGET
+	bool "install libarchive to target"
+	depends on BR2_PACKAGE_LIBARCHIVE
+	default y
+	help
+	  Say Y here to make BR2 copy the libarchive files to the target
+	  destination folder.
diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
new file mode 100644
index 0000000..e3f019b
--- /dev/null
+++ b/package/libarchive/libarchive.mk
@@ -0,0 +1,19 @@
+#############################################################
+#
+# libarchive (reusable C library for archive formats)
+#
+#############################################################
+LIBARCHIVE_VERSION:=2.7.1
+LIBARCHIVE_SITE = http://libarchive.googlecode.com/files/
+LIBARCHIVE_SOURCE = libarchive-$(LIBARCHIVE_VERSION).tar.gz
+LIBARCHIVE_LIBTOOL_PATCH = NO
+LIBARCHIVE_INSTALL_STAGING = YES
+
+ifeq ($(BR2_LIBARCHIVE_INSTALL_TO_TARGET),y)
+	LIBARCHIVE_INSTALL_TARGET := YES
+endif
+
+LIBARCHIVE_DEPENDENCIES = uclibc
+
+$(eval $(call AUTOTARGETS,package,libarchive))
+
-- 
1.6.3.3

[Buildroot] [PATCH] libarchive package added

[Daniel Mack]

ping

On Tue, Aug 25, 2009 at 04:04:56PM +0200, Daniel Mack wrote:
> See http://code.google.com/p/libarchive/
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> ---
>  package/Config.in                |    1 +
>  package/libarchive/Config.in     |   15 +++++++++++++++
>  package/libarchive/libarchive.mk |   19 +++++++++++++++++++
>  3 files changed, 35 insertions(+), 0 deletions(-)
>  create mode 100644 package/libarchive/Config.in
>  create mode 100644 package/libarchive/libarchive.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 02ffb2d..a53e09a 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -386,6 +386,7 @@ menu "Compressors / decompressors"
>  if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
>  source "package/gzip/Config.in"
>  endif
> +source "package/libarchive/Config.in"
>  source "package/lzo/Config.in"
>  source "package/lzop/Config.in"
>  source "package/lzma/Config.in"
> diff --git a/package/libarchive/Config.in b/package/libarchive/Config.in
> new file mode 100644
> index 0000000..93bfec2
> --- /dev/null
> +++ b/package/libarchive/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_LIBARCHIVE
> +	bool "libarchive"
> +	help
> +	  Libarchive is a reusable C library for reading and writing a
> +	  variety of streaming archive formats.
> +
> +	  http://code.google.com/p/libarchive/
> +
> +config BR2_LIBARCHIVE_INSTALL_TO_TARGET
> +	bool "install libarchive to target"
> +	depends on BR2_PACKAGE_LIBARCHIVE
> +	default y
> +	help
> +	  Say Y here to make BR2 copy the libarchive files to the target
> +	  destination folder.
> diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
> new file mode 100644
> index 0000000..e3f019b
> --- /dev/null
> +++ b/package/libarchive/libarchive.mk
> @@ -0,0 +1,19 @@
> +#############################################################
> +#
> +# libarchive (reusable C library for archive formats)
> +#
> +#############################################################
> +LIBARCHIVE_VERSION:=2.7.1
> +LIBARCHIVE_SITE = http://libarchive.googlecode.com/files/
> +LIBARCHIVE_SOURCE = libarchive-$(LIBARCHIVE_VERSION).tar.gz
> +LIBARCHIVE_LIBTOOL_PATCH = NO
> +LIBARCHIVE_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_LIBARCHIVE_INSTALL_TO_TARGET),y)
> +	LIBARCHIVE_INSTALL_TARGET := YES
> +endif
> +
> +LIBARCHIVE_DEPENDENCIES = uclibc
> +
> +$(eval $(call AUTOTARGETS,package,libarchive))
> +
> -- 
> 1.6.3.3
> 

[Buildroot] [PATCH] libarchive package added

[Peter Korsgaard]

>>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:

Hi,

 Daniel> +++ b/package/libarchive/Config.in
 Daniel> @@ -0,0 +1,15 @@
 Daniel> +config BR2_PACKAGE_LIBARCHIVE
 Daniel> +	bool "libarchive"
 Daniel> +	help
 Daniel> +	  Libarchive is a reusable C library for reading and writing a
 Daniel> +	  variety of streaming archive formats.
 Daniel> +
 Daniel> +	  http://code.google.com/p/libarchive/
 Daniel> +
 Daniel> +config BR2_LIBARCHIVE_INSTALL_TO_TARGET
 Daniel> +	bool "install libarchive to target"
 Daniel> +	depends on BR2_PACKAGE_LIBARCHIVE
 Daniel> +	default y
 Daniel> +	help
 Daniel> +	  Say Y here to make BR2 copy the libarchive files to the target
 Daniel> +	  destination folder.

When would you not want to do this?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] libarchive package added

[Daniel Mack]

On Tue, Sep 01, 2009 at 04:52:49PM +0200, Peter Korsgaard wrote:
> Date: Tue, 01 Sep 2009 16:52:49 +0200
> From: Peter Korsgaard <jacmet@uclibc.org>
> To: Daniel Mack <daniel@caiaq.de>
> Cc: buildroot at uclibc.org
> Subject: Re: [Buildroot] [PATCH] libarchive package added
> Message-ID: <87skf6pvi6.fsf@macbook.be.48ers.dk>
> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)
> 
> >>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:
> 
> Hi,
> 
>  Daniel> +config BR2_LIBARCHIVE_INSTALL_TO_TARGET
>  Daniel> +	bool "install libarchive to target"
>  Daniel> +	depends on BR2_PACKAGE_LIBARCHIVE
>  Daniel> +	default y
>  Daniel> +	help
>  Daniel> +	  Say Y here to make BR2 copy the libarchive files to the target
>  Daniel> +	  destination folder.
> 
> When would you not want to do this?

We need that library for a binary which is linked statically. Installing
it is not necessary in our case.

But as the default is 'y', this should not be a disadvantage for anyone.
We could, of course, also delete it manually at a later point.

Daniel

[Buildroot] [PATCH] libarchive package added

[Peter Korsgaard]

>>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:

Hi,

 >> When would you not want to do this?

 Daniel> We need that library for a binary which is linked
 Daniel> statically. Installing it is not necessary in our case.

 Daniel> But as the default is 'y', this should not be a disadvantage
 Daniel> for anyone.  We could, of course, also delete it manually at a
 Daniel> later point.

Ok, we don't normally do this per-package - So I'm hessitant to add it
here. Other than that, it looks fine.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] libarchive package added

[Daniel Mack]

On Tue, Sep 01, 2009 at 05:16:29PM +0200, Peter Korsgaard wrote:
>  Daniel> We need that library for a binary which is linked
>  Daniel> statically. Installing it is not necessary in our case.
> 
>  Daniel> But as the default is 'y', this should not be a disadvantage
>  Daniel> for anyone.  We could, of course, also delete it manually at a
>  Daniel> later point.
> 
> Ok, we don't normally do this per-package - So I'm hessitant to add it
> here. Other than that, it looks fine.

Hmm, maybe that should be an option to more packages then, and it could
be added on demand, eg. whenever someone needs that.

But I understand that you're hessitant, so drop that part if you like,
and we remove the installed files later from our postbuild script. No
problem :)

Daniel

[Buildroot] [PATCH] libarchive package added

[Peter Korsgaard]

>>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:

Hi,

 >> Ok, we don't normally do this per-package - So I'm hessitant to add
 >> it here. Other than that, it looks fine.

 Daniel> Hmm, maybe that should be an option to more packages then, and
 Daniel> it could be added on demand, eg. whenever someone needs that.

I think adding so many configuration options for something like that
will just confuse people / complicate testing too much. Using
BR2_ROOTFS_POST_BUILD_SCRIPT for this seems like a nicer (and more
flexible) solution to me.

 Daniel> But I understand that you're hessitant, so drop that part if you like,
 Daniel> and we remove the installed files later from our postbuild script. No
 Daniel> problem :)

Ok, added without that part. Notice that libarchive needs wchar support:

libarchive/archive_entry.c: In function 'aes_get_wcs':
libarchive/archive_entry.c:234: error: implicit declaration of function 'mbstowcs'

I've fixed the kconfig to ensure that.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] libarchive package added

[Daniel Mack]

On Wed, Sep 02, 2009 at 10:02:12AM +0200, Peter Korsgaard wrote:
>  Daniel> But I understand that you're hessitant, so drop that part if you like,
>  Daniel> and we remove the installed files later from our postbuild script. No
>  Daniel> problem :)
> 
> Ok, added without that part. Notice that libarchive needs wchar support:
> 
> libarchive/archive_entry.c: In function 'aes_get_wcs':
> libarchive/archive_entry.c:234: error: implicit declaration of function 'mbstowcs'
> 
> I've fixed the kconfig to ensure that.

Thanks :)