* [Buildroot] [git commit] Fix memstat's install
@ 2009-07-21 10:47 Bernhard Reutner-Fischer
2009-07-21 20:05 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Bernhard Reutner-Fischer @ 2009-07-21 10:47 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=9e2bdce02c45edbb65bffb9a31a423de9ccbff3f
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---
package/memstat/memstat.mk | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/package/memstat/memstat.mk b/package/memstat/memstat.mk
index 7220aee..a54509a 100644
--- a/package/memstat/memstat.mk
+++ b/package/memstat/memstat.mk
@@ -21,15 +21,17 @@ $(MEMSTAT_DIR)/.configured: $(MEMSTAT_DIR)/.unpacked
touch $@
$(MEMSTAT_DIR)/memstat: $(MEMSTAT_DIR)/.configured
- $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) $(@D)/memstat.c -o $@
+ $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
+ $(CFLAGS_WHOLE_PROGRAM) $(@D)/memstat.c -o $@
$(TARGET_DIR)/usr/bin/memstat: $(MEMSTAT_DIR)/memstat
[ -e $(TARGET_DIR)/etc/memstat.conf ] || \
- $(INSTALL) -m 0644 -D $(^D)/memstat.conf $(TARGET_DIR)/etc
+ $(INSTALL) -m 0644 -D $(^D)/memstat.conf \
+ $(TARGET_DIR)/etc/memstat.conf
$(INSTALL) -m 0755 -D $^ $@
$(STRIPCMD) $(STRIP_STRIP_ALL) $@
-memstat: uclibc $(TARGET_DIR)/usr/bin/memstat
+memstat: $(TARGET_DIR)/usr/bin/memstat
memstat-source: $(DL_DIR)/$(MEMSTAT_SOURCE)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Fix memstat's install
2009-07-21 10:47 [Buildroot] [git commit] Fix memstat's install Bernhard Reutner-Fischer
@ 2009-07-21 20:05 ` Peter Korsgaard
2009-07-21 22:03 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2009-07-21 20:05 UTC (permalink / raw)
To: buildroot
>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
Hi,
A bit more detailed changelog would be good.
Bernhard> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Bernhard> ---
Bernhard> package/memstat/memstat.mk | 8 +++++---
Bernhard> 1 files changed, 5 insertions(+), 3 deletions(-)
Bernhard> diff --git a/package/memstat/memstat.mk b/package/memstat/memstat.mk
Bernhard> index 7220aee..a54509a 100644
Bernhard> --- a/package/memstat/memstat.mk
Bernhard> +++ b/package/memstat/memstat.mk
Bernhard> @@ -21,15 +21,17 @@ $(MEMSTAT_DIR)/.configured: $(MEMSTAT_DIR)/.unpacked
Bernhard> touch $@
Bernhard> $(MEMSTAT_DIR)/memstat: $(MEMSTAT_DIR)/.configured
Bernhard> - $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) $(@D)/memstat.c -o $@
Bernhard> + $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
Bernhard> + $(CFLAGS_WHOLE_PROGRAM) $(@D)/memstat.c -o $@
What is this WHOLE_PROGRAM thing?
Bernhard> $(TARGET_DIR)/usr/bin/memstat: $(MEMSTAT_DIR)/memstat
Bernhard> [ -e $(TARGET_DIR)/etc/memstat.conf ] || \
Bernhard> - $(INSTALL) -m 0644 -D $(^D)/memstat.conf $(TARGET_DIR)/etc
Bernhard> + $(INSTALL) -m 0644 -D $(^D)/memstat.conf \
Bernhard> + $(TARGET_DIR)/etc/memstat.conf
Bernhard> $(INSTALL) -m 0755 -D $^ $@
Bernhard> $(STRIPCMD) $(STRIP_STRIP_ALL) $@
Bernhard> -memstat: uclibc $(TARGET_DIR)/usr/bin/memstat
Bernhard> +memstat: $(TARGET_DIR)/usr/bin/memstat
And why this unrelated change?
Please post patches to the list before committing, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Fix memstat's install
2009-07-21 20:05 ` Peter Korsgaard
@ 2009-07-21 22:03 ` Bernhard Reutner-Fischer
2009-07-22 6:01 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Bernhard Reutner-Fischer @ 2009-07-21 22:03 UTC (permalink / raw)
To: buildroot
On Tue, Jul 21, 2009 at 10:05:15PM +0200, Peter Korsgaard wrote:
>>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
>
>Hi,
>
>A bit more detailed changelog would be good.
Well, it does just that: Fix memstat's install stage (aka PR473) :)
> Bernhard> $(MEMSTAT_DIR)/memstat: $(MEMSTAT_DIR)/.configured
> Bernhard> - $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) $(@D)/memstat.c -o $@
> Bernhard> + $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
> Bernhard> + $(CFLAGS_WHOLE_PROGRAM) $(@D)/memstat.c -o $@
>
>What is this WHOLE_PROGRAM thing?
gcc --help=optimizers | grep whole-program
>
> Bernhard> $(TARGET_DIR)/usr/bin/memstat: $(MEMSTAT_DIR)/memstat
> Bernhard> [ -e $(TARGET_DIR)/etc/memstat.conf ] || \
> Bernhard> - $(INSTALL) -m 0644 -D $(^D)/memstat.conf $(TARGET_DIR)/etc
> Bernhard> + $(INSTALL) -m 0644 -D $(^D)/memstat.conf \
> Bernhard> + $(TARGET_DIR)/etc/memstat.conf
> Bernhard> $(INSTALL) -m 0755 -D $^ $@
> Bernhard> $(STRIPCMD) $(STRIP_STRIP_ALL) $@
>
> Bernhard> -memstat: uclibc $(TARGET_DIR)/usr/bin/memstat
> Bernhard> +memstat: $(TARGET_DIR)/usr/bin/memstat
>
>And why this unrelated change?
trivial cleanup while at it.
>
>Please post patches to the list before committing, thanks.
I accidentally committed it to the wrong repo, my apologies.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Fix memstat's install
2009-07-21 22:03 ` Bernhard Reutner-Fischer
@ 2009-07-22 6:01 ` Peter Korsgaard
2009-07-22 7:46 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2009-07-22 6:01 UTC (permalink / raw)
To: buildroot
>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
Hi,
Bernhard> On Tue, Jul 21, 2009 at 10:05:15PM +0200, Peter Korsgaard wrote:
>> A bit more detailed changelog would be good.
Bernhard> Well, it does just that: Fix memstat's install stage (aka PR473) :)
For ancient versions of install. I would have preferred a commit
message like:
memstat: workaround issue with older versions of 'install'
Closes #473
Older versions of GNU install have issues with install -D <file>
<dir>/, but works with install -D <file> <dir>/<file>, so use that
instead.
And a corresponding addition to CHANGES
Bernhard> $(MEMSTAT_DIR)/memstat: $(MEMSTAT_DIR)/.configured
Bernhard> - $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) $(@D)/memstat.c -o $@
Bernhard> + $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
Bernhard> + $(CFLAGS_WHOLE_PROGRAM) $(@D)/memstat.c -o $@
>>
>> What is this WHOLE_PROGRAM thing?
Bernhard> gcc --help=optimizers | grep whole-program
Yes, I know the -fwhole-program option, but why is this just not
included in TARGET_CFLAGS?
>> Please post patches to the list before committing, thanks.
Bernhard> I accidentally committed it to the wrong repo, my apologies.
Ahh, ok - May I suggest you clone the official repo with git://
instead of ssh:// to not do that mistake in the future?
Thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Fix memstat's install
2009-07-22 6:01 ` Peter Korsgaard
@ 2009-07-22 7:46 ` Bernhard Reutner-Fischer
0 siblings, 0 replies; 5+ messages in thread
From: Bernhard Reutner-Fischer @ 2009-07-22 7:46 UTC (permalink / raw)
To: buildroot
On Wed, Jul 22, 2009 at 08:01:12AM +0200, Peter Korsgaard wrote:
>>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
>Yes, I know the -fwhole-program option, but why is this just not
>included in TARGET_CFLAGS?
because you have to add special handling for them anyway (see e.g. microcom).
It is likely that LTO will make most if not all of this unnecessary anyway.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-07-22 7:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-21 10:47 [Buildroot] [git commit] Fix memstat's install Bernhard Reutner-Fischer
2009-07-21 20:05 ` Peter Korsgaard
2009-07-21 22:03 ` Bernhard Reutner-Fischer
2009-07-22 6:01 ` Peter Korsgaard
2009-07-22 7:46 ` Bernhard Reutner-Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox