[Buildroot] [PATCH 0/4] Update Mesa and enable vkmark

[Buildroot] [PATCH 0/4] Update Mesa and enable vkmark

[Alex Bennée]

This is part of building test images for virtio-vulkan support in
QEMU. We need to update Mesa, enable the VirtIO driver and add the
vkmark tool. There is also a small patch to ensure we enable a getty
on the console so we can start weston and spawn the vkmark binary.
Currently it is not able to run directly with the DRM device.

Alex Bennée (4):
  package/mesa3d: add option to enable VIRTIO vulkan driver
  package/vkmark: add vmkark benchmarking tool
  board/qemu: add post-build script to aarch64_virt_defconfig
  package/mesa3d: bump to 24.2.0

 board/qemu/post-build.sh                 | 16 ++++++++++
 configs/qemu_aarch64_virt_defconfig      |  1 +
 package/Config.in                        |  1 +
 package/mesa3d-headers/mesa3d-headers.mk |  2 +-
 package/mesa3d/Config.in                 |  6 ++++
 package/mesa3d/mesa3d.hash               |  5 ++-
 package/mesa3d/mesa3d.mk                 |  4 ++-
 package/vkmark/Config.in                 | 39 ++++++++++++++++++++++++
 package/vkmark/vkmark.hash               |  3 ++
 package/vkmark/vkmark.mk                 | 28 +++++++++++++++++
 10 files changed, 100 insertions(+), 5 deletions(-)
 create mode 100755 board/qemu/post-build.sh
 create mode 100644 package/vkmark/Config.in
 create mode 100644 package/vkmark/vkmark.hash
 create mode 100644 package/vkmark/vkmark.mk

-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/4] package/mesa3d: add option to enable VIRTIO vulkan driver

[Alex Bennée]

The support for Venus in MESA has been stable since 23.2 so add an
option to enable it.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 package/mesa3d/Config.in | 6 ++++++
 package/mesa3d/mesa3d.mk | 1 +
 2 files changed, 7 insertions(+)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 7761b0a650..0e08b0e7c5 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -314,6 +314,12 @@ config BR2_PACKAGE_MESA3D_VULKAN_DRIVER_SWRAST
 	help
 	  Vulkan swrast driver.
 
+config BR2_PACKAGE_MESA3D_VULKAN_DRIVER_VIRTIO
+	bool "Vulkan VirtIO driver (Venus)"
+	select BR2_PACKAGE_MESA3D_VULKAN_DRIVER
+	help
+	  Vulkan VirtIO (venus) driver.
+
 comment "Off-screen Rendering"
 
 config BR2_PACKAGE_MESA3D_OSMESA_GALLIUM
diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index ce460c4475..d3b5010648 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -114,6 +114,7 @@ MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VIRGL)    += virgl
 MESA3D_VULKAN_DRIVERS-$(BR2_PACKAGE_MESA3D_VULKAN_DRIVER_BROADCOM) += broadcom
 MESA3D_VULKAN_DRIVERS-$(BR2_PACKAGE_MESA3D_VULKAN_DRIVER_INTEL)   += intel
 MESA3D_VULKAN_DRIVERS-$(BR2_PACKAGE_MESA3D_VULKAN_DRIVER_SWRAST) += swrast
+MESA3D_VULKAN_DRIVERS-$(BR2_PACKAGE_MESA3D_VULKAN_DRIVER_VIRTIO) += virtio
 
 ifeq ($(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER),)
 MESA3D_CONF_OPTS += \
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/4] package/vkmark: add vmkark benchmarking tool

[Alex Bennée]

We build from the current master as we need fairly upto date bits for
cross compile support.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 package/Config.in          |  1 +
 package/vkmark/Config.in   | 39 ++++++++++++++++++++++++++++++++++++++
 package/vkmark/vkmark.hash |  3 +++
 package/vkmark/vkmark.mk   | 28 +++++++++++++++++++++++++++
 4 files changed, 71 insertions(+)
 create mode 100644 package/vkmark/Config.in
 create mode 100644 package/vkmark/vkmark.hash
 create mode 100644 package/vkmark/vkmark.mk

diff --git a/package/Config.in b/package/Config.in
index f2c63ffb6e..dd16dc8556 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -324,6 +324,7 @@ comment "Graphic applications"
 	source "package/fswebcam/Config.in"
 	source "package/ghostscript/Config.in"
 	source "package/glmark2/Config.in"
+	source "package/vkmark/Config.in"
 	source "package/glslsandbox-player/Config.in"
 	source "package/gnuplot/Config.in"
 	source "package/igt-gpu-tools/Config.in"
diff --git a/package/vkmark/Config.in b/package/vkmark/Config.in
new file mode 100644
index 0000000000..15d8e380ed
--- /dev/null
+++ b/package/vkmark/Config.in
@@ -0,0 +1,39 @@
+config BR2_PACKAGE_VKMARK_FLAVOR_ANY
+	bool
+
+config BR2_PACKAGE_VKMARK_FLAVOR_KMS
+	bool
+	default y
+	depends on BR2_PACKAGE_HAS_LIBGBM
+	select BR2_PACKAGE_LIBDRM
+        select BR2_PACKAGE_VKMARK_FLAVOR_ANY
+
+config BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND
+	bool
+	default n
+	select BR2_PACKAGE_VKMARK_FLAVOR_ANY
+
+config BR2_PACKAGE_VKMARK_FLAVOR_X11
+	bool
+	default n
+	select BR2_PACKAGE_LIBXCB
+        select BR2_PACKAGE_VKMARK_FLAVOR_ANY
+
+config BR2_PACKAGE_VKMARK
+	bool "vkmark"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
+	depends on BR2_PACKAGE_VKMARK_FLAVOR_ANY
+	select BR2_PACKAGE_VULKAN_HEADERS
+	select BR2_PACKAGE_VULKAN_LOADER
+	select BR2_PACKAGE_GLM
+	select BR2_PACKAGE_ASSIMP
+	select BR2_PACKAGE_WAYLAND_PROTOCOLS if BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND
+	help
+	  vmmark is an Vulkan GPU benchmark.
+
+	  https://github.com/vkmark/vkmark
+
+comment "vkmark needs a toolchain w/ C++, dynamic library, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/vkmark/vkmark.hash b/package/vkmark/vkmark.hash
new file mode 100644
index 0000000000..494d0c4808
--- /dev/null
+++ b/package/vkmark/vkmark.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  9f106a67ce1e2aa4140bbf9325cc5837157d64f945534bc9e57286d690b08346  vkmark-2017.08.tar.gz
+sha256  d08143e8828d5b9ed005cb6dcef4d88a49df0ac4c9e1356ace739b449c165f54  vkmark-ab6e6f34077722d5ae33f6bd40b18ef9c0e99a15.tar.gz
diff --git a/package/vkmark/vkmark.mk b/package/vkmark/vkmark.mk
new file mode 100644
index 0000000000..19d796a9b0
--- /dev/null
+++ b/package/vkmark/vkmark.mk
@@ -0,0 +1,28 @@
+################################################################################
+#
+# vkmark
+#
+################################################################################
+
+VKMARK_VERSION = ab6e6f34077722d5ae33f6bd40b18ef9c0e99a15
+VKMARK_SITE = $(call github,vkmark,vkmark,$(VKMARK_VERSION))
+VKMARK_LICENSE = LGPL-2.1
+VKMARK_LICENSE_FILES = COPYING-LGPL2.1
+VKMARK_DEPENDENCIES = host-pkgconf vulkan-headers vulkan-loader glm
+
+ifeq ($(BR2_PACKAGE_VKMARK_FLAVOR_KMS),y)
+VKMARK_DEPENDENCIES += libdrm libgbm
+VKMARK_CONF_OPTS += -Dkms=true
+endif
+
+ifeq ($(BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND),y)
+VKMARK_DEPENDENCIES += wayland wayland-protocols
+VKMARK_CONF_OPTS += -Dwayland=true
+endif
+
+ifeq ($(BR2_PACKAGE_VKMARK_FLAVOR_X11),y)
+VKMARK_DEPENDENCIES += libxcb
+VKMARK_CONF_OPTS += -Dxcb=true
+endif
+
+$(eval $(meson-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/4] board/qemu: add post-build script to aarch64_virt_defconfig

[Alex Bennée]

This is in aid of supporting getty on fbcon.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 board/qemu/post-build.sh            | 16 ++++++++++++++++
 configs/qemu_aarch64_virt_defconfig |  1 +
 2 files changed, 17 insertions(+)
 create mode 100755 board/qemu/post-build.sh

diff --git a/board/qemu/post-build.sh b/board/qemu/post-build.sh
new file mode 100755
index 0000000000..73026e5922
--- /dev/null
+++ b/board/qemu/post-build.sh
@@ -0,0 +1,16 @@
+#!/bin/sh
+
+set -u
+set -e
+
+# Add a console on tty1
+if [ -e ${TARGET_DIR}/etc/inittab ]; then
+    grep -qE '^tty1::' ${TARGET_DIR}/etc/inittab || \
+	sed -i '/GENERIC_SERIAL/a\
+tty1::respawn:/sbin/getty -L  tty1 0 vt100 # HDMI console' ${TARGET_DIR}/etc/inittab
+# systemd doesn't use /etc/inittab, enable getty.tty1.service instead
+elif [ -d ${TARGET_DIR}/etc/systemd ]; then
+    mkdir -p "${TARGET_DIR}/etc/systemd/system/getty.target.wants"
+    ln -sf /lib/systemd/system/getty@.service \
+       "${TARGET_DIR}/etc/systemd/system/getty.target.wants/getty@tty1.service"
+fi
diff --git a/configs/qemu_aarch64_virt_defconfig b/configs/qemu_aarch64_virt_defconfig
index 30ecf04cac..45f7fc75eb 100644
--- a/configs/qemu_aarch64_virt_defconfig
+++ b/configs/qemu_aarch64_virt_defconfig
@@ -15,6 +15,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
 # Image
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/qemu/post-build.sh"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh"
 BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG)"
 
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

[Alex Bennée]

While VirtIO Venus support went in earlier this is the first version
that is known to work well.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 package/mesa3d-headers/mesa3d-headers.mk | 2 +-
 package/mesa3d/mesa3d.hash               | 5 ++---
 package/mesa3d/mesa3d.mk                 | 3 ++-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/package/mesa3d-headers/mesa3d-headers.mk b/package/mesa3d-headers/mesa3d-headers.mk
index 33c60b285f..98afb77a9c 100644
--- a/package/mesa3d-headers/mesa3d-headers.mk
+++ b/package/mesa3d-headers/mesa3d-headers.mk
@@ -12,7 +12,7 @@ endif
 
 # Not possible to directly refer to mesa3d variables, because of
 # first/second expansion trickery...
-MESA3D_HEADERS_VERSION = 24.0.9
+MESA3D_HEADERS_VERSION = 24.2.0
 MESA3D_HEADERS_SOURCE = mesa-$(MESA3D_HEADERS_VERSION).tar.xz
 MESA3D_HEADERS_SITE = https://archive.mesa3d.org
 MESA3D_HEADERS_DL_SUBDIR = mesa3d
diff --git a/package/mesa3d/mesa3d.hash b/package/mesa3d/mesa3d.hash
index d506d398b8..1ff11f9bd8 100644
--- a/package/mesa3d/mesa3d.hash
+++ b/package/mesa3d/mesa3d.hash
@@ -1,5 +1,4 @@
-# From https://lists.freedesktop.org/archives/mesa-announce/2024-June/000764.html
-sha256  51aa686ca4060e38711a9e8f60c8f1efaa516baf411946ed7f2c265cd582ca4c  mesa-24.0.9.tar.xz
-sha512  de2ee6c9df1fc106ee10befe0a76be1e9cfe83d65dbdb83bad6d8d7cfaa085232fb115293a1a790b37b50b1fe14bd58aafbcfe5a15e953b5901a7105d57569a5  mesa-24.0.9.tar.xz
+# From https://docs.mesa3d.org/relnotes/24.2.0.html
+sha256  c02bb72cea290f78b11895a0c95c7c92394f180d7ff66d4a762ec6950a58addf  mesa-24.2.0.tar.xz
 # License
 sha256  a00275a53178e2645fb65be99a785c110513446a5071ff2c698ed260ad917d75  docs/license.rst
diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index d3b5010648..29f26c5663 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 # When updating the version, please also update mesa3d-headers
-MESA3D_VERSION = 24.0.9
+MESA3D_VERSION = 24.2.0
 MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
 MESA3D_SITE = https://archive.mesa3d.org
 MESA3D_LICENSE = MIT, SGI, Khronos
@@ -21,6 +21,7 @@ MESA3D_DEPENDENCIES = \
 	host-bison \
 	host-flex \
 	host-python-mako \
+	host-python-pyyaml \
 	expat \
 	libdrm \
 	zlib
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

[Yann E. MORIN]

Alex, All,

On 2024-08-22 14:02 +0100, Alex Bennée spake thusly:
> While VirtIO Venus support went in earlier this is the first version
> that is known to work well.

This commit log is confusing: it talks about VirtIO Venus, but there is
no such addition in the patch. It however adds a dependency on
host-python-pyyaml, but that is not explained, and does not seem related
to VirtIO Venus either...

Could you clarify, please?

Also, see below...

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  package/mesa3d-headers/mesa3d-headers.mk | 2 +-
>  package/mesa3d/mesa3d.hash               | 5 ++---
>  package/mesa3d/mesa3d.mk                 | 3 ++-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/package/mesa3d-headers/mesa3d-headers.mk b/package/mesa3d-headers/mesa3d-headers.mk
> index 33c60b285f..98afb77a9c 100644
> --- a/package/mesa3d-headers/mesa3d-headers.mk
> +++ b/package/mesa3d-headers/mesa3d-headers.mk
> @@ -12,7 +12,7 @@ endif
>  
>  # Not possible to directly refer to mesa3d variables, because of
>  # first/second expansion trickery...
> -MESA3D_HEADERS_VERSION = 24.0.9
> +MESA3D_HEADERS_VERSION = 24.2.0
>  MESA3D_HEADERS_SOURCE = mesa-$(MESA3D_HEADERS_VERSION).tar.xz
>  MESA3D_HEADERS_SITE = https://archive.mesa3d.org
>  MESA3D_HEADERS_DL_SUBDIR = mesa3d
> diff --git a/package/mesa3d/mesa3d.hash b/package/mesa3d/mesa3d.hash
> index d506d398b8..1ff11f9bd8 100644
> --- a/package/mesa3d/mesa3d.hash
> +++ b/package/mesa3d/mesa3d.hash
> @@ -1,5 +1,4 @@
> -# From https://lists.freedesktop.org/archives/mesa-announce/2024-June/000764.html
> -sha256  51aa686ca4060e38711a9e8f60c8f1efaa516baf411946ed7f2c265cd582ca4c  mesa-24.0.9.tar.xz
> -sha512  de2ee6c9df1fc106ee10befe0a76be1e9cfe83d65dbdb83bad6d8d7cfaa085232fb115293a1a790b37b50b1fe14bd58aafbcfe5a15e953b5901a7105d57569a5  mesa-24.0.9.tar.xz
> +# From https://docs.mesa3d.org/relnotes/24.2.0.html
> +sha256  c02bb72cea290f78b11895a0c95c7c92394f180d7ff66d4a762ec6950a58addf  mesa-24.2.0.tar.xz

There previously was sha256 _and_ sha512 hashes, but now you only add a
sha256 one. Can you extend a little blurb about that, please?

Regards,
Yann E. MORIN.

>  # License
>  sha256  a00275a53178e2645fb65be99a785c110513446a5071ff2c698ed260ad917d75  docs/license.rst
> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> index d3b5010648..29f26c5663 100644
> --- a/package/mesa3d/mesa3d.mk
> +++ b/package/mesa3d/mesa3d.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  # When updating the version, please also update mesa3d-headers
> -MESA3D_VERSION = 24.0.9
> +MESA3D_VERSION = 24.2.0
>  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
>  MESA3D_SITE = https://archive.mesa3d.org
>  MESA3D_LICENSE = MIT, SGI, Khronos
> @@ -21,6 +21,7 @@ MESA3D_DEPENDENCIES = \
>  	host-bison \
>  	host-flex \
>  	host-python-mako \
> +	host-python-pyyaml \
>  	expat \
>  	libdrm \
>  	zlib
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

[Alex Bennée]

"Yann E. MORIN" <yann.morin.1998@free.fr> writes:

> Alex, All,
>
> On 2024-08-22 14:02 +0100, Alex Bennée spake thusly:
>> While VirtIO Venus support went in earlier this is the first version
>> that is known to work well.
>
> This commit log is confusing: it talks about VirtIO Venus, but there is
> no such addition in the patch.

Support for VirtIO venus was added in patch 1/4 but testing has shown it
needs at least 24.2.0 to work properly.

> It however adds a dependency on
> host-python-pyyaml, but that is not explained, and does not seem
> related

It was a dependency I needed to add to support the build.

> to VirtIO Venus either...
>
> Could you clarify, please?
>
> Also, see below...
>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  package/mesa3d-headers/mesa3d-headers.mk | 2 +-
>>  package/mesa3d/mesa3d.hash               | 5 ++---
>>  package/mesa3d/mesa3d.mk                 | 3 ++-
>>  3 files changed, 5 insertions(+), 5 deletions(-)
>> 
>> diff --git a/package/mesa3d-headers/mesa3d-headers.mk b/package/mesa3d-headers/mesa3d-headers.mk
>> index 33c60b285f..98afb77a9c 100644
>> --- a/package/mesa3d-headers/mesa3d-headers.mk
>> +++ b/package/mesa3d-headers/mesa3d-headers.mk
>> @@ -12,7 +12,7 @@ endif
>>  
>>  # Not possible to directly refer to mesa3d variables, because of
>>  # first/second expansion trickery...
>> -MESA3D_HEADERS_VERSION = 24.0.9
>> +MESA3D_HEADERS_VERSION = 24.2.0
>>  MESA3D_HEADERS_SOURCE = mesa-$(MESA3D_HEADERS_VERSION).tar.xz
>>  MESA3D_HEADERS_SITE = https://archive.mesa3d.org
>>  MESA3D_HEADERS_DL_SUBDIR = mesa3d
>> diff --git a/package/mesa3d/mesa3d.hash b/package/mesa3d/mesa3d.hash
>> index d506d398b8..1ff11f9bd8 100644
>> --- a/package/mesa3d/mesa3d.hash
>> +++ b/package/mesa3d/mesa3d.hash
>> @@ -1,5 +1,4 @@
>> -# From https://lists.freedesktop.org/archives/mesa-announce/2024-June/000764.html
>> -sha256  51aa686ca4060e38711a9e8f60c8f1efaa516baf411946ed7f2c265cd582ca4c  mesa-24.0.9.tar.xz
>> -sha512  de2ee6c9df1fc106ee10befe0a76be1e9cfe83d65dbdb83bad6d8d7cfaa085232fb115293a1a790b37b50b1fe14bd58aafbcfe5a15e953b5901a7105d57569a5  mesa-24.0.9.tar.xz
>> +# From https://docs.mesa3d.org/relnotes/24.2.0.html
>> +sha256  c02bb72cea290f78b11895a0c95c7c92394f180d7ff66d4a762ec6950a58addf  mesa-24.2.0.tar.xz
>
> There previously was sha256 _and_ sha512 hashes, but now you only add a
> sha256 one. Can you extend a little blurb about that, please?

Sure - only the sha256 was in the relase announcement. I could calculate
one if you want?

>
> Regards,
> Yann E. MORIN.
>
>>  # License
>>  sha256  a00275a53178e2645fb65be99a785c110513446a5071ff2c698ed260ad917d75  docs/license.rst
>> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
>> index d3b5010648..29f26c5663 100644
>> --- a/package/mesa3d/mesa3d.mk
>> +++ b/package/mesa3d/mesa3d.mk
>> @@ -5,7 +5,7 @@
>>  ################################################################################
>>  
>>  # When updating the version, please also update mesa3d-headers
>> -MESA3D_VERSION = 24.0.9
>> +MESA3D_VERSION = 24.2.0
>>  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
>>  MESA3D_SITE = https://archive.mesa3d.org
>>  MESA3D_LICENSE = MIT, SGI, Khronos
>> @@ -21,6 +21,7 @@ MESA3D_DEPENDENCIES = \
>>  	host-bison \
>>  	host-flex \
>>  	host-python-mako \
>> +	host-python-pyyaml \
>>  	expat \
>>  	libdrm \
>>  	zlib
>> -- 
>> 2.39.2
>> 
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

[Yann E. MORIN]

Alex, All,

On 2024-08-22 17:58 +0100, Alex Bennée spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> writes:
> > On 2024-08-22 14:02 +0100, Alex Bennée spake thusly:
> >> While VirtIO Venus support went in earlier this is the first version
> >> that is known to work well.
> > This commit log is confusing: it talks about VirtIO Venus, but there is
> > no such addition in the patch.
> Support for VirtIO venus was added in patch 1/4 but testing has shown it
> needs at least 24.2.0 to work properly.

OK, thanks, I see.

So, if it needs 24.2.0, only add it after the bump to 24.2.0; there is
no point in adding an option for a feature that is known broken in
24.0.9.

Also, patch 1 does not mention Venus at all; it mentions VirtIO Vulkan,
and except for having the same first letter, the connection is not
obvious.

So, could you rework the series in a more logical order, possibly
something like:

  * 1/3 package/vkmark: add vmkark benchmarking tool
  * 2/3 package/mesa3d: bump to 24.2.0
  * 3/3 package/mesa3d: add option to enable VIRTIO vulkan driver

Also, I suspect the following patch does not belong to the series; I
don't see how it is related to mesa3d or the bump thereof:

  * board/qemu: add post-build script to aarch64_virt_defconfig

Regards,
Yann E. MORIN.

> > It however adds a dependency on
> > host-python-pyyaml, but that is not explained, and does not seem
> > related
> 
> It was a dependency I needed to add to support the build.
> 
> > to VirtIO Venus either...
> >
> > Could you clarify, please?
> >
> > Also, see below...
> >
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> ---
> >>  package/mesa3d-headers/mesa3d-headers.mk | 2 +-
> >>  package/mesa3d/mesa3d.hash               | 5 ++---
> >>  package/mesa3d/mesa3d.mk                 | 3 ++-
> >>  3 files changed, 5 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/package/mesa3d-headers/mesa3d-headers.mk b/package/mesa3d-headers/mesa3d-headers.mk
> >> index 33c60b285f..98afb77a9c 100644
> >> --- a/package/mesa3d-headers/mesa3d-headers.mk
> >> +++ b/package/mesa3d-headers/mesa3d-headers.mk
> >> @@ -12,7 +12,7 @@ endif
> >>  
> >>  # Not possible to directly refer to mesa3d variables, because of
> >>  # first/second expansion trickery...
> >> -MESA3D_HEADERS_VERSION = 24.0.9
> >> +MESA3D_HEADERS_VERSION = 24.2.0
> >>  MESA3D_HEADERS_SOURCE = mesa-$(MESA3D_HEADERS_VERSION).tar.xz
> >>  MESA3D_HEADERS_SITE = https://archive.mesa3d.org
> >>  MESA3D_HEADERS_DL_SUBDIR = mesa3d
> >> diff --git a/package/mesa3d/mesa3d.hash b/package/mesa3d/mesa3d.hash
> >> index d506d398b8..1ff11f9bd8 100644
> >> --- a/package/mesa3d/mesa3d.hash
> >> +++ b/package/mesa3d/mesa3d.hash
> >> @@ -1,5 +1,4 @@
> >> -# From https://lists.freedesktop.org/archives/mesa-announce/2024-June/000764.html
> >> -sha256  51aa686ca4060e38711a9e8f60c8f1efaa516baf411946ed7f2c265cd582ca4c  mesa-24.0.9.tar.xz
> >> -sha512  de2ee6c9df1fc106ee10befe0a76be1e9cfe83d65dbdb83bad6d8d7cfaa085232fb115293a1a790b37b50b1fe14bd58aafbcfe5a15e953b5901a7105d57569a5  mesa-24.0.9.tar.xz
> >> +# From https://docs.mesa3d.org/relnotes/24.2.0.html
> >> +sha256  c02bb72cea290f78b11895a0c95c7c92394f180d7ff66d4a762ec6950a58addf  mesa-24.2.0.tar.xz
> >
> > There previously was sha256 _and_ sha512 hashes, but now you only add a
> > sha256 one. Can you extend a little blurb about that, please?
> 
> Sure - only the sha256 was in the relase announcement. I could calculate
> one if you want?
> 
> >
> > Regards,
> > Yann E. MORIN.
> >
> >>  # License
> >>  sha256  a00275a53178e2645fb65be99a785c110513446a5071ff2c698ed260ad917d75  docs/license.rst
> >> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> >> index d3b5010648..29f26c5663 100644
> >> --- a/package/mesa3d/mesa3d.mk
> >> +++ b/package/mesa3d/mesa3d.mk
> >> @@ -5,7 +5,7 @@
> >>  ################################################################################
> >>  
> >>  # When updating the version, please also update mesa3d-headers
> >> -MESA3D_VERSION = 24.0.9
> >> +MESA3D_VERSION = 24.2.0
> >>  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
> >>  MESA3D_SITE = https://archive.mesa3d.org
> >>  MESA3D_LICENSE = MIT, SGI, Khronos
> >> @@ -21,6 +21,7 @@ MESA3D_DEPENDENCIES = \
> >>  	host-bison \
> >>  	host-flex \
> >>  	host-python-mako \
> >> +	host-python-pyyaml \
> >>  	expat \
> >>  	libdrm \
> >>  	zlib
> >> -- 
> >> 2.39.2
> >> 
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot@buildroot.org
> >> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> Alex Bennée
> Virtualisation Tech Lead @ Linaro
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 0/4] Update Mesa and enable vkmark

[Alex Bennée]

Alex Bennée <alex.bennee@linaro.org> writes:

> This is part of building test images for virtio-vulkan support in
> QEMU. We need to update Mesa, enable the VirtIO driver and add the
> vkmark tool. There is also a small patch to ensure we enable a getty
> on the console so we can start weston and spawn the vkmark binary.
> Currently it is not able to run directly with the DRM device.

I'm spinning a v2 now I've seen some niggles from the CI.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

[Bernd Kuhls]

Am Thu, 22 Aug 2024 14:02:20 +0100 schrieb Alex Bennée:

> -MESA3D_VERSION = 24.0.9
> +MESA3D_VERSION = 24.2.0

Hi Alex,

to bump mesa to >= 24.1.x more patches are needed, please see my series 
https://patchwork.ozlabs.org/project/buildroot/list/?series=416827

Locally I also bumped to 24.2.0 already but the commit needs some more 
love: https://github.com/bkuhls/buildroot/commit/
74bfbe1f541697614ef1319bc420b43fbd30d47e

Would it be ok for you if I squash your 
BR2_PACKAGE_MESA3D_VULKAN_DRIVER_VIRTIO commit into the 24.2.0 bump?

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

[Alex Bennée]

"Yann E. MORIN" <yann.morin.1998@free.fr> writes:

> Alex, All,
>
> On 2024-08-22 17:58 +0100, Alex Bennée spake thusly:
>> "Yann E. MORIN" <yann.morin.1998@free.fr> writes:
>> > On 2024-08-22 14:02 +0100, Alex Bennée spake thusly:
>> >> While VirtIO Venus support went in earlier this is the first version
>> >> that is known to work well.
>> > This commit log is confusing: it talks about VirtIO Venus, but there is
>> > no such addition in the patch.
>> Support for VirtIO venus was added in patch 1/4 but testing has shown it
>> needs at least 24.2.0 to work properly.
>
> OK, thanks, I see.
>
> So, if it needs 24.2.0, only add it after the bump to 24.2.0; there is
> no point in adding an option for a feature that is known broken in
> 24.0.9.
>
> Also, patch 1 does not mention Venus at all; it mentions VirtIO Vulkan,
> and except for having the same first letter, the connection is not
> obvious.
>
> So, could you rework the series in a more logical order, possibly
> something like:
>
>   * 1/3 package/vkmark: add vmkark benchmarking tool
>   * 2/3 package/mesa3d: bump to 24.2.0
>   * 3/3 package/mesa3d: add option to enable VIRTIO vulkan driver
>
> Also, I suspect the following patch does not belong to the series; I
> don't see how it is related to mesa3d or the bump thereof:
>
>   * board/qemu: add post-build script to aarch64_virt_defconfig

You need to be logged into a framebuffer console to start weston to be
able to test the virtio-vulkan GPU.

>
> Regards,
> Yann E. MORIN.
>
>> > It however adds a dependency on
>> > host-python-pyyaml, but that is not explained, and does not seem
>> > related
>> 
>> It was a dependency I needed to add to support the build.
>> 
>> > to VirtIO Venus either...
>> >
>> > Could you clarify, please?
>> >
>> > Also, see below...
>> >
>> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> >> ---
>> >>  package/mesa3d-headers/mesa3d-headers.mk | 2 +-
>> >>  package/mesa3d/mesa3d.hash               | 5 ++---
>> >>  package/mesa3d/mesa3d.mk                 | 3 ++-
>> >>  3 files changed, 5 insertions(+), 5 deletions(-)
>> >> 
>> >> diff --git a/package/mesa3d-headers/mesa3d-headers.mk b/package/mesa3d-headers/mesa3d-headers.mk
>> >> index 33c60b285f..98afb77a9c 100644
>> >> --- a/package/mesa3d-headers/mesa3d-headers.mk
>> >> +++ b/package/mesa3d-headers/mesa3d-headers.mk
>> >> @@ -12,7 +12,7 @@ endif
>> >>  
>> >>  # Not possible to directly refer to mesa3d variables, because of
>> >>  # first/second expansion trickery...
>> >> -MESA3D_HEADERS_VERSION = 24.0.9
>> >> +MESA3D_HEADERS_VERSION = 24.2.0
>> >>  MESA3D_HEADERS_SOURCE = mesa-$(MESA3D_HEADERS_VERSION).tar.xz
>> >>  MESA3D_HEADERS_SITE = https://archive.mesa3d.org
>> >>  MESA3D_HEADERS_DL_SUBDIR = mesa3d
>> >> diff --git a/package/mesa3d/mesa3d.hash b/package/mesa3d/mesa3d.hash
>> >> index d506d398b8..1ff11f9bd8 100644
>> >> --- a/package/mesa3d/mesa3d.hash
>> >> +++ b/package/mesa3d/mesa3d.hash
>> >> @@ -1,5 +1,4 @@
>> >> -# From https://lists.freedesktop.org/archives/mesa-announce/2024-June/000764.html
>> >> -sha256  51aa686ca4060e38711a9e8f60c8f1efaa516baf411946ed7f2c265cd582ca4c  mesa-24.0.9.tar.xz
>> >> -sha512  de2ee6c9df1fc106ee10befe0a76be1e9cfe83d65dbdb83bad6d8d7cfaa085232fb115293a1a790b37b50b1fe14bd58aafbcfe5a15e953b5901a7105d57569a5  mesa-24.0.9.tar.xz
>> >> +# From https://docs.mesa3d.org/relnotes/24.2.0.html
>> >> +sha256  c02bb72cea290f78b11895a0c95c7c92394f180d7ff66d4a762ec6950a58addf  mesa-24.2.0.tar.xz
>> >
>> > There previously was sha256 _and_ sha512 hashes, but now you only add a
>> > sha256 one. Can you extend a little blurb about that, please?
>> 
>> Sure - only the sha256 was in the relase announcement. I could calculate
>> one if you want?
>> 
>> >
>> > Regards,
>> > Yann E. MORIN.
>> >
>> >>  # License
>> >>  sha256  a00275a53178e2645fb65be99a785c110513446a5071ff2c698ed260ad917d75  docs/license.rst
>> >> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
>> >> index d3b5010648..29f26c5663 100644
>> >> --- a/package/mesa3d/mesa3d.mk
>> >> +++ b/package/mesa3d/mesa3d.mk
>> >> @@ -5,7 +5,7 @@
>> >>  ################################################################################
>> >>  
>> >>  # When updating the version, please also update mesa3d-headers
>> >> -MESA3D_VERSION = 24.0.9
>> >> +MESA3D_VERSION = 24.2.0
>> >>  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
>> >>  MESA3D_SITE = https://archive.mesa3d.org
>> >>  MESA3D_LICENSE = MIT, SGI, Khronos
>> >> @@ -21,6 +21,7 @@ MESA3D_DEPENDENCIES = \
>> >>  	host-bison \
>> >>  	host-flex \
>> >>  	host-python-mako \
>> >> +	host-python-pyyaml \
>> >>  	expat \
>> >>  	libdrm \
>> >>  	zlib
>> >> -- 
>> >> 2.39.2
>> >> 
>> >> _______________________________________________
>> >> buildroot mailing list
>> >> buildroot@buildroot.org
>> >> https://lists.buildroot.org/mailman/listinfo/buildroot
>> 
>> -- 
>> Alex Bennée
>> Virtualisation Tech Lead @ Linaro
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

[Yann E. MORIN]

Alex, All,

On 2024-08-22 20:41 +0100, Alex Bennée spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> writes:
[--SNIP--]
> > Also, I suspect the following patch does not belong to the series; I
> > don't see how it is related to mesa3d or the bump thereof:
> >   * board/qemu: add post-build script to aarch64_virt_defconfig
> You need to be logged into a framebuffer console to start weston to be
> able to test the virtio-vulkan GPU.

But qemu_aarch64_virt_defconfig does not even enable mesa3d, so the
rationale does not stsand.

However, a runtime test would indeed be very welcome, but they do not
use the defconfigs; see support/testing/ for examples.

[--SNIP--]
> >> > There previously was sha256 _and_ sha512 hashes, but now you only add a
> >> > sha256 one. Can you extend a little blurb about that, please?
> >> Sure - only the sha256 was in the relase announcement. I could calculate
> >> one if you want?

AH, OK, then state so in the commit log (e.g.: upstream does not provide
a sh512 in their announcement, just a sha256, so use only that).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/4] package/vkmark: add vmkark benchmarking tool

[Thomas Petazzoni via buildroot]

Hello Alex,

Thanks for this patch! See below for some comments.

On Thu, 22 Aug 2024 14:02:18 +0100
Alex Bennée <alex.bennee@linaro.org> wrote:

> We build from the current master as we need fairly upto date bits for
> cross compile support.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  package/Config.in          |  1 +
>  package/vkmark/Config.in   | 39 ++++++++++++++++++++++++++++++++++++++
>  package/vkmark/vkmark.hash |  3 +++
>  package/vkmark/vkmark.mk   | 28 +++++++++++++++++++++++++++
>  4 files changed, 71 insertions(+)

This new package needs an entry in the DEVELOPERS file.


> diff --git a/package/vkmark/Config.in b/package/vkmark/Config.in
> new file mode 100644
> index 0000000000..15d8e380ed
> --- /dev/null
> +++ b/package/vkmark/Config.in
> @@ -0,0 +1,39 @@
> +config BR2_PACKAGE_VKMARK_FLAVOR_ANY
> +	bool
> +
> +config BR2_PACKAGE_VKMARK_FLAVOR_KMS
> +	bool
> +	default y
> +	depends on BR2_PACKAGE_HAS_LIBGBM
> +	select BR2_PACKAGE_LIBDRM
> +        select BR2_PACKAGE_VKMARK_FLAVOR_ANY

Indentation issue.

But more importantly, this option that you've added means that *ALL*
Buildroot configurations now have BR2_PACKAGE_LIBDRM forcefully
selected. Indeed, BR2_PACKAGE_VKMARK_FLAVOR_KMS is a blind option that
is default y (so always enabled) and it selects BR2_PACKAGE_LIBDRM.

> +config BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND
> +	bool
> +	default n

"default n" is useless, as an option is disabled by default.

> +	select BR2_PACKAGE_VKMARK_FLAVOR_ANY

This cannot have any impact, because BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND
is never enabled by anything.

> +config BR2_PACKAGE_VKMARK_FLAVOR_X11
> +	bool
> +	default n

Same comment as above.

> +	select BR2_PACKAGE_LIBXCB
> +        select BR2_PACKAGE_VKMARK_FLAVOR_ANY

Same comment as above: these selects are no-ops, as
BR2_PACKAGE_VKMARK_FLAVOR_X11 is never going to be "enabled", as it's a
blind option that nothing selects/enables.

If you want to do something like you did, you need to do something like
this:

config BR2_PACKAGE_VKMARK_FLAVOR_ANY
	bool

config BR2_PACKAGE_VKMARK_FLAVOR_KMS
	bool
	default y if BR2_PACKAGE_HAS_LIBGBM
        select BR2_PACKAGE_VKMARK_FLAVOR_ANY

config BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND
	bool
	default y if BR2_PACKAGE_WAYLAND
	select BR2_PACKAGE_VKMARK_FLAVOR_ANY

config BR2_PACKAGE_VKMARK_FLAVOR_X11
	bool
	default y if BR2_PACKAGE_XORG7
        select BR2_PACKAGE_VKMARK_FLAVOR_ANY

> +config BR2_PACKAGE_VKMARK
> +	bool "vkmark"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
> +	depends on BR2_PACKAGE_VKMARK_FLAVOR_ANY
> +	select BR2_PACKAGE_VULKAN_HEADERS
> +	select BR2_PACKAGE_VULKAN_LOADER

You need to replicate those dependencies:

        depends on !BR2_STATIC_LIBS # vulkan-loader
        depends on BR2_TOOLCHAIN_HAS_THREADS # vulkan-loader

> +	select BR2_PACKAGE_GLM
> +	select BR2_PACKAGE_ASSIMP

And also:

        depends on BR2_USE_WCHAR # assimp
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # assimp

and perhaps for C++ you need to:

	depends on BR2_INSTALL_LIBSTDCPP # vulkan-loader, glm, assimp, vkmark

> +	select BR2_PACKAGE_WAYLAND_PROTOCOLS if BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND

	select BR2_PACKAGE_LIBXCB if BR2_PACKAGE_VKMARK_FLAVOR_X11
	select BR2_PACKAGE_LIBDRM if BR2_PACKAGE_VKMARK_FLAVOR_KMS

> +	help
> +	  vmmark is an Vulkan GPU benchmark.
> +
> +	  https://github.com/vkmark/vkmark
> +
> +comment "vkmark needs a toolchain w/ C++, dynamic library, threads"
> +	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || \
> +		!BR2_TOOLCHAIN_HAS_THREADS

Update this comment to reflect all the dependencies above. Also, only
show the comment if BR2_PACKAGE_VKMARK_FLAVOR_ANY is true.

> diff --git a/package/vkmark/vkmark.hash b/package/vkmark/vkmark.hash
> new file mode 100644
> index 0000000000..494d0c4808
> --- /dev/null
> +++ b/package/vkmark/vkmark.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  9f106a67ce1e2aa4140bbf9325cc5837157d64f945534bc9e57286d690b08346  vkmark-2017.08.tar.gz

Hash not needed.

> +sha256  d08143e8828d5b9ed005cb6dcef4d88a49df0ac4c9e1356ace739b449c165f54  vkmark-ab6e6f34077722d5ae33f6bd40b18ef9c0e99a15.tar.gz

We need the hash of the license file.

> diff --git a/package/vkmark/vkmark.mk b/package/vkmark/vkmark.mk
> new file mode 100644
> index 0000000000..19d796a9b0
> --- /dev/null
> +++ b/package/vkmark/vkmark.mk
> @@ -0,0 +1,28 @@
> +################################################################################
> +#
> +# vkmark
> +#
> +################################################################################
> +
> +VKMARK_VERSION = ab6e6f34077722d5ae33f6bd40b18ef9c0e99a15
> +VKMARK_SITE = $(call github,vkmark,vkmark,$(VKMARK_VERSION))
> +VKMARK_LICENSE = LGPL-2.1
> +VKMARK_LICENSE_FILES = COPYING-LGPL2.1
> +VKMARK_DEPENDENCIES = host-pkgconf vulkan-headers vulkan-loader glm

No build dependency on assimp? Then why do you select it?

> +ifeq ($(BR2_PACKAGE_VKMARK_FLAVOR_KMS),y)
> +VKMARK_DEPENDENCIES += libdrm libgbm
> +VKMARK_CONF_OPTS += -Dkms=true

else
VKMARK_CONF_OPTS += -Dkms=false


> +endif
> +
> +ifeq ($(BR2_PACKAGE_VKMARK_FLAVOR_WAYLAND),y)
> +VKMARK_DEPENDENCIES += wayland wayland-protocols
> +VKMARK_CONF_OPTS += -Dwayland=true

else
VKMARK_CONF_OPTS += -Dwayland=false


> +endif
> +
> +ifeq ($(BR2_PACKAGE_VKMARK_FLAVOR_X11),y)
> +VKMARK_DEPENDENCIES += libxcb
> +VKMARK_CONF_OPTS += -Dxcb=true

else
VKMARK_CONF_OPTS += -Dxcb=false

> +endif
> +
> +$(eval $(meson-package))

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/4] board/qemu: add post-build script to aarch64_virt_defconfig

[Thomas Petazzoni via buildroot]

Hello Alex,

On Thu, 22 Aug 2024 14:02:19 +0100
Alex Bennée <alex.bennee@linaro.org> wrote:

> This is in aid of supporting getty on fbcon.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Like Yann, I also don't think this really belongs to the
qemu_aarch64_virt_defconfig. Why this defconfig in particular, and not
any other?

If you want a "demo" of vkmark and the Venus vulkan driver, a runtime
test in support/testing/ is much more relevant, as Yann suggested.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot