[Buildroot] [PATCH] package/google-breakpad: fix tools option identation in menuconfig

[Buildroot] [PATCH] package/google-breakpad: fix tools option identation in menuconfig

[Nuno Gonçalves via buildroot]

Move comment in Config.in to end of file so that
BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS is properly idented.

Signed-off-by: Nuno Gonçalves <nunog@fr24.com>
---
 package/google-breakpad/Config.in | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
index 0d21fd2e5c..5c7f4bb7ba 100644
--- a/package/google-breakpad/Config.in
+++ b/package/google-breakpad/Config.in
@@ -35,14 +35,6 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
 
 	  https://chromium.googlesource.com/breakpad/breakpad
 
-comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
-	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
-	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_TOOLCHAIN_USES_GLIBC || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
-
 if BR2_PACKAGE_GOOGLE_BREAKPAD
 
 config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS
@@ -52,3 +44,11 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS
 	  minidump_stackwalk and microdump_stackwalk.
 
 endif
+
+comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
+	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
-- 
2.43.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/google-breakpad: fix tools option identation in menuconfig

[Yann E. MORIN]

Nuno, All,

On 2024-02-18 19:30 +0000, Nuno Gonçalves via buildroot spake thusly:
> Move comment in Config.in to end of file so that
> BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS is properly idented.

Ah yes, it was bothering me the other day, but I did not get to it...

> Signed-off-by: Nuno Gonçalves <nunog@fr24.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/google-breakpad/Config.in | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
> index 0d21fd2e5c..5c7f4bb7ba 100644
> --- a/package/google-breakpad/Config.in
> +++ b/package/google-breakpad/Config.in
> @@ -35,14 +35,6 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
>  
>  	  https://chromium.googlesource.com/breakpad/breakpad
>  
> -comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
> -	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> -	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> -	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> -		!BR2_TOOLCHAIN_HAS_THREADS || \
> -		!BR2_TOOLCHAIN_USES_GLIBC || \
> -		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> -
>  if BR2_PACKAGE_GOOGLE_BREAKPAD
>  
>  config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS
> @@ -52,3 +44,11 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS
>  	  minidump_stackwalk and microdump_stackwalk.
>  
>  endif
> +
> +comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
> +	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> +		!BR2_TOOLCHAIN_HAS_THREADS || \
> +		!BR2_TOOLCHAIN_USES_GLIBC || \
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> -- 
> 2.43.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/google-breakpad: fix tools option identation in menuconfig

[Peter Korsgaard]

>>>>> "Nuno" == Nuno Gonçalves via buildroot <buildroot@buildroot.org> writes:

 > Move comment in Config.in to end of file so that
 > BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS is properly idented.

 > Signed-off-by: Nuno Gonçalves <nunog@fr24.com>

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot