[Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation

[Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation

[Florian Fainelli]

Disable a number of unused files that were being installed into the root
filesystem and thus inflating its size needlessly:

* Disable the building of documentation

* Disable support for other languages which is comprised of Common Lisp that
  buildroot has no package for

* Only install binaries and shared/static libraries, remove libtool archive

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:

- remove header files, pkgconfig and other unnecessary files

 package/libgpg-error/libgpg-error.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/package/libgpg-error/libgpg-error.mk b/package/libgpg-error/libgpg-error.mk
index 86dea6ad2acd..6ce1f8d908de 100644
--- a/package/libgpg-error/libgpg-error.mk
+++ b/package/libgpg-error/libgpg-error.mk
@@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES
 LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config
 LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
 LIBGPG_ERROR_CONF_OPTS = --disable-tests \
-		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG)
+		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \
+		--disable-languages \
+		--disable-doc
 
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
 LIBGPG_ERROR_CONF_OPTS += --enable-threads
@@ -22,4 +24,9 @@ else
 LIBGPG_ERROR_CONF_OPTS += --disable-threads
 endif
 
+define LIBGPG_ERROR_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec
+	rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la
+endef
+
 $(eval $(autotools-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation

[Baruch Siach via buildroot]

Hi Florian,

On Mon, Dec 19 2022, Florian Fainelli wrote:
> Disable a number of unused files that were being installed into the root
> filesystem and thus inflating its size needlessly:
>
> * Disable the building of documentation
>
> * Disable support for other languages which is comprised of Common Lisp that
>   buildroot has no package for
>
> * Only install binaries and shared/static libraries, remove libtool archive
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
>
> - remove header files, pkgconfig and other unnecessary files
>
>  package/libgpg-error/libgpg-error.mk | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/package/libgpg-error/libgpg-error.mk b/package/libgpg-error/libgpg-error.mk
> index 86dea6ad2acd..6ce1f8d908de 100644
> --- a/package/libgpg-error/libgpg-error.mk
> +++ b/package/libgpg-error/libgpg-error.mk
> @@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES
>  LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config
>  LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
>  LIBGPG_ERROR_CONF_OPTS = --disable-tests \
> -		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG)
> +		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \
> +		--disable-languages \
> +		--disable-doc

This is part of default _CONFIGURE_CMDS for autotools packages. See
package/pkg-autotools.mk.

>  ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
>  LIBGPG_ERROR_CONF_OPTS += --enable-threads
> @@ -22,4 +24,9 @@ else
>  LIBGPG_ERROR_CONF_OPTS += --disable-threads
>  endif
>  
> +define LIBGPG_ERROR_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec
> +	rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la

The target-finalize target in top Makefile should remove .la files:

        find $(TARGET_DIR)/lib/ $(TARGET_DIR)/usr/lib/ $(TARGET_DIR)/usr/libexec/ \
                \( -name '*.a' -o -name '*.la' -o -name '*.prl' \) -print0 | xargs -0 rm -f

Doesn't that work for you?

baruch

> +endef
> +
>  $(eval $(autotools-package))


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation

[Yann E. MORIN]

Florian, All,

On 2022-12-19 15:08 -0800, Florian Fainelli spake thusly:
> Disable a number of unused files that were being installed into the root
> filesystem and thus inflating its size needlessly:
> 
> * Disable the building of documentation
> 
> * Disable support for other languages which is comprised of Common Lisp that
>   buildroot has no package for
> 
> * Only install binaries and shared/static libraries, remove libtool archive

As Baruch mentioned in his review, disabling the documentation and
removing headers and libtool archives whould already be handled by the
package infra.

So I applied your v1 instead, and makred this one rejected.

Regards,
Yann E. MORIN.

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
> 
> - remove header files, pkgconfig and other unnecessary files
> 
>  package/libgpg-error/libgpg-error.mk | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libgpg-error/libgpg-error.mk b/package/libgpg-error/libgpg-error.mk
> index 86dea6ad2acd..6ce1f8d908de 100644
> --- a/package/libgpg-error/libgpg-error.mk
> +++ b/package/libgpg-error/libgpg-error.mk
> @@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES
>  LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config
>  LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
>  LIBGPG_ERROR_CONF_OPTS = --disable-tests \
> -		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG)
> +		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \
> +		--disable-languages \
> +		--disable-doc
>  
>  ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
>  LIBGPG_ERROR_CONF_OPTS += --enable-threads
> @@ -22,4 +24,9 @@ else
>  LIBGPG_ERROR_CONF_OPTS += --disable-threads
>  endif
>  
> +define LIBGPG_ERROR_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec
> +	rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la
> +endef
> +
>  $(eval $(autotools-package))
> -- 
> 2.34.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation

[Florian Fainelli]

On 12/20/22 00:31, Yann E. MORIN wrote:
> Florian, All,
> 
> On 2022-12-19 15:08 -0800, Florian Fainelli spake thusly:
>> Disable a number of unused files that were being installed into the root
>> filesystem and thus inflating its size needlessly:
>>
>> * Disable the building of documentation
>>
>> * Disable support for other languages which is comprised of Common Lisp that
>>    buildroot has no package for
>>
>> * Only install binaries and shared/static libraries, remove libtool archive
> 
> As Baruch mentioned in his review, disabling the documentation and
> removing headers and libtool archives whould already be handled by the
> package infra.

It does, I was looking at the target/ folder instead of the actual root 
filesystem, my bad, thanks and happy holidays.
-- 
Florian

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot