* [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation
@ 2022-12-19 23:08 Florian Fainelli
2022-12-20 5:30 ` Baruch Siach via buildroot
2022-12-20 8:31 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-12-19 23:08 UTC (permalink / raw)
To: buildroot
Cc: bernd.kuhls, chrismcc, Florian Fainelli, mmayer, yann.morin.1998,
thomas.petazzoni, fontaine.fabrice
Disable a number of unused files that were being installed into the root
filesystem and thus inflating its size needlessly:
* Disable the building of documentation
* Disable support for other languages which is comprised of Common Lisp that
buildroot has no package for
* Only install binaries and shared/static libraries, remove libtool archive
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- remove header files, pkgconfig and other unnecessary files
package/libgpg-error/libgpg-error.mk | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/package/libgpg-error/libgpg-error.mk b/package/libgpg-error/libgpg-error.mk
index 86dea6ad2acd..6ce1f8d908de 100644
--- a/package/libgpg-error/libgpg-error.mk
+++ b/package/libgpg-error/libgpg-error.mk
@@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES
LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config
LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
LIBGPG_ERROR_CONF_OPTS = --disable-tests \
- --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG)
+ --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \
+ --disable-languages \
+ --disable-doc
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
LIBGPG_ERROR_CONF_OPTS += --enable-threads
@@ -22,4 +24,9 @@ else
LIBGPG_ERROR_CONF_OPTS += --disable-threads
endif
+define LIBGPG_ERROR_INSTALL_TARGET_CMDS
+ $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec
+ rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la
+endef
+
$(eval $(autotools-package))
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation
2022-12-19 23:08 [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation Florian Fainelli
@ 2022-12-20 5:30 ` Baruch Siach via buildroot
2022-12-20 8:31 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Baruch Siach via buildroot @ 2022-12-20 5:30 UTC (permalink / raw)
To: Florian Fainelli
Cc: bernd.kuhls, chrismcc, mmayer, fontaine.fabrice, thomas.petazzoni,
buildroot, yann.morin.1998
Hi Florian,
On Mon, Dec 19 2022, Florian Fainelli wrote:
> Disable a number of unused files that were being installed into the root
> filesystem and thus inflating its size needlessly:
>
> * Disable the building of documentation
>
> * Disable support for other languages which is comprised of Common Lisp that
> buildroot has no package for
>
> * Only install binaries and shared/static libraries, remove libtool archive
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
>
> - remove header files, pkgconfig and other unnecessary files
>
> package/libgpg-error/libgpg-error.mk | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/package/libgpg-error/libgpg-error.mk b/package/libgpg-error/libgpg-error.mk
> index 86dea6ad2acd..6ce1f8d908de 100644
> --- a/package/libgpg-error/libgpg-error.mk
> +++ b/package/libgpg-error/libgpg-error.mk
> @@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES
> LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config
> LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
> LIBGPG_ERROR_CONF_OPTS = --disable-tests \
> - --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG)
> + --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \
> + --disable-languages \
> + --disable-doc
This is part of default _CONFIGURE_CMDS for autotools packages. See
package/pkg-autotools.mk.
> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> LIBGPG_ERROR_CONF_OPTS += --enable-threads
> @@ -22,4 +24,9 @@ else
> LIBGPG_ERROR_CONF_OPTS += --disable-threads
> endif
>
> +define LIBGPG_ERROR_INSTALL_TARGET_CMDS
> + $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec
> + rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la
The target-finalize target in top Makefile should remove .la files:
find $(TARGET_DIR)/lib/ $(TARGET_DIR)/usr/lib/ $(TARGET_DIR)/usr/libexec/ \
\( -name '*.a' -o -name '*.la' -o -name '*.prl' \) -print0 | xargs -0 rm -f
Doesn't that work for you?
baruch
> +endef
> +
> $(eval $(autotools-package))
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation
2022-12-19 23:08 [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation Florian Fainelli
2022-12-20 5:30 ` Baruch Siach via buildroot
@ 2022-12-20 8:31 ` Yann E. MORIN
2022-12-20 19:00 ` Florian Fainelli
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2022-12-20 8:31 UTC (permalink / raw)
To: Florian Fainelli
Cc: bernd.kuhls, chrismcc, mmayer, thomas.petazzoni, buildroot,
fontaine.fabrice
Florian, All,
On 2022-12-19 15:08 -0800, Florian Fainelli spake thusly:
> Disable a number of unused files that were being installed into the root
> filesystem and thus inflating its size needlessly:
>
> * Disable the building of documentation
>
> * Disable support for other languages which is comprised of Common Lisp that
> buildroot has no package for
>
> * Only install binaries and shared/static libraries, remove libtool archive
As Baruch mentioned in his review, disabling the documentation and
removing headers and libtool archives whould already be handled by the
package infra.
So I applied your v1 instead, and makred this one rejected.
Regards,
Yann E. MORIN.
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
>
> - remove header files, pkgconfig and other unnecessary files
>
> package/libgpg-error/libgpg-error.mk | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/package/libgpg-error/libgpg-error.mk b/package/libgpg-error/libgpg-error.mk
> index 86dea6ad2acd..6ce1f8d908de 100644
> --- a/package/libgpg-error/libgpg-error.mk
> +++ b/package/libgpg-error/libgpg-error.mk
> @@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES
> LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config
> LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
> LIBGPG_ERROR_CONF_OPTS = --disable-tests \
> - --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG)
> + --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \
> + --disable-languages \
> + --disable-doc
>
> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> LIBGPG_ERROR_CONF_OPTS += --enable-threads
> @@ -22,4 +24,9 @@ else
> LIBGPG_ERROR_CONF_OPTS += --disable-threads
> endif
>
> +define LIBGPG_ERROR_INSTALL_TARGET_CMDS
> + $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec
> + rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la
> +endef
> +
> $(eval $(autotools-package))
> --
> 2.34.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation
2022-12-20 8:31 ` Yann E. MORIN
@ 2022-12-20 19:00 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-12-20 19:00 UTC (permalink / raw)
To: Yann E. MORIN
Cc: bernd.kuhls, chrismcc, mmayer, thomas.petazzoni, buildroot,
fontaine.fabrice
On 12/20/22 00:31, Yann E. MORIN wrote:
> Florian, All,
>
> On 2022-12-19 15:08 -0800, Florian Fainelli spake thusly:
>> Disable a number of unused files that were being installed into the root
>> filesystem and thus inflating its size needlessly:
>>
>> * Disable the building of documentation
>>
>> * Disable support for other languages which is comprised of Common Lisp that
>> buildroot has no package for
>>
>> * Only install binaries and shared/static libraries, remove libtool archive
>
> As Baruch mentioned in his review, disabling the documentation and
> removing headers and libtool archives whould already be handled by the
> package infra.
It does, I was looking at the target/ folder instead of the actual root
filesystem, my bad, thanks and happy holidays.
--
Florian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-20 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-19 23:08 [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation Florian Fainelli
2022-12-20 5:30 ` Baruch Siach via buildroot
2022-12-20 8:31 ` Yann E. MORIN
2022-12-20 19:00 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox