Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies
@ 2023-08-14  7:16 Waldemar Brodkorb
  2023-08-14 10:56 ` Yann E. MORIN
  2023-09-12 18:18 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2023-08-14  7:16 UTC (permalink / raw)
  To: buildroot

rdma-core selects perftest and needs NPTL.
Should be backported to stable branches, because the problem
exist since the addition of the package.

Fixes:
 - http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/perftest/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/perftest/Config.in b/package/perftest/Config.in
index 25cd1a9b8d..0a4114015b 100644
--- a/package/perftest/Config.in
+++ b/package/perftest/Config.in
@@ -20,7 +20,7 @@ config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
 config BR2_PACKAGE_PERFTEST
 	bool "perftest"
 	depends on BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # rdma-core
 	depends on !BR2_STATIC_LIBS # rdma-core
 	# musl does not define sysconf(_SC_LEVEL1_DCACHE_LINESIZE)
 	depends on !BR2_TOOLCHAIN_USES_MUSL
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies
  2023-08-14  7:16 [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies Waldemar Brodkorb
@ 2023-08-14 10:56 ` Yann E. MORIN
  2023-09-12 18:18 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2023-08-14 10:56 UTC (permalink / raw)
  To: Waldemar Brodkorb; +Cc: buildroot

Waldemar, All,

On 2023-08-14 09:16 +0200, Waldemar Brodkorb spake thusly:
> rdma-core selects perftest and needs NPTL.
> Should be backported to stable branches, because the problem
> exist since the addition of the package.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/perftest/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/perftest/Config.in b/package/perftest/Config.in
> index 25cd1a9b8d..0a4114015b 100644
> --- a/package/perftest/Config.in
> +++ b/package/perftest/Config.in
> @@ -20,7 +20,7 @@ config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
>  config BR2_PACKAGE_PERFTEST
>  	bool "perftest"
>  	depends on BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # rdma-core

You also missed propagating the dependency on the kernel headers
version, so I've done that.

I also expanded the commit log to explain when the two issues were
introduced.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  	depends on !BR2_STATIC_LIBS # rdma-core
>  	# musl does not define sysconf(_SC_LEVEL1_DCACHE_LINESIZE)
>  	depends on !BR2_TOOLCHAIN_USES_MUSL
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies
  2023-08-14  7:16 [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies Waldemar Brodkorb
  2023-08-14 10:56 ` Yann E. MORIN
@ 2023-09-12 18:18 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-09-12 18:18 UTC (permalink / raw)
  To: Waldemar Brodkorb; +Cc: buildroot

>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > rdma-core selects perftest and needs NPTL.
 > Should be backported to stable branches, because the problem
 > exist since the addition of the package.

 > Fixes:
 >  - http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de

 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-12 18:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-14  7:16 [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies Waldemar Brodkorb
2023-08-14 10:56 ` Yann E. MORIN
2023-09-12 18:18 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox