[Buildroot] [PATCH v4 0/2] rpi-utils replaces rpi-userland

[Buildroot] [PATCH v4 0/2] rpi-utils replaces rpi-userland

[Gaël PORTAY]

Hello,

The package rpi-userland has been marked as ancient and deprecated[1]
nine-month ago.

This patch series adds its replacing package rpi-utils (first patch),
and it adds the message in the rpi-userland help (second patch).

Tell me if the package should go in the legacy thing.

[1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848

Changes since v1:
 - Add myself to DEVELOPERS (rpi-utils)
 - Add missing entry in packages/Config.in (rpi-utils)
 - Add needed comment for glibc/musl toolchains with dynamic library
   (rpi-utils)
 - Add depends on !BR2_TOOLCHAIN_USES_UCLIBC (rpi-utils)

Changes since v2:
 - Remove depends on !BR2_TOOLCHAIN_USES_UCLIBC

Changes since v3:
 - Update my e-mail
 - Rebase on master
 - Add Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

Regards,
Gaël PORTAY (2):
  package/rpi-utils: new package
  package/rpi-userland: package is deprecated

 DEVELOPERS                       |  1 +
 package/Config.in                |  1 +
 package/rpi-userland/Config.in   | 11 +++++++++++
 package/rpi-utils/Config.in      | 12 ++++++++++++
 package/rpi-utils/rpi-utils.hash |  3 +++
 package/rpi-utils/rpi-utils.mk   | 18 ++++++++++++++++++
 6 files changed, 46 insertions(+)
 create mode 100644 package/rpi-utils/Config.in
 create mode 100644 package/rpi-utils/rpi-utils.hash
 create mode 100644 package/rpi-utils/rpi-utils.mk

-- 
2.48.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v4 1/2] package/rpi-utils: new package

[Gaël PORTAY]

The package rpi-userland has been marked as ancient and deprecated[1].

The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
the repository rpi-utils since then.

This adds the new package rpi-utils at latest commit as there is no
tagged commit.

[1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848

Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
---
 DEVELOPERS                       |  1 +
 package/Config.in                |  1 +
 package/rpi-utils/Config.in      | 12 ++++++++++++
 package/rpi-utils/rpi-utils.hash |  3 +++
 package/rpi-utils/rpi-utils.mk   | 18 ++++++++++++++++++
 5 files changed, 35 insertions(+)
 create mode 100644 package/rpi-utils/Config.in
 create mode 100644 package/rpi-utils/rpi-utils.hash
 create mode 100644 package/rpi-utils/rpi-utils.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 2da5d178b2..fc1ba2ab27 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1203,6 +1203,7 @@ F:	package/nginx-modsecurity/
 N:	Gaël PORTAY <gael.portay+rtone@gmail.com>
 F:	board/raspberrypi/
 F:	configs/raspberrypi*
+F:	package/rpi-utils/
 
 N:	Gao Xiang <hsiangkao@aol.com>
 F:	package/erofs-utils/
diff --git a/package/Config.in b/package/Config.in
index e9c789cff2..f02fe52f35 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -454,6 +454,7 @@ menu "Firmware"
 	source "package/qoriq-fm-ucode/Config.in"
 	source "package/rcw-smarc-sal28/Config.in"
 	source "package/rpi-firmware/Config.in"
+	source "package/rpi-utils/Config.in"
 	source "package/sunxi-boards/Config.in"
 	source "package/ts4900-fpga/Config.in"
 	source "package/ux500-firmware/Config.in"
diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
new file mode 100644
index 0000000000..a2729167aa
--- /dev/null
+++ b/package/rpi-utils/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_RPI_UTILS
+	bool "rpi-utils"
+	depends on !BR2_STATIC_LIBS # dtc
+	select BR2_PACKAGE_DTC
+	help
+	  A collection of scripts and simple applications for the
+	  Raspberry Pi.
+
+	  https://github.com/raspberrypi/utils/
+
+comment "rpi-utils needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
diff --git a/package/rpi-utils/rpi-utils.hash b/package/rpi-utils/rpi-utils.hash
new file mode 100644
index 0000000000..a6612373b0
--- /dev/null
+++ b/package/rpi-utils/rpi-utils.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  c35932e501b43e5fb48cfc488aadc4a8bbceb0e9e6dafdf6c7cd2066b58acd61  rpi-utils-a1d522f0f1b50858a44fac80523a2bd80098e789.tar.gz
+sha256  731da956431d1a7c5073e7ee5ebe01f54e359c5339310b32f0893c6fe6507d5a  LICENCE
diff --git a/package/rpi-utils/rpi-utils.mk b/package/rpi-utils/rpi-utils.mk
new file mode 100644
index 0000000000..49db3aef9f
--- /dev/null
+++ b/package/rpi-utils/rpi-utils.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# rpi-utils
+#
+################################################################################
+
+RPI_UTILS_VERSION = a1d522f0f1b50858a44fac80523a2bd80098e789
+RPI_UTILS_SITE = $(call github,raspberrypi,utils,$(RPI_UTILS_VERSION))
+RPI_UTILS_LICENSE = BSD-3-Clause
+RPI_UTILS_LICENSE_FILES = LICENCE
+RPI_UTILS_INSTALL_STAGING = YES
+RPI_UTILS_DEPENDENCIES = dtc
+
+# Ensure the internal dtovl remains an archive object and it is not built as a
+# dynamic library that is linked by other utilities; as it is not installed.
+RPI_UTILS_CONF_OPTS = -DSTATIC=STATIC
+
+$(eval $(cmake-package))
-- 
2.48.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v4 2/2] package/rpi-userland: package is deprecated

[Gaël PORTAY]

The package rpi-userland has been marked as ancient and deprecated[1].

This adds the message in its help.

[1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848

Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
---
 package/rpi-userland/Config.in | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
index 4219bdb9c4..c39eb4598f 100644
--- a/package/rpi-userland/Config.in
+++ b/package/rpi-userland/Config.in
@@ -16,6 +16,17 @@ config BR2_PACKAGE_RPI_USERLAND
 	  mmal, GLESv2, vcos, openmaxil, vchiq_arm, bcm_host, WFC,
 	  OpenVG.
 
+	  Important: The package is ancient and deprecated.
+
+	  It largely contains code using proprietary APIs to interface
+	  to the VideoCore firmware. It has since moved to standard
+	  linux APIs.
+
+	  V4L2, DRM/KMS and Mesa are the APIs you should be using.
+
+	  The few useful tools from here (dtoverlay, dtmerge,
+	  vcmailbox, vcgencmd) have been moved to the package rpi-utils.
+
 	  https://github.com/raspberrypi/userland/
 
 if BR2_PACKAGE_RPI_USERLAND && BR2_arm
-- 
2.48.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/2] package/rpi-utils: new package

[Romain Naour via buildroot]

Hello Gaël, All,

Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
> The package rpi-userland has been marked as ancient and deprecated[1].
> 
> The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
> the repository rpi-utils since then.
> 
> This adds the new package rpi-utils at latest commit as there is no
> tagged commit.

BR2_PACKAGE_RPI_USERLAND is used in several packages. Since rpi-utils should
replace rpi-userland maybe it's time to also update theses packages?

Did you consider not only deprecating rpi-userland but a complete replacement?

> 
> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
> 
> Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
> Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
> ---

What happened since v3?

>  DEVELOPERS                       |  1 +
>  package/Config.in                |  1 +
>  package/rpi-utils/Config.in      | 12 ++++++++++++
>  package/rpi-utils/rpi-utils.hash |  3 +++
>  package/rpi-utils/rpi-utils.mk   | 18 ++++++++++++++++++
>  5 files changed, 35 insertions(+)
>  create mode 100644 package/rpi-utils/Config.in
>  create mode 100644 package/rpi-utils/rpi-utils.hash
>  create mode 100644 package/rpi-utils/rpi-utils.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 2da5d178b2..fc1ba2ab27 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1203,6 +1203,7 @@ F:	package/nginx-modsecurity/
>  N:	Gaël PORTAY <gael.portay+rtone@gmail.com>
>  F:	board/raspberrypi/
>  F:	configs/raspberrypi*
> +F:	package/rpi-utils/
>  
>  N:	Gao Xiang <hsiangkao@aol.com>
>  F:	package/erofs-utils/
> diff --git a/package/Config.in b/package/Config.in
> index e9c789cff2..f02fe52f35 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -454,6 +454,7 @@ menu "Firmware"
>  	source "package/qoriq-fm-ucode/Config.in"
>  	source "package/rcw-smarc-sal28/Config.in"
>  	source "package/rpi-firmware/Config.in"
> +	source "package/rpi-utils/Config.in"
>  	source "package/sunxi-boards/Config.in"
>  	source "package/ts4900-fpga/Config.in"
>  	source "package/ux500-firmware/Config.in"
> diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
> new file mode 100644
> index 0000000000..a2729167aa
> --- /dev/null
> +++ b/package/rpi-utils/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_RPI_UTILS
> +	bool "rpi-utils"

Since it's only usefull for rpi targets, you should keep the architecture
dependencies (at least):

	depends on BR2_arm || BR2_aarch64

Otherwise, it looks ok.

Best regards,
Romain


> +	depends on !BR2_STATIC_LIBS # dtc
> +	select BR2_PACKAGE_DTC
> +	help
> +	  A collection of scripts and simple applications for the
> +	  Raspberry Pi.
> +
> +	  https://github.com/raspberrypi/utils/
> +
> +comment "rpi-utils needs a toolchain w/ dynamic library"
> +	depends on BR2_STATIC_LIBS
> diff --git a/package/rpi-utils/rpi-utils.hash b/package/rpi-utils/rpi-utils.hash
> new file mode 100644
> index 0000000000..a6612373b0
> --- /dev/null
> +++ b/package/rpi-utils/rpi-utils.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  c35932e501b43e5fb48cfc488aadc4a8bbceb0e9e6dafdf6c7cd2066b58acd61  rpi-utils-a1d522f0f1b50858a44fac80523a2bd80098e789.tar.gz
> +sha256  731da956431d1a7c5073e7ee5ebe01f54e359c5339310b32f0893c6fe6507d5a  LICENCE
> diff --git a/package/rpi-utils/rpi-utils.mk b/package/rpi-utils/rpi-utils.mk
> new file mode 100644
> index 0000000000..49db3aef9f
> --- /dev/null
> +++ b/package/rpi-utils/rpi-utils.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# rpi-utils
> +#
> +################################################################################
> +
> +RPI_UTILS_VERSION = a1d522f0f1b50858a44fac80523a2bd80098e789
> +RPI_UTILS_SITE = $(call github,raspberrypi,utils,$(RPI_UTILS_VERSION))
> +RPI_UTILS_LICENSE = BSD-3-Clause
> +RPI_UTILS_LICENSE_FILES = LICENCE
> +RPI_UTILS_INSTALL_STAGING = YES
> +RPI_UTILS_DEPENDENCIES = dtc
> +
> +# Ensure the internal dtovl remains an archive object and it is not built as a
> +# dynamic library that is linked by other utilities; as it is not installed.
> +RPI_UTILS_CONF_OPTS = -DSTATIC=STATIC
> +
> +$(eval $(cmake-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 2/2] package/rpi-userland: package is deprecated

[Romain Naour via buildroot]

Hello Gaël, All,

Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
> The package rpi-userland has been marked as ancient and deprecated[1].
> 
> This adds the message in its help.
> 
> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
> 

With rpi-utils package enabled, we should avoid any conflict with this package.
They should not be enabled at the same time if they provide the same binaries etc.

Maybe it would be easier if rpi-userland can be removed?

Best regards,
Romain


> Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
> ---
>  package/rpi-userland/Config.in | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
> index 4219bdb9c4..c39eb4598f 100644
> --- a/package/rpi-userland/Config.in
> +++ b/package/rpi-userland/Config.in
> @@ -16,6 +16,17 @@ config BR2_PACKAGE_RPI_USERLAND
>  	  mmal, GLESv2, vcos, openmaxil, vchiq_arm, bcm_host, WFC,
>  	  OpenVG.
>  
> +	  Important: The package is ancient and deprecated.
> +
> +	  It largely contains code using proprietary APIs to interface
> +	  to the VideoCore firmware. It has since moved to standard
> +	  linux APIs.
> +
> +	  V4L2, DRM/KMS and Mesa are the APIs you should be using.
> +
> +	  The few useful tools from here (dtoverlay, dtmerge,
> +	  vcmailbox, vcgencmd) have been moved to the package rpi-utils.
> +
>  	  https://github.com/raspberrypi/userland/
>  
>  if BR2_PACKAGE_RPI_USERLAND && BR2_arm

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/2] package/rpi-utils: new package

[Gaël PORTAY]

Hello Romain,

On Wed Feb 5, 2025 at 9:44 AM CET, Romain Naour wrote:
> Hello Gaël, All,
>
> Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
>> The package rpi-userland has been marked as ancient and deprecated[1].
>> 
>> The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
>> the repository rpi-utils since then.
>> 
>> This adds the new package rpi-utils at latest commit as there is no
>> tagged commit.
>
> BR2_PACKAGE_RPI_USERLAND is used in several packages. Since rpi-utils should
> replace rpi-userland maybe it's time to also update theses packages?
>

Indeed, I should consider this; and I haven't yes look into them (i.e.
why the packages need rpi-userland).

> Did you consider not only deprecating rpi-userland but a complete replacement?
>

I have to check if I can replace it entirely.

The deprecated package still contain sources from various libraries,
including the GL backend used by raspberrypi3_qt5we_defconfig.

Normally, it should be replaced by mesa3d and its vc4 driver (that
requires NEON support in buildroot).

But the Raspberry Pi 1/Zero/Zero W to not have NEON support and thus,
rpi-userland is still required if one want to compile Qt5WebEngine for
Raspberry Pi 1/Zero/Zero W.

I guess the vc4 driver does not require support for NEON (v3d does);
IIRC, I can compile vc4 driver if I revert[1] (i.e. no build issue).

I will test to run qt5 opengl samples using mesa3d. And if I am able to
run them correctly, I will consider the full replacement (in the package
requiring it).

The work is still in progress on that part.

[1]: https://gitlab.com/buildroot.org/buildroot/-/commit/a5cdb54ed78b136c83dd44aebfa27f715cda5ea3

>> 
>> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
>> 
>> Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
>> Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
>> ---
>
> What happened since v3?
>

Changes since v3:
 - Update my e-mail
 - Rebase on master
 - Add Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

I have added these lines to the coverletter[2].

[2]: https://lore.kernel.org/buildroot/20250204173456.201056-1-gael.portay+rtone@gmail.com/

>> diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
>> new file mode 100644
>> index 0000000000..a2729167aa
>> --- /dev/null
>> +++ b/package/rpi-utils/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_RPI_UTILS
>> +	bool "rpi-utils"
>
> Since it's only usefull for rpi targets, you should keep the architecture
> dependencies (at least):
>
> 	depends on BR2_arm || BR2_aarch64
>
> Otherwise, it looks ok.
>

Make sense, I will added in v5.

> Best regards,
> Romain
>

Best Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 2/2] package/rpi-userland: package is deprecated

[Gaël PORTAY]

On Wed Feb 5, 2025 at 9:47 AM CET, Romain Naour wrote:
> Hello Gaël, All,
>
> Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
>> The package rpi-userland has been marked as ancient and deprecated[1].
>> 
>> This adds the message in its help.
>> 
>> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
>> 
>
> With rpi-utils package enabled, we should avoid any conflict with this package.
> They should not be enabled at the same time if they provide the same binaries etc.
>
> Maybe it would be easier if rpi-userland can be removed?
>

Indeed. If I can replace it entirelly, I will remove that package.

I still have some work to do for the GL part (check if I can run
mesa3d/vc4 on Raspberry Pi 1/Zero/Zero W, with the lack of neon).

By the way, what should I do to drop the package?
 - drop the package?
 - move it to legacy?

Thanks.

> Best regards,
> Romain
>

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/2] package/rpi-utils: new package

[Gaël PORTAY]

Hello Romain,

On Wed Feb 5, 2025 at 9:44 AM CET, Romain Naour wrote:
> Hello Gaël, All,
>
> Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
>> The package rpi-userland has been marked as ancient and deprecated[1].
>> 
>> The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
>> the repository rpi-utils since then.
>> 
>> This adds the new package rpi-utils at latest commit as there is no
>> tagged commit.
>
> BR2_PACKAGE_RPI_USERLAND is used in several packages. Since rpi-utils should
> replace rpi-userland maybe it's time to also update theses packages?
>

That is a good catch. But we cannot as rpi-utils does not provides all
the pieces that rpi-userland provides.

> Did you consider not only deprecating rpi-userland but a complete replacement?
>

And thus, the rpi-utils cannot replace entirelly rpi-userland.

So I guess, we should removes the binaries utilities provided by the new
package rpi-utils (dtoverlay, dtmerge, vcmailbox, vcgencmd) from the old
package rpi-userland. And thus, both packages can be installed at the
same time.

What do you think?

>> 
>> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
>> 
>> Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
>> Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
>> ---
>
> What happened since v3?
>

No big changes, it was in the coverletter:

Changes since v3:
 - Update my e-mail
 - Rebase on master
 - Add Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

>>  DEVELOPERS                       |  1 +
>>  package/Config.in                |  1 +
>>  package/rpi-utils/Config.in      | 12 ++++++++++++
>>  package/rpi-utils/rpi-utils.hash |  3 +++
>>  package/rpi-utils/rpi-utils.mk   | 18 ++++++++++++++++++
>>  5 files changed, 35 insertions(+)
>>  create mode 100644 package/rpi-utils/Config.in
>>  create mode 100644 package/rpi-utils/rpi-utils.hash
>>  create mode 100644 package/rpi-utils/rpi-utils.mk
>> 
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index 2da5d178b2..fc1ba2ab27 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -1203,6 +1203,7 @@ F:	package/nginx-modsecurity/
>>  N:	Gaël PORTAY <gael.portay+rtone@gmail.com>
>>  F:	board/raspberrypi/
>>  F:	configs/raspberrypi*
>> +F:	package/rpi-utils/
>>  
>>  N:	Gao Xiang <hsiangkao@aol.com>
>>  F:	package/erofs-utils/
>> diff --git a/package/Config.in b/package/Config.in
>> index e9c789cff2..f02fe52f35 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -454,6 +454,7 @@ menu "Firmware"
>>  	source "package/qoriq-fm-ucode/Config.in"
>>  	source "package/rcw-smarc-sal28/Config.in"
>>  	source "package/rpi-firmware/Config.in"
>> +	source "package/rpi-utils/Config.in"
>>  	source "package/sunxi-boards/Config.in"
>>  	source "package/ts4900-fpga/Config.in"
>>  	source "package/ux500-firmware/Config.in"
>> diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
>> new file mode 100644
>> index 0000000000..a2729167aa
>> --- /dev/null
>> +++ b/package/rpi-utils/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_RPI_UTILS
>> +	bool "rpi-utils"
>
> Since it's only usefull for rpi targets, you should keep the architecture
> dependencies (at least):
>
> 	depends on BR2_arm || BR2_aarch64
>
> Otherwise, it looks ok.
>

Makes sense.

> Best regards,
> Romain
>

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 2/2] package/rpi-userland: package is deprecated

[Gaël PORTAY]

Hello Romain,

On Wed Feb 5, 2025 at 9:47 AM CET, Romain Naour wrote:
> Hello Gaël, All,
>
> Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
>> The package rpi-userland has been marked as ancient and deprecated[1].
>> 
>> This adds the message in its help.
>> 
>> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
>> 
>
> With rpi-utils package enabled, we should avoid any conflict with this package.
> They should not be enabled at the same time if they provide the same binaries etc.
>

As said in the other patch, I guess that package should not provide the
binaries utils provided by the new package.

Just remove them. So both packages can be installed at the same time.

> Maybe it would be easier if rpi-userland can be removed?
>
> Best regards,
> Romain
>

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/2] package/rpi-utils: new package

[Romain Naour via buildroot]

Hello Gaël, All,

Le 20/05/2025 à 19:32, Gaël PORTAY a écrit :
> Hello Romain,
> 
> On Wed Feb 5, 2025 at 9:44 AM CET, Romain Naour wrote:
>> Hello Gaël, All,
>>
>> Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
>>> The package rpi-userland has been marked as ancient and deprecated[1].
>>>
>>> The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
>>> the repository rpi-utils since then.
>>>
>>> This adds the new package rpi-utils at latest commit as there is no
>>> tagged commit.
>>
>> BR2_PACKAGE_RPI_USERLAND is used in several packages. Since rpi-utils should
>> replace rpi-userland maybe it's time to also update theses packages?
>>
> 
> That is a good catch. But we cannot as rpi-utils does not provides all
> the pieces that rpi-userland provides.
> >> Did you consider not only deprecating rpi-userland but a complete replacement?
>>
> 
> And thus, the rpi-utils cannot replace entirelly rpi-userland.

What are the tools that have no replacement? is really an issue?

Upstream is doing a breaking change, we should not provide deprecated stuff forever.

> 
> So I guess, we should removes the binaries utilities provided by the new
> package rpi-utils (dtoverlay, dtmerge, vcmailbox, vcgencmd) from the old
> package rpi-userland. And thus, both packages can be installed at the
> same time.
> 
> What do you think?

Having both package rpi-utils and rpi-userland could be confusing but if there
is no other choice then it could be a compromise.

> 
>>>
>>> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
>>>
>>> Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
>>> Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
>>> ---
>>
>> What happened since v3?
>>
> 
> No big changes, it was in the coverletter:
> 
> Changes since v3:
>  - Update my e-mail
>  - Rebase on master
>  - Add Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

I missed the coverletter, from the patchwork interface you have to click on
"expand" to get the link to the cover letter:

https://patchwork.ozlabs.org/project/buildroot/patch/20250204173456.201056-2-gael.portay+rtone@gmail.com/

https://patchwork.ozlabs.org/project/buildroot/cover/20250204173456.201056-1-gael.portay+rtone@gmail.com/

I learned this tip from Arnout during the last meeting, so it's still new for me :)

Best regards,
Romain


> 
>>>  DEVELOPERS                       |  1 +
>>>  package/Config.in                |  1 +
>>>  package/rpi-utils/Config.in      | 12 ++++++++++++
>>>  package/rpi-utils/rpi-utils.hash |  3 +++
>>>  package/rpi-utils/rpi-utils.mk   | 18 ++++++++++++++++++
>>>  5 files changed, 35 insertions(+)
>>>  create mode 100644 package/rpi-utils/Config.in
>>>  create mode 100644 package/rpi-utils/rpi-utils.hash
>>>  create mode 100644 package/rpi-utils/rpi-utils.mk
>>>
>>> diff --git a/DEVELOPERS b/DEVELOPERS
>>> index 2da5d178b2..fc1ba2ab27 100644
>>> --- a/DEVELOPERS
>>> +++ b/DEVELOPERS
>>> @@ -1203,6 +1203,7 @@ F:	package/nginx-modsecurity/
>>>  N:	Gaël PORTAY <gael.portay+rtone@gmail.com>
>>>  F:	board/raspberrypi/
>>>  F:	configs/raspberrypi*
>>> +F:	package/rpi-utils/
>>>  
>>>  N:	Gao Xiang <hsiangkao@aol.com>
>>>  F:	package/erofs-utils/
>>> diff --git a/package/Config.in b/package/Config.in
>>> index e9c789cff2..f02fe52f35 100644
>>> --- a/package/Config.in
>>> +++ b/package/Config.in
>>> @@ -454,6 +454,7 @@ menu "Firmware"
>>>  	source "package/qoriq-fm-ucode/Config.in"
>>>  	source "package/rcw-smarc-sal28/Config.in"
>>>  	source "package/rpi-firmware/Config.in"
>>> +	source "package/rpi-utils/Config.in"
>>>  	source "package/sunxi-boards/Config.in"
>>>  	source "package/ts4900-fpga/Config.in"
>>>  	source "package/ux500-firmware/Config.in"
>>> diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
>>> new file mode 100644
>>> index 0000000000..a2729167aa
>>> --- /dev/null
>>> +++ b/package/rpi-utils/Config.in
>>> @@ -0,0 +1,12 @@
>>> +config BR2_PACKAGE_RPI_UTILS
>>> +	bool "rpi-utils"
>>
>> Since it's only usefull for rpi targets, you should keep the architecture
>> dependencies (at least):
>>
>> 	depends on BR2_arm || BR2_aarch64
>>
>> Otherwise, it looks ok.
>>
> 
> Makes sense.
> 
>> Best regards,
>> Romain
>>
> 
> Regards,
> Gaël

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot