From: "Vincent Stehlé" <vincent.stehle@arm.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/qemu_aarch64_ebbr: new defconfig
Date: Thu, 15 Sep 2022 17:06:10 +0200 [thread overview]
Message-ID: <YyM/Yo0pbi8QJpVo@debian> (raw)
In-Reply-To: <7581ed17-0768-c255-78ea-d2164fa0e0fc@gmail.com>
On Wed, Sep 14, 2022 at 10:49:36PM +0200, Romain Naour wrote:
> Hello Vincent,
>
> Le 14/09/2022 à 16:08, Vincent Stehlé a écrit :
..
> > I would prefer to add my work e-mail in DEVELOPERS for this defconfig.
> > Please let me know if this is ok or if I should keep a single e-mail
> > address.
> > Thanks!
>
> I'm ok with that.
Hi Romain,
Thank you for the confirmation.
..
> > + partition boot {
> > + image = "efi-part.vfat"
> > + partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
>
> You can replace this line by:
> partition-type-uuid = U
>
> See:
> https://git.buildroot.net/buildroot/commit/?id=025d8ac80d06ad46ec3042c4af85ddd6a5e09b80
Ok, will do.
..
> > +# Toolchain, required for GRUB
> > +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>
> The new default libc is now glibc on the current master branch, so you can drop
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
Ok, will do.
>
> Otherwise:
> Reviewed-by: Romain Naour <romain.naour@gmail.com>
Thank you!
I will send a v2.
Best regards,
Vincent.
>
> Best regards,
> Romain
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-15 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 14:08 [Buildroot] [PATCH] configs/qemu_aarch64_ebbr: new defconfig Vincent Stehlé
2022-09-14 20:25 ` Giulio Benetti
2022-09-15 15:03 ` Vincent Stehlé
2022-09-15 19:07 ` Giulio Benetti
2022-09-16 7:29 ` Vincent Stehlé
2022-09-14 20:49 ` Romain Naour
2022-09-15 15:06 ` Vincent Stehlé [this message]
2022-09-16 7:41 ` [Buildroot] [PATCH v2] " Vincent Stehlé
2022-10-31 12:07 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyM/Yo0pbi8QJpVo@debian \
--to=vincent.stehle@arm.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox