Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vincent Stehlé" <vincent.stehle@arm.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Romain Naour <romain.naour@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/qemu_aarch64_ebbr: new defconfig
Date: Fri, 16 Sep 2022 09:29:49 +0200	[thread overview]
Message-ID: <YyQl7euXmtQsB4+2@debian> (raw)
In-Reply-To: <c3cc6951-4e49-4da2-b5f5-7dd5523a3c5f@benettiengineering.com>

On Thu, Sep 15, 2022 at 09:07:19PM +0200, Giulio Benetti wrote:
..
> > > > +	partition root {
> > > > +		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
> > > 
> > > Here ^^^ instead is correct according to Buildroot manual.
> > > You can check it on following link:
> > > https://buildroot.org/downloads/manual/manual.html#writing-genimage-cfg
> > 
> > On second thought I think I might as well not specify the uuid at all and rely
> > on the default being 'L'.
> 
> No, as stated in Buildroot manual[0]:
> "Even though L is the default value of genimage, we prefer to have it
> explicitly specified in our genimage.cfg files"
> So you should specify the partition-type-uuid =
> b921b045-1df0-41c3-af44-4c6f280d3fae as it is now.

Hi Giulio,

Ok, I will leave it "as is".

..
> > Thank you for testing!
> 
> You're welcome and so with all the corrected points:
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>>

Thank you!

Best regards,
Vincent.

> Best regards!
> -- 
> Giulio Benetti
> Benetti Engineering sas
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-16  7:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 14:08 [Buildroot] [PATCH] configs/qemu_aarch64_ebbr: new defconfig Vincent Stehlé
2022-09-14 20:25 ` Giulio Benetti
2022-09-15 15:03   ` Vincent Stehlé
2022-09-15 19:07     ` Giulio Benetti
2022-09-16  7:29       ` Vincent Stehlé [this message]
2022-09-14 20:49 ` Romain Naour
2022-09-15 15:06   ` Vincent Stehlé
2022-09-16  7:41 ` [Buildroot] [PATCH v2] " Vincent Stehlé
2022-10-31 12:07   ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyQl7euXmtQsB4+2@debian \
    --to=vincent.stehle@arm.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox