Re: [Buildroot] [PATCH] configs/qemu_aarch64_ebbr: new defconfig

["Vincent Stehlé" <vincent.stehle@arm.com>]

On Wed, Sep 14, 2022 at 10:25:15PM +0200, Giulio Benetti wrote:
> Hi Vincent,

Hi Giulio,

Thank you for the review. More comments below, but I would like to ask already:
shall I add your "reviewed-by" when I send a v2, please?

> On 14/09/22 16:08, Vincent Stehlé wrote:
..
> > I would prefer to add my work e-mail in DEVELOPERS for this defconfig.
> > Please let me know if this is ok or if I should keep a single e-mail
> > address.
> 
> It is possible, there is a pending patch exactly for this:
> https://patchwork.ozlabs.org/project/buildroot/patch/7149_1663079883_632095CB_7149_153_1_84f14454278c823f23654b20e44af7dc646b6fdd.1663079879.git.yann.morin@orange.com/
> and comes from one of the maintainers.

Thanks for the confirmation.

..
> > +	partition boot {
> > +		image = "efi-part.vfat"
> > +		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
> 
> Here ^^^ it's been decided to use genimage shortcut letters, in this case U
> since it's EFI.

Ok, will do.

> > +		offset = 32K
> > +		bootable = true
> > +	}
> > +
> > +	partition root {
> > +		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
> 
> Here ^^^ instead is correct according to Buildroot manual.
> You can check it on following link:
> https://buildroot.org/downloads/manual/manual.html#writing-genimage-cfg

On second thought I think I might as well not specify the uuid at all and rely
on the default being 'L'.

..
> > +# Toolchain, required for GRUB
> > +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> 
> This ^^^ is only needed for uclibc, but the default libc now is glibc,
> so you don't need to specify it.

Ok, will remove.

..
> > +# Linux headers
> > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_17=y
> 
> For this ^^^ please specify in commit log that at the moment we don't
> have 5.19 headers available and so we rely on 5.17.

Ok, will do.

..
> It builds fine using utils/docker-run and I've run it successfully with
> qemu.

Thank you for testing!

Best regards,
Vincent.

> So I wait for V2.
> 
> Thank you!
> 
> Best regards
> -- 
> Giulio Benetti
> Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot