[Buildroot] [PATCH] package/zfs: fix autotools crosscompilations

[Buildroot] [PATCH] package/zfs: fix autotools crosscompilations

[José Luis Salvador Rufo]

Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
---
 package/zfs/zfs.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
index 97e9442cf8..e99413e611 100644
--- a/package/zfs/zfs.mk
+++ b/package/zfs/zfs.mk
@@ -58,6 +58,14 @@ else
 ZFS_CONF_OPTS += --disable-pam
 endif
 
+# Sets the environment for the `make` that will be run ZFS autotools checks.
+ZFS_CONF_ENV += \
+	ARCH=$(KERNEL_ARCH) \
+	CROSS_COMPILE="$(TARGET_CROSS)"
+ZFS_MAKE_ENV += \
+	ARCH=$(KERNEL_ARCH) \
+	CROSS_COMPILE="$(TARGET_CROSS)"
+
 # ZFS userland tools are unfunctional without the Linux kernel modules.
 ZFS_MODULE_SUBDIRS = \
 	module/avl \
-- 
2.41.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/zfs: fix autotools crosscompilations

[Alexander Mukhin]

José,

I am glad to confirm that your patch fixes the issue. Tested on:

Host:
Debian 11.7 x86-64

Toolchains:
x86-64--glibc--bleeding-edge-2022.08
armv6-eabihf--glibc--bleeding-edge-2022.08

Thank you!

-- 
Alexander.

On Thu, Jun 08, 2023 at 07:55:38PM +0200, José Luis Salvador Rufo wrote:
> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> ---
>  package/zfs/zfs.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
> index 97e9442cf8..e99413e611 100644
> --- a/package/zfs/zfs.mk
> +++ b/package/zfs/zfs.mk
> @@ -58,6 +58,14 @@ else
>  ZFS_CONF_OPTS += --disable-pam
>  endif
>  
> +# Sets the environment for the `make` that will be run ZFS autotools checks.
> +ZFS_CONF_ENV += \
> +	ARCH=$(KERNEL_ARCH) \
> +	CROSS_COMPILE="$(TARGET_CROSS)"
> +ZFS_MAKE_ENV += \
> +	ARCH=$(KERNEL_ARCH) \
> +	CROSS_COMPILE="$(TARGET_CROSS)"
> +
>  # ZFS userland tools are unfunctional without the Linux kernel modules.
>  ZFS_MODULE_SUBDIRS = \
>  	module/avl \
> -- 
> 2.41.0
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/zfs: fix autotools crosscompilations

[Arnout Vandecappelle via buildroot]

On 09/06/2023 21:05, Alexander Mukhin wrote:
> José,
> 
> I am glad to confirm that your patch fixes the issue. Tested on:
> 
> Host:
> Debian 11.7 x86-64
> 
> Toolchains:
> x86-64--glibc--bleeding-edge-2022.08
> armv6-eabihf--glibc--bleeding-edge-2022.08 >
> Thank you!
> 
> -- 
> Alexander.
> 

  Hi Alexander,

  Thank you for this test. In the future, please add the following tag 
(preferably below the signed-off-by, like I do below).

> On Thu, Jun 08, 2023 at 07:55:38PM +0200, José Luis Salvador Rufo wrote:
>> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>

Tested-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>

(and put the details about how you tested below that).

This gets picked up by patchwork and:

- adds to the T column in the patchwork overview, so we can see at a glance that 
it's a patch that has been tested by someone;
- becomes part of the commit message when applying to the mainline tree, so if 
there's a problem later we can easily see in history that you originally tested 
it. Also, that way Peter can give you credit in the release notes.

  Regards,
  Arnout

>> ---
>>  package/zfs/zfs.mk | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
>> index 97e9442cf8..e99413e611 100644
>> --- a/package/zfs/zfs.mk
>> +++ b/package/zfs/zfs.mk
>> @@ -58,6 +58,14 @@ else
>>  ZFS_CONF_OPTS += --disable-pam
>>  endif
>>  
>> +# Sets the environment for the `make` that will be run ZFS autotools checks.
>> +ZFS_CONF_ENV += \
>> +	ARCH=$(KERNEL_ARCH) \
>> +	CROSS_COMPILE="$(TARGET_CROSS)"
>> +ZFS_MAKE_ENV += \
>> +	ARCH=$(KERNEL_ARCH) \
>> +	CROSS_COMPILE="$(TARGET_CROSS)"
>> +
>>  # ZFS userland tools are unfunctional without the Linux kernel modules.
>>  ZFS_MODULE_SUBDIRS = \
>>  	module/avl \
>> -- 
>> 2.41.0
>>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/zfs: fix autotools crosscompilations

[Thomas Petazzoni via buildroot]

Hello José,

On Thu,  8 Jun 2023 19:55:38 +0200
José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:

> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>

Thanks for the contribution, but unfortunately we cannot apply this
patch: it does not explain anything about which "autotools
crosscompilations" issues it is fixing. Are these failures visible in
the autobuilders? If so, what link? If not, what configuration/setup
exhibits the problem, what is the error message, how does the patch fix
the issue?

Could you send an updated patch with a non-empty commit log that
contains a sufficient amount of detail for us to properly
review/understand the change?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH] package/zfs: fix zfs autotools cross-compilation

[José Luis Salvador Rufo]

This commit addresses a long-standing bug encountered during ZFS
compilation in cross-platform environments. The issue arises because ZFS
autoconf triggers a `make modules` to detect if the kernel can compile
modules [1]. The problem occurs when autoconf uses the host environment
instead of the cross-platform environment.

To fix this, we export necessary environment variables to ensure that ZFS
autoconf utilizes the cross-platform environment correctly.

This patch resolves ZFS cross-platform compilations:
- http://autobuild.buildroot.net/results/ebeab256101bcba38c35fd55075c414e62f92caa/
- http://autobuild.buildroot.net/results/03b9f12a106bf100eec695a92b83bf09b22c68b0/
- http://autobuild.buildroot.net/results/c2da90337463607c2fadfeac7ad72e5c3899a61f/
- http://autobuild.buildroot.net/results/465a249f92d2f5db7ac4b61b4111e6cbaaa15688/
- http://autobuild.buildroot.net/results/7e2d3277e26fa5b0c8073a0e8b9e82f47ade9697/
- http://autobuild.buildroot.net/results/a8fb87336b09fef8787a7889dfcccf14fe1215b9/
- https://gitlab.com/kubu93/buildroot/-/jobs/1522848483

And fix a few emails:
- alpine.DEB.2.22.394.2108181630280.2028262@ridzo [build zfs into buildroot for raspberry pi 4]
- https://lists.buildroot.org/pipermail/buildroot/2021-August/621696.html
- https://lists.buildroot.org/pipermail/buildroot/2021-August/621345.html
- https://lists.buildroot.org/pipermail/buildroot/2022-July/646379.html
- https://lists.buildroot.org/pipermail/buildroot/2023-June/668467.html

[1] This is the full callback, you can just check the last link:
- https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel-declare-event-class.m4#L7C11-L7C11
- https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L883
- https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L868
- https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L668

Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
---
 package/zfs/zfs.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
index f0461ea9ec..ab530cbcf0 100644
--- a/package/zfs/zfs.mk
+++ b/package/zfs/zfs.mk
@@ -59,6 +59,14 @@ else
 ZFS_CONF_OPTS += --disable-pam
 endif
 
+# Sets the environment for the `make` that will be run ZFS autotools checks.
+ZFS_CONF_ENV += \
+	ARCH=$(KERNEL_ARCH) \
+	CROSS_COMPILE="$(TARGET_CROSS)"
+ZFS_MAKE_ENV += \
+	ARCH=$(KERNEL_ARCH) \
+	CROSS_COMPILE="$(TARGET_CROSS)"
+
 # ZFS userland tools are unfunctional without the Linux kernel modules.
 ZFS_MODULE_SUBDIRS = \
 	module/avl \
-- 
2.42.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/zfs: fix zfs autotools cross-compilation

[Yann E. MORIN]

José, All,

On 2023-11-12 23:11 +0100, José Luis Salvador Rufo spake thusly:
> This commit addresses a long-standing bug encountered during ZFS
> compilation in cross-platform environments. The issue arises because ZFS
> autoconf triggers a `make modules` to detect if the kernel can compile
> modules [1]. The problem occurs when autoconf uses the host environment
> instead of the cross-platform environment.
> 
> To fix this, we export necessary environment variables to ensure that ZFS
> autoconf utilizes the cross-platform environment correctly.
> 
> This patch resolves ZFS cross-platform compilations:
> - http://autobuild.buildroot.net/results/ebeab256101bcba38c35fd55075c414e62f92caa/
> - http://autobuild.buildroot.net/results/03b9f12a106bf100eec695a92b83bf09b22c68b0/
> - http://autobuild.buildroot.net/results/c2da90337463607c2fadfeac7ad72e5c3899a61f/
> - http://autobuild.buildroot.net/results/465a249f92d2f5db7ac4b61b4111e6cbaaa15688/
> - http://autobuild.buildroot.net/results/7e2d3277e26fa5b0c8073a0e8b9e82f47ade9697/
> - http://autobuild.buildroot.net/results/a8fb87336b09fef8787a7889dfcccf14fe1215b9/
> - https://gitlab.com/kubu93/buildroot/-/jobs/1522848483
> 
> And fix a few emails:
> - alpine.DEB.2.22.394.2108181630280.2028262@ridzo [build zfs into buildroot for raspberry pi 4]
> - https://lists.buildroot.org/pipermail/buildroot/2021-August/621696.html
> - https://lists.buildroot.org/pipermail/buildroot/2021-August/621345.html
> - https://lists.buildroot.org/pipermail/buildroot/2022-July/646379.html
> - https://lists.buildroot.org/pipermail/buildroot/2023-June/668467.html
> 
> [1] This is the full callback, you can just check the last link:
> - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel-declare-event-class.m4#L7C11-L7C11
> - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L883
> - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L868
> - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L668
> 
> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/zfs/zfs.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
> index f0461ea9ec..ab530cbcf0 100644
> --- a/package/zfs/zfs.mk
> +++ b/package/zfs/zfs.mk
> @@ -59,6 +59,14 @@ else
>  ZFS_CONF_OPTS += --disable-pam
>  endif
>  
> +# Sets the environment for the `make` that will be run ZFS autotools checks.
> +ZFS_CONF_ENV += \
> +	ARCH=$(KERNEL_ARCH) \
> +	CROSS_COMPILE="$(TARGET_CROSS)"
> +ZFS_MAKE_ENV += \
> +	ARCH=$(KERNEL_ARCH) \
> +	CROSS_COMPILE="$(TARGET_CROSS)"
> +
>  # ZFS userland tools are unfunctional without the Linux kernel modules.
>  ZFS_MODULE_SUBDIRS = \
>  	module/avl \
> -- 
> 2.42.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/zfs: fix zfs autotools cross-compilation

[Peter Korsgaard]

>>>>> "José" == José Luis Salvador Rufo <salvador.joseluis@gmail.com> writes:

 > This commit addresses a long-standing bug encountered during ZFS
 > compilation in cross-platform environments. The issue arises because ZFS
 > autoconf triggers a `make modules` to detect if the kernel can compile
 > modules [1]. The problem occurs when autoconf uses the host environment
 > instead of the cross-platform environment.

 > To fix this, we export necessary environment variables to ensure that ZFS
 > autoconf utilizes the cross-platform environment correctly.

 > This patch resolves ZFS cross-platform compilations:
 > - http://autobuild.buildroot.net/results/ebeab256101bcba38c35fd55075c414e62f92caa/
 > - http://autobuild.buildroot.net/results/03b9f12a106bf100eec695a92b83bf09b22c68b0/
 > - http://autobuild.buildroot.net/results/c2da90337463607c2fadfeac7ad72e5c3899a61f/
 > - http://autobuild.buildroot.net/results/465a249f92d2f5db7ac4b61b4111e6cbaaa15688/
 > - http://autobuild.buildroot.net/results/7e2d3277e26fa5b0c8073a0e8b9e82f47ade9697/
 > - http://autobuild.buildroot.net/results/a8fb87336b09fef8787a7889dfcccf14fe1215b9/
 > - https://gitlab.com/kubu93/buildroot/-/jobs/1522848483

 > And fix a few emails:
 > - alpine.DEB.2.22.394.2108181630280.2028262@ridzo [build zfs into buildroot for raspberry pi 4]
 > - https://lists.buildroot.org/pipermail/buildroot/2021-August/621696.html
 > - https://lists.buildroot.org/pipermail/buildroot/2021-August/621345.html
 > - https://lists.buildroot.org/pipermail/buildroot/2022-July/646379.html
 > - https://lists.buildroot.org/pipermail/buildroot/2023-June/668467.html

 > [1] This is the full callback, you can just check the last link:
 > - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel-declare-event-class.m4#L7C11-L7C11
 > - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L883
 > - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L868
 > - https://github.com/openzfs/zfs/blob/zfs-2.1.12/config/kernel.m4#L668

 > Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/zfs: fix autotools crosscompilations

[José Luis Salvador Rufo]

[-- Attachment #1.1: Type: text/plain, Size: 1187 bytes --]

Hello Thomas,

Here is the same patch but with some explanation:
https://patchwork.ozlabs.org/project/buildroot/patch/20231112221115.2289525-3-salvador.joseluis@gmail.com/

Greetings.

El mié, 26 jul 2023 a las 23:30, Thomas Petazzoni (<
thomas.petazzoni@bootlin.com>) escribió:

> Hello José,
>
> On Thu,  8 Jun 2023 19:55:38 +0200
> José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
>
> > Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
>
> Thanks for the contribution, but unfortunately we cannot apply this
> patch: it does not explain anything about which "autotools
> crosscompilations" issues it is fixing. Are these failures visible in
> the autobuilders? If so, what link? If not, what configuration/setup
> exhibits the problem, what is the error message, how does the patch fix
> the issue?
>
> Could you send an updated patch with a non-empty commit log that
> contains a sufficient amount of detail for us to properly
> review/understand the change?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 1924 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot