[Buildroot] [PATCH] package/ntpsec: fix compile issue for some toolchains

[Buildroot] [PATCH] package/ntpsec: fix compile issue for some toolchains

[Waldemar Brodkorb]

Ntpsec unconditionally uses PIE to compile code.
This breaks compilation for at least microblaze-uclibc and
m68k-uclibc toolchains.

It would be better to add a configure option to allow to disable pie support,
but this is something for an waf expert.

When accepted, should be backported to older releases of Buildroot.

Fixes:
 - http://autobuild.buildroot.net/results/77f/77f4e4065874d022a2ae98d82508242f551e224c
 - http://autobuild.buildroot.net/results/e45/e45b65f2aa323df075d54ff43b0401b5ac7c6eb5

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/ntpsec/0003-disable-PIE-support.patch | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/ntpsec/0003-disable-PIE-support.patch

diff --git a/package/ntpsec/0003-disable-PIE-support.patch b/package/ntpsec/0003-disable-PIE-support.patch
new file mode 100644
index 0000000000..64eb559de0
--- /dev/null
+++ b/package/ntpsec/0003-disable-PIE-support.patch
@@ -0,0 +1,26 @@
+From 712675fbd2a736df817fecd7bfb39055946ef85b Mon Sep 17 00:00:00 2001
+From: Waldemar Brodkorb <wbx@openadk.org>
+Date: Sun, 13 Aug 2023 13:48:03 +0200
+Subject: [PATCH] disable PIE support
+
+Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
+Upstream: N/A Not upstreamable
+---
+ wscript | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/wscript b/wscript
+index 292e3a45b..105c7eac2 100644
+--- a/wscript
++++ b/wscript
+@@ -299,7 +299,6 @@ def configure(ctx):
+ 
+     cc_test_flags = [
+         ('PIC', '-fPIC'),
+-        ('PIE', '-pie -fPIE'),
+         # this quiets most of macOS warnings on -fpie
+         ('unused', '-Qunused-arguments'),
+         # This is a useless warning on any architecture with a barrel
+-- 
+2.39.2
+
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/ntpsec: fix compile issue for some toolchains

[Arnout Vandecappelle via buildroot]

On 13/08/2023 19:43, Waldemar Brodkorb wrote:
> Ntpsec unconditionally uses PIE to compile code.
> This breaks compilation for at least microblaze-uclibc and
> m68k-uclibc toolchains.

  Also, in Buildroot we anyway have BR2_PIC_PIE to handle this appropriately 
according to toolchain capabilities.

> 
> It would be better to add a configure option to allow to disable pie support,
> but this is something for an waf expert.
> 
> When accepted, should be backported to older releases of Buildroot.
> 
> Fixes:
>   - http://autobuild.buildroot.net/results/77f/77f4e4065874d022a2ae98d82508242f551e224c
>   - http://autobuild.buildroot.net/results/e45/e45b65f2aa323df075d54ff43b0401b5ac7c6eb5
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/ntpsec/0003-disable-PIE-support.patch | 26 +++++++++++++++++++
>   1 file changed, 26 insertions(+)
>   create mode 100644 package/ntpsec/0003-disable-PIE-support.patch
> 
> diff --git a/package/ntpsec/0003-disable-PIE-support.patch b/package/ntpsec/0003-disable-PIE-support.patch
> new file mode 100644
> index 0000000000..64eb559de0
> --- /dev/null
> +++ b/package/ntpsec/0003-disable-PIE-support.patch
> @@ -0,0 +1,26 @@
> +From 712675fbd2a736df817fecd7bfb39055946ef85b Mon Sep 17 00:00:00 2001
> +From: Waldemar Brodkorb <wbx@openadk.org>
> +Date: Sun, 13 Aug 2023 13:48:03 +0200
> +Subject: [PATCH] disable PIE support
> +
> +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> +Upstream: N/A Not upstreamable
> +---
> + wscript | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/wscript b/wscript
> +index 292e3a45b..105c7eac2 100644
> +--- a/wscript
> ++++ b/wscript
> +@@ -299,7 +299,6 @@ def configure(ctx):
> +
> +     cc_test_flags = [
> +         ('PIC', '-fPIC'),
> +-        ('PIE', '-pie -fPIE'),
> +         # this quiets most of macOS warnings on -fpie
> +         ('unused', '-Qunused-arguments'),
> +         # This is a useless warning on any architecture with a barrel
> +--
> +2.39.2
> +
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/ntpsec: fix compile issue for some toolchains

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:

 > On 13/08/2023 19:43, Waldemar Brodkorb wrote:
 >> Ntpsec unconditionally uses PIE to compile code.
 >> This breaks compilation for at least microblaze-uclibc and
 >> m68k-uclibc toolchains.

 >  Also, in Buildroot we anyway have BR2_PIC_PIE to handle this
 >  appropriately according to toolchain capabilities.

 >> It would be better to add a configure option to allow to disable pie
 >> support,
 >> but this is something for an waf expert.
 >> When accepted, should be backported to older releases of Buildroot.
 >> Fixes:
 >> - http://autobuild.buildroot.net/results/77f/77f4e4065874d022a2ae98d82508242f551e224c
 >> - http://autobuild.buildroot.net/results/e45/e45b65f2aa323df075d54ff43b0401b5ac7c6eb5
 >> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

 >  Applied to master, thanks.

Committed to 2024.02.x and 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot