Re: [Buildroot] [PATCH v3 06/11] package/flutter-pi: add the charset converter plugin as a menuconfig option

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

On 2024-01-02 16:59 -0700, Adam Duskett spake thusly:
> Commit 6a28738 introduces the charset_converter, which is a platform-side
> implementation of the charset_converter plugin found here:
> https://pub.dev/packages/charset_converter
> 
> The charset_converter plugin does the following:
> ```
> Encode and decode charsets using platform built-in converter.
> This plugin saves app package size as you don't need external charset maps or
> whole libraries like iconv. This package doesn't even contain any Dart
> dependencies. However, this comes with the dependency on the platform.
> ```

I moved the description to the help text, so that users have a bit more
details to decide whether to enable it or not.

>   - Remove -DBUILD_CHARSET_CONVERTER_PLUGIN=OFF as the default in
>     FLUTTER_PI_CONF_OPTS.
> 
>   - Add a new Menuconfig option BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
>     with a brief description about the new plugin and a link to the plugin that
>     provides a full explination.
> 
>   - Add logic around the BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN option
>     to enable or disable the plugin if selected or not.

This commit log is otherwise just descriptive of the change, not
explanatory, but there's not much to explain, and the title text (which
I slightly reworded) says it all, so that's fine to have  mostly empty
commit log sometimes. ;-)

> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/flutter-pi/Config.in     | 7 +++++++
>  package/flutter-pi/flutter-pi.mk | 7 ++++++-
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
> index ecebfad89b..45b6b4faef 100644
> --- a/package/flutter-pi/Config.in
> +++ b/package/flutter-pi/Config.in
> @@ -23,6 +23,13 @@ if BR2_PACKAGE_FLUTTER_PI
>  
>  comment "plugins"
>  
> +config BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
> +	bool "charset converter"
> +	help
> +	  Adds platform-side implementation of charset_converter plugin.
> +
> +	  See: https://pub.dev/packages/charset_converter
> +
>  config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
>  	bool "gstreamer audio player"
>  	depends on BR2_PACKAGE_HAS_LIBGLES
> diff --git a/package/flutter-pi/flutter-pi.mk b/package/flutter-pi/flutter-pi.mk
> index 4ec89bdfad..ab640d704a 100644
> --- a/package/flutter-pi/flutter-pi.mk
> +++ b/package/flutter-pi/flutter-pi.mk
> @@ -27,7 +27,6 @@ FLUTTER_PI_CONF_OPTS = \
>  	-DENABLE_VULKAN=OFF \
>  	-DFILESYSTEM_LAYOUT=meta-flutter \
>  	-DLINT_EGL_HEADERS=OFF \
> -	-DBUILD_CHARSET_CONVERTER_PLUGIN=OFF \
>  	-DTRY_BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN=OFF \
>  	-DTRY_BUILD_GSTREAMER_VIDEO_PLAYER_PLUGIN=OFF \
>  	-DTRY_ENABLE_OPENGL=OFF \
> @@ -43,6 +42,12 @@ else
>  FLUTTER_PI_CONF_OPTS += -DLTO=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN),y)
> +FLUTTER_PI_CONF_OPTS += -DBUILD_CHARSET_CONVERTER_PLUGIN=ON
> +else
> +FLUTTER_PI_CONF_OPTS += -DBUILD_CHARSET_CONVERTER_PLUGIN=OFF
> +endif
> +
>  ifeq ($(BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN),y)
>  FLUTTER_PI_DEPENDENCIES += gstreamer1 gst1-plugins-base
>  FLUTTER_PI_CONF_OPTS += -DBUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN=ON
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot