Re: [Buildroot] [PATCH v3 08/11] package/flutter-sdk-bin: add dart arguments for different runtime modes

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

On 2024-01-02 16:59 -0700, Adam Duskett spake thusly:
> Now that profile mode is an option for the flutter-engine package, the logic
> in package/flutter-sdk-bin/flutter-sdk-bin.mk is no longer sufficient.
> 
> Add an ifeq statement for FLUTTER_ENGINE_RUNTIME_MODE_PROFILE and set the
> following logic, borrowed from
> https://github.com/meta-flutter/meta-flutter/blob/kirkstone/conf/include/flutter-app.inc#L239

This file no longer has 239 lines today (as of commit 86ab854), as it
seems it was exploded into a few files at least. So I changed the URL
to just point to the directory, not to a specific file and line.

> ```
> HOST_FLUTTER_SDK_BIN_PROFILE_FLAGS = --track-widget-creation
> HOST_FLUTTER_SDK_BIN_SDK_VM_PROFILE = true
> ```
> 
> The FLUTTER_ENGINE_RUNTIME_MODE_PROFILE also sets
> HOST_FLUTTER_SDK_BIN_SDK_PRODUCT to false, and the
> HOST_FLUTTER_SDK_BIN_SDK_ROOT to
> $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk. Which is the
> same as Debug mode.
> 
> The -Ddart.vm.profile option is no longer hard coded to false and is set to
> the value of the HOST_FLUTTER_SDK_BIN_SDK_VM_PROFILE variable.
> 
> Finally, add the following new variables to HOST_FLUTTER_SDK_BIN_DART_ARGS:
>   - HOST_FLUTTER_SDK_BIN_DEBUG_FLAGS
>   - HOST_FLUTTER_SDK_BIN_PROFILE_FLAGS

This commit log is too descriptive, when we need explanations. I've
reworded and elided parts of it.

> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/flutter-sdk-bin/flutter-sdk-bin.mk | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/package/flutter-sdk-bin/flutter-sdk-bin.mk b/package/flutter-sdk-bin/flutter-sdk-bin.mk
> index a28cf645f3..e7fd09cb56 100644
> --- a/package/flutter-sdk-bin/flutter-sdk-bin.mk
> +++ b/package/flutter-sdk-bin/flutter-sdk-bin.mk
> @@ -55,13 +55,20 @@ define HOST_FLUTTER_SDK_BIN_INSTALL_CMDS
>  endef
>  
>  ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y)
> -HOST_FLUTTER_SDK_BIN_SDK_ROOT = \
> -	$(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk
> +HOST_FLUTTER_SDK_BIN_DEBUG_FLAGS = --enable-asserts
>  HOST_FLUTTER_SDK_BIN_SDK_PRODUCT = false
> +HOST_FLUTTER_SDK_BIN_SDK_ROOT = $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk

The debug block was not defining _SDK_VM_PROFILE, which would have
passed a -Ddart.vm.profile=  (i.e. nothing right of the equal sign).

I've added an assignment to =false.

> +else ifeq ($(FLUTTER_ENGINE_RUNTIME_MODE_PROFILE),y)
> +HOST_FLUTTER_SDK_BIN_PROFILE_FLAGS = --track-widget-creation
> +HOST_FLUTTER_SDK_BIN_SDK_PRODUCT = false
> +HOST_FLUTTER_SDK_BIN_SDK_ROOT = $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk
> +HOST_FLUTTER_SDK_BIN_SDK_VM_PROFILE = true
>  else
> -HOST_FLUTTER_SDK_BIN_SDK_ROOT = \
> -	$(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk_product
> +HOST_FLUTTER_SDK_BIN_DEBUG_FLAGS =
> +HOST_FLUTTER_SDK_BIN_PROFILE_FLAGS =

No need to set variables to an empty string; unset variables in make
evealuate to the empty string (and notice how you did not set
_DEBUG_FLAGS in the profile bock, or _PROFILE_FLAGS in the debug block
either). I droipped that when applying.

>  HOST_FLUTTER_SDK_BIN_SDK_PRODUCT = true
> +HOST_FLUTTER_SDK_BIN_SDK_ROOT = $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk_product
> +HOST_FLUTTER_SDK_BIN_SDK_VM_PROFILE = false
>  endif

As discussed elsewhere in the thread, I've also swapped the debug and
profiel cases, so that profile wins onver debug.

Applied to master with the above fixes, thanks.

Regards,
Yann E. MORIN.

>  # The Order matters.Taken from:
> @@ -73,8 +80,10 @@ HOST_FLUTTER_SDK_BIN_DART_ARGS = \
>  	--sdk-root $(HOST_FLUTTER_SDK_BIN_SDK_ROOT) \
>  	--target=flutter \
>  	--no-print-incremental-dependencies \
> -	-Ddart.vm.profile=false \
> +	-Ddart.vm.profile=$(HOST_FLUTTER_SDK_BIN_SDK_VM_PROFILE) \
>  	-Ddart.vm.product=$(HOST_FLUTTER_SDK_BIN_SDK_PRODUCT) \
> +	$(HOST_FLUTTER_SDK_BIN_DEBUG_FLAGS) \
> +	$(HOST_FLUTTER_SDK_BIN_PROFILE_FLAGS) \
>  	--aot \
>  	--tfa \
>  	--target-os linux \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot