Re: [Buildroot] [PATCH v3 08/11] package/flutter-sdk-bin: add dart arguments for different runtime modes

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

On 2024-01-11 12:40 -0700, Adam Duskett spake thusly:
> On Thu, Jan 11, 2024 at 11:49 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2024-01-02 16:59 -0700, Adam Duskett spake thusly:
> > > Now that profile mode is an option for the flutter-engine package, the logic
> > > in package/flutter-sdk-bin/flutter-sdk-bin.mk is no longer sufficient.
[--SNIP--]
> > >  ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y)
> > > -HOST_FLUTTER_SDK_BIN_SDK_ROOT = \
> > > -     $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk
> > > +HOST_FLUTTER_SDK_BIN_DEBUG_FLAGS = --enable-asserts
> > >  HOST_FLUTTER_SDK_BIN_SDK_PRODUCT = false
> > > +HOST_FLUTTER_SDK_BIN_SDK_ROOT = $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk
> > > +else ifeq ($(FLUTTER_ENGINE_RUNTIME_MODE_PROFILE),y)
> > > +HOST_FLUTTER_SDK_BIN_PROFILE_FLAGS = --track-widget-creation
> > > +HOST_FLUTTER_SDK_BIN_SDK_PRODUCT = false
> > > +HOST_FLUTTER_SDK_BIN_SDK_ROOT = $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk
> > > +HOST_FLUTTER_SDK_BIN_SDK_VM_PROFILE = true
> > >  else
> > > -HOST_FLUTTER_SDK_BIN_SDK_ROOT = \
> > > -     $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk_product
> > > +HOST_FLUTTER_SDK_BIN_DEBUG_FLAGS =
> > > +HOST_FLUTTER_SDK_BIN_PROFILE_FLAGS =
> > >  HOST_FLUTTER_SDK_BIN_SDK_PRODUCT = true
> > > +HOST_FLUTTER_SDK_BIN_SDK_ROOT = $(HOST_FLUTTER_SDK_BIN_SDK_ENGINE)/common/flutter_patched_sdk_product
> > > +HOST_FLUTTER_SDK_BIN_SDK_VM_PROFILE = false
> > >  endif
> > This if-elif-else block is not in the same order as the one to enable
> > profiling in flutter-engine. Here you have: debug, profiling, release,
> > while in flutter-engine the order is: profiling, debug, release.
> >
> > Shouldn't the two match, i.e. should we swap the debug and profiling
> > blocks here?
> No worries if you re-arrange the if-elif-else block to match what is
> in flutter-engine. The outcome is the same.

As we discussed on IRC, the outcome is not the same. Indeed,
FLUTTER_ENGINE_RUNTIME_MODE_PROFILE is supposed to win over
BR2_ENABLE_RUNTIME_DEBUG, so that when both debug and profiling are
enabled, we do profile, not debug.

And as concluded on IRC, I'll swap when applying.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot