[Buildroot] [PATCH 0/3] flutter-pi audio player plugin Config.in fixes

[Buildroot] [PATCH 0/3] flutter-pi audio player plugin Config.in fixes

[Adam Duskett]

I noticed a few minor problems with the audio player plugin in the Config.in
file for the flutter-pi package.

I copied and pasted the video player plugin and forgot to:
  - Remove the dependency on libgles, which doesn't comment on the erroneous
    dependency.
  - I didn't change the help text, which matches the video player plugin.

Also, the last update added help text in the README.md files, which explicitly
states that the audio player plugin is incompatible/not tested with PulseAudio.
As such, I have added a dependency on !BR2_PACKAGE_PULSEAUDIO

Adam Duskett (3):
  package/flutter-pi: remove libgles requirement for gstreamer audio
    plugin
  package/flutter-pi: Fix help text for gstreamer audio player
  package/flutter-pi: audio player plugin is not compatible with
    pulseaudio

 package/flutter-pi/Config.in | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/3] package/flutter-pi: remove libgles requirement for gstreamer audio plugin

[Adam Duskett]

package/flutter-pi: remove libgles requirement for gstreamer audio plugin

I erroneously added the dependency BR2_PACKAGE_HAS_LIBGLES for the gstreamer
audio player plugin, and the CMakeLists.txt file does not check for gles2 when
the plugin is selected. This error was likely due to a copy/paste mistake.
Remove the requirement.

Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
 package/flutter-pi/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
index bb0e3702c1..95b5525806 100644
--- a/package/flutter-pi/Config.in
+++ b/package/flutter-pi/Config.in
@@ -47,7 +47,6 @@ config BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
 
 config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
 	bool "gstreamer audio player"
-	depends on BR2_PACKAGE_HAS_LIBGLES
 	select BR2_PACKAGE_GSTREAMER1
 	select BR2_PACKAGE_GST1_PLUGINS_BASE
 	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] package/flutter-pi: remove libgles requirement for gstreamer audio plugin

[Yann E. MORIN]

On 2024-01-23 12:00 -0700, Adam Duskett spake thusly:
> package/flutter-pi: remove libgles requirement for gstreamer audio plugin

Duplicate commit title.

> I erroneously added the dependency BR2_PACKAGE_HAS_LIBGLES for the gstreamer

No 'I' in commit logs; instead, we use third-person passive tense. I
reworded the commit log.

> audio player plugin, and the CMakeLists.txt file does not check for gles2 when
> the plugin is selected. This error was likely due to a copy/paste mistake.
> Remove the requirement.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/flutter-pi/Config.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
> index bb0e3702c1..95b5525806 100644
> --- a/package/flutter-pi/Config.in
> +++ b/package/flutter-pi/Config.in
> @@ -47,7 +47,6 @@ config BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
>  
>  config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
>  	bool "gstreamer audio player"
> -	depends on BR2_PACKAGE_HAS_LIBGLES
>  	select BR2_PACKAGE_GSTREAMER1
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] package/flutter-pi: remove libgles requirement for gstreamer audio plugin

[Peter Korsgaard]

>>>>> "Adam" == Adam Duskett <adam.duskett@amarulasolutions.com> writes:

 > package/flutter-pi: remove libgles requirement for gstreamer audio plugin
 > I erroneously added the dependency BR2_PACKAGE_HAS_LIBGLES for the gstreamer
 > audio player plugin, and the CMakeLists.txt file does not check for gles2 when
 > the plugin is selected. This error was likely due to a copy/paste mistake.
 > Remove the requirement.

 > Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/3] package/flutter-pi: Fix help text for gstreamer audio player

[Adam Duskett]

The help text is currently copy and pasted from the gstreamer video
player plugin help text. Change it to reflect the text from the
CMakeLists.txt file.

Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
 package/flutter-pi/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
index 95b5525806..223e29749c 100644
--- a/package/flutter-pi/Config.in
+++ b/package/flutter-pi/Config.in
@@ -54,9 +54,8 @@ config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
 	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE
 	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
 	help
-	  Include the gstreamer based video plugins in the finished
-	  binary. Allows for more stable, hardware accelerated
-	  video playback in flutter using gstreamer.
+	  Include the gstreamer based audio plugins in the finished
+	  binary.
 
 config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_VIDEO_PLAYER_PLUGIN
 	bool "gstreamer video player"
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/3] package/flutter-pi: Fix help text for gstreamer audio player

[Yann E. MORIN]

Adam, All,

On 2024-01-23 12:00 -0700, Adam Duskett spake thusly:
> The help text is currently copy and pasted from the gstreamer video
> player plugin help text. Change it to reflect the text from the
> CMakeLists.txt file.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/flutter-pi/Config.in | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
> index 95b5525806..223e29749c 100644
> --- a/package/flutter-pi/Config.in
> +++ b/package/flutter-pi/Config.in
> @@ -54,9 +54,8 @@ config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
>  	help
> -	  Include the gstreamer based video plugins in the finished
> -	  binary. Allows for more stable, hardware accelerated
> -	  video playback in flutter using gstreamer.
> +	  Include the gstreamer based audio plugins in the finished
> +	  binary.
>  
>  config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_VIDEO_PLAYER_PLUGIN
>  	bool "gstreamer video player"
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/3] package/flutter-pi: Fix help text for gstreamer audio player

[Peter Korsgaard]

>>>>> "Adam" == Adam Duskett <adam.duskett@amarulasolutions.com> writes:

 > The help text is currently copy and pasted from the gstreamer video
 > player plugin help text. Change it to reflect the text from the
 > CMakeLists.txt file.

 > Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/3] package/flutter-pi: audio player plugin is not compatible with pulseaudio

[Adam Duskett]

According to the README.md file:
```
[The] plugin was tested to work with ALSA and `pulseaudio` might prevent the
      plugin from playing audio correctly:
    - Hence please make sure you delete `pulseaudio` package from your system.
```

And from plugins/audioplayers/README.md:
```
...
- Make sure `pulseaudio` is deleted

Please note that plugin was not tested with `pulseaudio` and it is up to you
to make gstreamer work via it. As `pulseaudio` takes full control over audio
devices, `ALSA` will no longer function correctly with `pulseaudio` installed
```

As such, it is best to ensure the pulseaudio package is not selected to
ensure the audio player plugin works out of the box.

Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
 package/flutter-pi/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
index 223e29749c..379b1da45b 100644
--- a/package/flutter-pi/Config.in
+++ b/package/flutter-pi/Config.in
@@ -47,6 +47,7 @@ config BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
 
 config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
 	bool "gstreamer audio player"
+	depends on !BR2_PACKAGE_PULSEAUDIO
 	select BR2_PACKAGE_GSTREAMER1
 	select BR2_PACKAGE_GST1_PLUGINS_BASE
 	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
@@ -57,6 +58,9 @@ config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
 	  Include the gstreamer based audio plugins in the finished
 	  binary.
 
+comment "gstreamer audio player plugin is not compatible with pulseaudio"
+	depends on BR2_PACKAGE_PULSEAUDIO
+
 config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_VIDEO_PLAYER_PLUGIN
 	bool "gstreamer video player"
 	depends on BR2_PACKAGE_HAS_LIBGLES
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/3] package/flutter-pi: audio player plugin is not compatible with pulseaudio

[Yann E. MORIN]

Adam, All,

On 2024-01-23 12:00 -0700, Adam Duskett spake thusly:
> According to the README.md file:
> ```
> [The] plugin was tested to work with ALSA and `pulseaudio` might prevent the
>       plugin from playing audio correctly:
>     - Hence please make sure you delete `pulseaudio` package from your system.
> ```
> 
> And from plugins/audioplayers/README.md:
> ```
> ...
> - Make sure `pulseaudio` is deleted
> 
> Please note that plugin was not tested with `pulseaudio` and it is up to you
> to make gstreamer work via it. As `pulseaudio` takes full control over audio
> devices, `ALSA` will no longer function correctly with `pulseaudio` installed
> ```
> 
> As such, it is best to ensure the pulseaudio package is not selected to
> ensure the audio player plugin works out of the box.

I am not sure about this.

First, it is possible, albeit a bit kludgy, to make an ALSA application
work with P.A:

    https://www.freedesktop.org/wiki/Software/PulseAudio/FAQ/#canigetossandalsaapplicationstoworkwithpulseaudio

    Yes, you can! OSS applications are handled using the padsp utility
    shipped with PulseAudio:

        padsp myapp <arguments to myapp>

It is a LD_PRELOAD-based wrapper, hence it might be a bit kludgy, but it
is worth a try.

Second, it is possible for PA to not be used as a systemd daemon; that's
even the default, and Buildroot has an option for that:
    BR2_PACKAGE_PULSEAUDIO_DAEMON

In such a case, it is possible that a system is configured to run an
application or another, and thus it is a rruntime configuration that
ensures that the ALSA-based app and the PA-based one are nt running at
the same time.

Also, as you quoted, the plugin is "not tested with `pulseaudio` and it
is up to you to make gstreamer work via it". Untested does not mean
non-functional.

So, I don't see a reason to do that exclusion.

Regards,
Yann E. MORIN.

> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/flutter-pi/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
> index 223e29749c..379b1da45b 100644
> --- a/package/flutter-pi/Config.in
> +++ b/package/flutter-pi/Config.in
> @@ -47,6 +47,7 @@ config BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
>  
>  config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
>  	bool "gstreamer audio player"
> +	depends on !BR2_PACKAGE_PULSEAUDIO
>  	select BR2_PACKAGE_GSTREAMER1
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> @@ -57,6 +58,9 @@ config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
>  	  Include the gstreamer based audio plugins in the finished
>  	  binary.
>  
> +comment "gstreamer audio player plugin is not compatible with pulseaudio"
> +	depends on BR2_PACKAGE_PULSEAUDIO
> +
>  config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_VIDEO_PLAYER_PLUGIN
>  	bool "gstreamer video player"
>  	depends on BR2_PACKAGE_HAS_LIBGLES
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot