* [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
@ 2024-01-11 5:17 James Hilliard
2024-02-05 10:53 ` Arnout Vandecappelle via buildroot
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: James Hilliard @ 2024-01-11 5:17 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Asaf Kahlon
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/python-rpds-py/python-rpds-py.hash | 2 +-
package/python-rpds-py/python-rpds-py.mk | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/python-rpds-py/python-rpds-py.hash b/package/python-rpds-py/python-rpds-py.hash
index b04aa210d3..8c4b6181d0 100644
--- a/package/python-rpds-py/python-rpds-py.hash
+++ b/package/python-rpds-py/python-rpds-py.hash
@@ -1,4 +1,4 @@
# Locally calculated after vendoring
-sha256 87361601241744fff6235e35050addfe34d00508172d2bd4f178193a28727287 rpds_py-0.12.0.tar.gz
+sha256 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb rpds_py-0.16.2.tar.gz
# Locally computed sha256 checksums
sha256 314e4e91be3baa93c0fb4bccc9e4e97cd643eb839b065af921782c2175fe9909 LICENSE
diff --git a/package/python-rpds-py/python-rpds-py.mk b/package/python-rpds-py/python-rpds-py.mk
index 6f71d02047..5f0d30d002 100644
--- a/package/python-rpds-py/python-rpds-py.mk
+++ b/package/python-rpds-py/python-rpds-py.mk
@@ -4,9 +4,9 @@
#
################################################################################
-PYTHON_RPDS_PY_VERSION = 0.12.0
+PYTHON_RPDS_PY_VERSION = 0.16.2
PYTHON_RPDS_PY_SOURCE = rpds_py-$(PYTHON_RPDS_PY_VERSION).tar.gz
-PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/75/be/e3f366aa4cd1e3a814f136773e506fc5423eff903ef0372a251df34e6e45
+PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/c2/63/94a1e9406b34888bdf8506e91d654f1cd84365a5edafa5f8ff0c97d4d9e1
PYTHON_RPDS_PY_SETUP_TYPE = maturin
PYTHON_RPDS_PY_LICENSE = MIT
PYTHON_RPDS_PY_LICENSE_FILES = LICENSE
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
2024-01-11 5:17 [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2 James Hilliard
@ 2024-02-05 10:53 ` Arnout Vandecappelle via buildroot
2024-02-05 11:05 ` Arnout Vandecappelle via buildroot
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2024-02-05 10:53 UTC (permalink / raw)
To: James Hilliard, buildroot; +Cc: Asaf Kahlon
On 11/01/2024 06:17, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/python-rpds-py/python-rpds-py.hash | 2 +-
> package/python-rpds-py/python-rpds-py.mk | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/python-rpds-py/python-rpds-py.hash b/package/python-rpds-py/python-rpds-py.hash
> index b04aa210d3..8c4b6181d0 100644
> --- a/package/python-rpds-py/python-rpds-py.hash
> +++ b/package/python-rpds-py/python-rpds-py.hash
> @@ -1,4 +1,4 @@
> # Locally calculated after vendoring
> -sha256 87361601241744fff6235e35050addfe34d00508172d2bd4f178193a28727287 rpds_py-0.12.0.tar.gz
> +sha256 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb rpds_py-0.16.2.tar.gz
> # Locally computed sha256 checksums
> sha256 314e4e91be3baa93c0fb4bccc9e4e97cd643eb839b065af921782c2175fe9909 LICENSE
> diff --git a/package/python-rpds-py/python-rpds-py.mk b/package/python-rpds-py/python-rpds-py.mk
> index 6f71d02047..5f0d30d002 100644
> --- a/package/python-rpds-py/python-rpds-py.mk
> +++ b/package/python-rpds-py/python-rpds-py.mk
> @@ -4,9 +4,9 @@
> #
> ################################################################################
>
> -PYTHON_RPDS_PY_VERSION = 0.12.0
> +PYTHON_RPDS_PY_VERSION = 0.16.2
> PYTHON_RPDS_PY_SOURCE = rpds_py-$(PYTHON_RPDS_PY_VERSION).tar.gz
> -PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/75/be/e3f366aa4cd1e3a814f136773e506fc5423eff903ef0372a251df34e6e45
> +PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/c2/63/94a1e9406b34888bdf8506e91d654f1cd84365a5edafa5f8ff0c97d4d9e1
> PYTHON_RPDS_PY_SETUP_TYPE = maturin
> PYTHON_RPDS_PY_LICENSE = MIT
> PYTHON_RPDS_PY_LICENSE_FILES = LICENSE
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
2024-01-11 5:17 [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2 James Hilliard
2024-02-05 10:53 ` Arnout Vandecappelle via buildroot
@ 2024-02-05 11:05 ` Arnout Vandecappelle via buildroot
2024-02-06 13:44 ` Yann E. MORIN
2024-02-06 13:43 ` Yann E. MORIN
2024-02-06 14:09 ` Antoine Coutant
3 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2024-02-05 11:05 UTC (permalink / raw)
To: James Hilliard, buildroot; +Cc: Yann E. MORIN, Asaf Kahlon
On 11/01/2024 06:17, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/python-rpds-py/python-rpds-py.hash | 2 +-
> package/python-rpds-py/python-rpds-py.mk | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/python-rpds-py/python-rpds-py.hash b/package/python-rpds-py/python-rpds-py.hash
> index b04aa210d3..8c4b6181d0 100644
> --- a/package/python-rpds-py/python-rpds-py.hash
> +++ b/package/python-rpds-py/python-rpds-py.hash
> @@ -1,4 +1,4 @@
> # Locally calculated after vendoring
> -sha256 87361601241744fff6235e35050addfe34d00508172d2bd4f178193a28727287 rpds_py-0.12.0.tar.gz
> +sha256 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb rpds_py-0.16.2.tar.gz
ERROR: while checking hashes from package/python-rpds-py//python-rpds-py.hash
ERROR: rpds_py-0.16.2.tar.gz has wrong sha256 hash:
ERROR: expected: 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb
ERROR: got : bc62a37913de53569414f6eb4a16a005b1dd04afb473c3c27561b11614f92034
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
This might be the gitattributes issue that Yann has a patch series for. I'm
marking this patch as Changes Requested, you can try to re-submit after Yann's
series is merged.
Regards,
Arnout
> # Locally computed sha256 checksums
> sha256 314e4e91be3baa93c0fb4bccc9e4e97cd643eb839b065af921782c2175fe9909 LICENSE
> diff --git a/package/python-rpds-py/python-rpds-py.mk b/package/python-rpds-py/python-rpds-py.mk
> index 6f71d02047..5f0d30d002 100644
> --- a/package/python-rpds-py/python-rpds-py.mk
> +++ b/package/python-rpds-py/python-rpds-py.mk
> @@ -4,9 +4,9 @@
> #
> ################################################################################
>
> -PYTHON_RPDS_PY_VERSION = 0.12.0
> +PYTHON_RPDS_PY_VERSION = 0.16.2
> PYTHON_RPDS_PY_SOURCE = rpds_py-$(PYTHON_RPDS_PY_VERSION).tar.gz
> -PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/75/be/e3f366aa4cd1e3a814f136773e506fc5423eff903ef0372a251df34e6e45
> +PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/c2/63/94a1e9406b34888bdf8506e91d654f1cd84365a5edafa5f8ff0c97d4d9e1
> PYTHON_RPDS_PY_SETUP_TYPE = maturin
> PYTHON_RPDS_PY_LICENSE = MIT
> PYTHON_RPDS_PY_LICENSE_FILES = LICENSE
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
2024-01-11 5:17 [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2 James Hilliard
2024-02-05 10:53 ` Arnout Vandecappelle via buildroot
2024-02-05 11:05 ` Arnout Vandecappelle via buildroot
@ 2024-02-06 13:43 ` Yann E. MORIN
2024-02-06 14:09 ` Antoine Coutant
3 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2024-02-06 13:43 UTC (permalink / raw)
To: James Hilliard; +Cc: Asaf Kahlon, buildroot
James, all,
On 2024-01-10 22:17 -0700, James Hilliard spake thusly:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/python-rpds-py/python-rpds-py.hash | 2 +-
> package/python-rpds-py/python-rpds-py.mk | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/python-rpds-py/python-rpds-py.hash b/package/python-rpds-py/python-rpds-py.hash
> index b04aa210d3..8c4b6181d0 100644
> --- a/package/python-rpds-py/python-rpds-py.hash
> +++ b/package/python-rpds-py/python-rpds-py.hash
> @@ -1,4 +1,4 @@
> # Locally calculated after vendoring
> -sha256 87361601241744fff6235e35050addfe34d00508172d2bd4f178193a28727287 rpds_py-0.12.0.tar.gz
> +sha256 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb rpds_py-0.16.2.tar.gz
> # Locally computed sha256 checksums
> sha256 314e4e91be3baa93c0fb4bccc9e4e97cd643eb839b065af921782c2175fe9909 LICENSE
> diff --git a/package/python-rpds-py/python-rpds-py.mk b/package/python-rpds-py/python-rpds-py.mk
> index 6f71d02047..5f0d30d002 100644
> --- a/package/python-rpds-py/python-rpds-py.mk
> +++ b/package/python-rpds-py/python-rpds-py.mk
> @@ -4,9 +4,9 @@
> #
> ################################################################################
>
> -PYTHON_RPDS_PY_VERSION = 0.12.0
> +PYTHON_RPDS_PY_VERSION = 0.16.2
> PYTHON_RPDS_PY_SOURCE = rpds_py-$(PYTHON_RPDS_PY_VERSION).tar.gz
> -PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/75/be/e3f366aa4cd1e3a814f136773e506fc5423eff903ef0372a251df34e6e45
> +PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/c2/63/94a1e9406b34888bdf8506e91d654f1cd84365a5edafa5f8ff0c97d4d9e1
> PYTHON_RPDS_PY_SETUP_TYPE = maturin
> PYTHON_RPDS_PY_LICENSE = MIT
> PYTHON_RPDS_PY_LICENSE_FILES = LICENSE
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
2024-02-05 11:05 ` Arnout Vandecappelle via buildroot
@ 2024-02-06 13:44 ` Yann E. MORIN
0 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2024-02-06 13:44 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: James Hilliard, Asaf Kahlon, buildroot
James, All,
On 2024-02-05 12:05 +0100, Arnout Vandecappelle via buildroot spake thusly:
> On 11/01/2024 06:17, James Hilliard wrote:
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/python-rpds-py/python-rpds-py.hash | 2 +-
> > package/python-rpds-py/python-rpds-py.mk | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/python-rpds-py/python-rpds-py.hash b/package/python-rpds-py/python-rpds-py.hash
> > index b04aa210d3..8c4b6181d0 100644
> > --- a/package/python-rpds-py/python-rpds-py.hash
> > +++ b/package/python-rpds-py/python-rpds-py.hash
> > @@ -1,4 +1,4 @@
> > # Locally calculated after vendoring
> > -sha256 87361601241744fff6235e35050addfe34d00508172d2bd4f178193a28727287 rpds_py-0.12.0.tar.gz
> > +sha256 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb rpds_py-0.16.2.tar.gz
>
> ERROR: while checking hashes from package/python-rpds-py//python-rpds-py.hash
> ERROR: rpds_py-0.16.2.tar.gz has wrong sha256 hash:
> ERROR: expected: 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb
> ERROR: got : bc62a37913de53569414f6eb4a16a005b1dd04afb473c3c27561b11614f92034
> ERROR: Incomplete download, or man-in-the-middle (MITM) attack
>
> This might be the gitattributes issue that Yann has a patch series for. I'm
> marking this patch as Changes Requested, you can try to re-submit after
> Yann's series is merged.
It turned out that Arnout had a broken setup, and the archives were made
with tar 1.35 rather than the expexted 1.34.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
2024-01-11 5:17 [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2 James Hilliard
` (2 preceding siblings ...)
2024-02-06 13:43 ` Yann E. MORIN
@ 2024-02-06 14:09 ` Antoine Coutant
2024-02-06 14:53 ` Yann E. MORIN
3 siblings, 1 reply; 8+ messages in thread
From: Antoine Coutant @ 2024-02-06 14:09 UTC (permalink / raw)
To: buildroot
James, All,
On 11/01/2024 06:17, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/python-rpds-py/python-rpds-py.hash | 2 +-
> package/python-rpds-py/python-rpds-py.mk | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/python-rpds-py/python-rpds-py.hash b/package/python-rpds-py/python-rpds-py.hash
> index b04aa210d3..8c4b6181d0 100644
> --- a/package/python-rpds-py/python-rpds-py.hash
> +++ b/package/python-rpds-py/python-rpds-py.hash
> @@ -1,4 +1,4 @@
> # Locally calculated after vendoring
> -sha256 87361601241744fff6235e35050addfe34d00508172d2bd4f178193a28727287 rpds_py-0.12.0.tar.gz
> +sha256 861b1fa8c37819b2e2cebbde6dea66ac2fa1247e4a7c3933dbf4c89244d7fecb rpds_py-0.16.2.tar.gz
> # Locally computed sha256 checksums
> sha256 314e4e91be3baa93c0fb4bccc9e4e97cd643eb839b065af921782c2175fe9909 LICENSE
> diff --git a/package/python-rpds-py/python-rpds-py.mk b/package/python-rpds-py/python-rpds-py.mk
> index 6f71d02047..5f0d30d002 100644
> --- a/package/python-rpds-py/python-rpds-py.mk
> +++ b/package/python-rpds-py/python-rpds-py.mk
> @@ -4,9 +4,9 @@
> #
> ################################################################################
>
> -PYTHON_RPDS_PY_VERSION = 0.12.0
> +PYTHON_RPDS_PY_VERSION = 0.16.2
> PYTHON_RPDS_PY_SOURCE = rpds_py-$(PYTHON_RPDS_PY_VERSION).tar.gz
> -PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/75/be/e3f366aa4cd1e3a814f136773e506fc5423eff903ef0372a251df34e6e45
> +PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/c2/63/94a1e9406b34888bdf8506e91d654f1cd84365a5edafa5f8ff0c97d4d9e1
> PYTHON_RPDS_PY_SETUP_TYPE = maturin
> PYTHON_RPDS_PY_LICENSE = MIT
> PYTHON_RPDS_PY_LICENSE_FILES = LICENSE
rpds depends on the crate pyo3. This crate uses
"std::sync::atomic::AtomicI64" which doesn't exist for 32 bits
targets. That leads to an error [1].
An issue have been opened on pyo3's github [2]. A fix have been accepted [3]
but it isn't in the last release. Thus, this version bump doesn't
fix this problem.
[1]: https://gitlab.com/buildroot.org/buildroot/-/jobs/6093854842
[2]: https://github.com/PyO3/pyo3/issues/3614
[3]: https://github.com/PyO3/pyo3/pull/3619
regards,
Antoine Coutant
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
2024-02-06 14:09 ` Antoine Coutant
@ 2024-02-06 14:53 ` Yann E. MORIN
2024-02-06 16:00 ` Antoine Coutant
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2024-02-06 14:53 UTC (permalink / raw)
To: Antoine Coutant; +Cc: buildroot
Antoine, All,
On 2024-02-06 15:09 +0100, Antoine Coutant spake thusly:
> On 11/01/2024 06:17, James Hilliard wrote:
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
[--SNIP--]
> > -PYTHON_RPDS_PY_VERSION = 0.12.0
> > +PYTHON_RPDS_PY_VERSION = 0.16.2
> rpds depends on the crate pyo3. This crate uses
> "std::sync::atomic::AtomicI64" which doesn't exist for 32 bits
> targets. That leads to an error [1].
I have been discussing this with Romain IRL, and he explained that the
issue _already_ happenned with 0.12.0, so this is not a regression and
thus reverting this patch will not fix the issue.
Is that correct?
Also, will std::sync::atomic::AtomicI64 ever be available for 32-bit
targets? If not, would that be considered a bug in the std lib?
> An issue have been opened on pyo3's github [2]. A fix have been accepted [3]
> but it isn't in the last release. Thus, this version bump doesn't
> fix this problem.
> [1]: https://gitlab.com/buildroot.org/buildroot/-/jobs/6093854842
> [2]: https://github.com/PyO3/pyo3/issues/3614
> [3]: https://github.com/PyO3/pyo3/pull/3619
It is not going to be easy to carry this change as a patch in Buildroot:
it would require that we be able to patch a package during the vendoring
step.
In this case, we'd need to do the vendoring (because we need the pyo3
crate to be downloaded), then apply the patch (with mangled paths) to
add the new dependency, then restart the vendoring. In the generic case,
we'd even need to be able to repeat the process in case that new
dependency has to be patched and so on and so on... That's not going to
be easy, by far...
Meh...
We can't even update to a random sha1 from the rpds git tree, because
they do nit even have an update to switch to a newer (even if
unreleased) pyo3.
Meh, again...
Not sure what to do...
What about adding a dependency on BR2_ARCH_IS_64 to python-rpds-pym and
propagate that to all its dependencies?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2
2024-02-06 14:53 ` Yann E. MORIN
@ 2024-02-06 16:00 ` Antoine Coutant
0 siblings, 0 replies; 8+ messages in thread
From: Antoine Coutant @ 2024-02-06 16:00 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 3271 bytes --]
On 06/02/2024 15:53, Yann E. MORIN wrote:
> Antoine, All,
>
> On 2024-02-06 15:09 +0100, Antoine Coutant spake thusly:
>> On 11/01/2024 06:17, James Hilliard wrote:
>>> Signed-off-by: James Hilliard<james.hilliard1@gmail.com>
> [--SNIP--]
>>> -PYTHON_RPDS_PY_VERSION = 0.12.0
>>> +PYTHON_RPDS_PY_VERSION = 0.16.2
>> rpds depends on the crate pyo3. This crate uses
>> "std::sync::atomic::AtomicI64" which doesn't exist for 32 bits
>> targets. That leads to an error [1].
> I have been discussing this with Romain IRL, and he explained that the
> issue _already_ happenned with 0.12.0, so this is not a regression and
> thus reverting this patch will not fix the issue.
>
> Is that correct?
Yes, this patch is not a regression. I did a test with Buildroot 2023.11
and it failed. This bug is old but i described it here because I was
working on it when the version bump was applied and I thought
it was related.
>
> Also, will std::sync::atomic::AtomicI64 ever be available for 32-bit
> targets? If not, would that be considered a bug in the std lib?
according to the rust doc, std::sync::atomic::AtomicI64 is only available
on platforms that support atomic loads and stores of i64 [1]. Moreover,
std::sync::atomic types might not be available on all platforms [2].
That's why the crate portable-atomic [3] have been created. It provides
atomic types and compare and swap operations for all targets that can use
std. That's the crate used by pyo3 upstream to solve the problem [4].
>> An issue have been opened on pyo3's github [2]. A fix have been accepted [3]
>> but it isn't in the last release. Thus, this version bump doesn't
>> fix this problem.
>> [1]:https://gitlab.com/buildroot.org/buildroot/-/jobs/6093854842
>> [2]:https://github.com/PyO3/pyo3/issues/3614
>> [3]:https://github.com/PyO3/pyo3/pull/3619
> It is not going to be easy to carry this change as a patch in Buildroot:
> it would require that we be able to patch a package during the vendoring
> step.
>
> In this case, we'd need to do the vendoring (because we need the pyo3
> crate to be downloaded), then apply the patch (with mangled paths) to
> add the new dependency, then restart the vendoring. In the generic case,
> we'd even need to be able to repeat the process in case that new
> dependency has to be patched and so on and so on... That's not going to
> be easy, by far...
>
> Meh...
>
> We can't even update to a random sha1 from the rpds git tree, because
> they do nit even have an update to switch to a newer (even if
> unreleased) pyo3.
>
> Meh, again...
>
> Not sure what to do...
>
> What about adding a dependency on BR2_ARCH_IS_64 to python-rpds-pym and
> propagate that to all its dependencies?
I think this is the best way to avoid this bug. Patching during the
vendoring process seams to be possible. But it will be quite
impossible to maintain.
The dependency on BR2_ARCH_IS_64 must be removed when
the version of spo3 used by rpds will use portable-atomic.
>
> Regards,
> Yann E. MORIN.
[1]: https://doc.rust-lang.org/std/sync/atomic/struct.AtomicI64.html
[2]: https://doc.rust-lang.org/std/sync/atomic/index.html#portability
[3]: https://github.com/taiki-e/portable-atomic
[4]: https://github.com/PyO3/pyo3/pull/3619/files
Regards,
Antoine Coutant
[-- Attachment #1.2: Type: text/html, Size: 5817 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-02-06 16:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 5:17 [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2 James Hilliard
2024-02-05 10:53 ` Arnout Vandecappelle via buildroot
2024-02-05 11:05 ` Arnout Vandecappelle via buildroot
2024-02-06 13:44 ` Yann E. MORIN
2024-02-06 13:43 ` Yann E. MORIN
2024-02-06 14:09 ` Antoine Coutant
2024-02-06 14:53 ` Yann E. MORIN
2024-02-06 16:00 ` Antoine Coutant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox