* [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2 @ 2024-05-29 0:15 Geoff Levand 2024-05-29 6:30 ` Peter Korsgaard 0 siblings, 1 reply; 5+ messages in thread From: Geoff Levand @ 2024-05-29 0:15 UTC (permalink / raw) To: Thomas Petazzoni, Peter Korsgaard, buildroot Signed-off-by: Geoff Levand <geoff@infradead.org> diff --git a/package/flannel/flannel.hash b/package/flannel/flannel.hash index 831f6234da..367c4f6ecf 100644 --- a/package/flannel/flannel.hash +++ b/package/flannel/flannel.hash @@ -1,3 +1,3 @@ # Locally computed: -sha256 8406a3b2b799344197c79f96e5b39ea7b6228f0bb2cb069b5f44dce684e29b9b flannel-0.25.1-go2.tar.gz +sha256 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 flannel-0.25.2-go2.tar.gz sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 LICENSE diff --git a/package/flannel/flannel.mk b/package/flannel/flannel.mk index aa24644764..317ad14ba3 100644 --- a/package/flannel/flannel.mk +++ b/package/flannel/flannel.mk @@ -4,7 +4,7 @@ # ################################################################################ -FLANNEL_VERSION = 0.25.1 +FLANNEL_VERSION = 0.25.2 FLANNEL_SITE = $(call github,flannel-io,flannel,v$(FLANNEL_VERSION)) FLANNEL_LICENSE = Apache-2.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2 2024-05-29 0:15 [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2 Geoff Levand @ 2024-05-29 6:30 ` Peter Korsgaard 2024-05-29 8:58 ` Geoff Levand 0 siblings, 1 reply; 5+ messages in thread From: Peter Korsgaard @ 2024-05-29 6:30 UTC (permalink / raw) To: Geoff Levand, yann.morin.1998; +Cc: Thomas Petazzoni, buildroot >>>>> "Geoff" == Geoff Levand <geoff@infradead.org> writes: > Signed-off-by: Geoff Levand <geoff@infradead.org> > diff --git a/package/flannel/flannel.hash b/package/flannel/flannel.hash > index 831f6234da..367c4f6ecf 100644 > --- a/package/flannel/flannel.hash > +++ b/package/flannel/flannel.hash > @@ -1,3 +1,3 @@ > # Locally computed: > -sha256 8406a3b2b799344197c79f96e5b39ea7b6228f0bb2cb069b5f44dce684e29b9b flannel-0.25.1-go2.tar.gz > +sha256 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 flannel-0.25.2-go2.tar.gz Hmm, I get a different hash here? ERROR: while checking hashes from package/flannel/flannel.hash ERROR: flannel-0.25.2-go2.tar.gz has wrong sha256 hash: ERROR: expected: 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 ERROR: got : e181a5e4233db47b0f03718ea801274c3a6024d235ead76e974f3df4f4183de1 > sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 LICENSE > diff --git a/package/flannel/flannel.mk b/package/flannel/flannel.mk > index aa24644764..317ad14ba3 100644 > --- a/package/flannel/flannel.mk > +++ b/package/flannel/flannel.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > -FLANNEL_VERSION = 0.25.1 > +FLANNEL_VERSION = 0.25.2 > FLANNEL_SITE = $(call github,flannel-io,flannel,v$(FLANNEL_VERSION)) > FLANNEL_LICENSE = Apache-2.0 -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2 2024-05-29 6:30 ` Peter Korsgaard @ 2024-05-29 8:58 ` Geoff Levand 2024-05-29 18:18 ` Yann E. MORIN 0 siblings, 1 reply; 5+ messages in thread From: Geoff Levand @ 2024-05-29 8:58 UTC (permalink / raw) To: Peter Korsgaard, yann.morin.1998; +Cc: Thomas Petazzoni, buildroot Hi Peter, On 5/29/24 15:30, Peter Korsgaard wrote: >>>>>> "Geoff" == Geoff Levand <geoff@infradead.org> writes: > > > Signed-off-by: Geoff Levand <geoff@infradead.org> > > diff --git a/package/flannel/flannel.hash b/package/flannel/flannel.hash > > index 831f6234da..367c4f6ecf 100644 > > --- a/package/flannel/flannel.hash > > +++ b/package/flannel/flannel.hash > > @@ -1,3 +1,3 @@ > > # Locally computed: > > -sha256 8406a3b2b799344197c79f96e5b39ea7b6228f0bb2cb069b5f44dce684e29b9b flannel-0.25.1-go2.tar.gz > > +sha256 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 flannel-0.25.2-go2.tar.gz > > Hmm, I get a different hash here? > > ERROR: while checking hashes from package/flannel/flannel.hash > ERROR: flannel-0.25.2-go2.tar.gz has wrong sha256 hash: > ERROR: expected: 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 > ERROR: got : e181a5e4233db47b0f03718ea801274c3a6024d235ead76e974f3df4f4183de1 I always do a clean build and run some tests before I send out a patch. It worked OK then, and I just tested again and it was OK. I see this in the build log; flannel-0.25.2-go2.tar.gz: OK (sha256: 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954) >>> flannel 0.25.2 Extracting Maybe there was some problem with your download of flannel-0.25.2-go2.tar.gz -Geoff _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2 2024-05-29 8:58 ` Geoff Levand @ 2024-05-29 18:18 ` Yann E. MORIN 2024-05-30 18:17 ` Peter Korsgaard 0 siblings, 1 reply; 5+ messages in thread From: Yann E. MORIN @ 2024-05-29 18:18 UTC (permalink / raw) To: Geoff Levand; +Cc: Thomas Petazzoni, buildroot Geoff, All, On 2024-05-29 17:58 +0900, Geoff Levand spake thusly: > On 5/29/24 15:30, Peter Korsgaard wrote: > >>>>>> "Geoff" == Geoff Levand <geoff@infradead.org> writes: > > > -sha256 8406a3b2b799344197c79f96e5b39ea7b6228f0bb2cb069b5f44dce684e29b9b flannel-0.25.1-go2.tar.gz > > > +sha256 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 flannel-0.25.2-go2.tar.gz > > Hmm, I get a different hash here? > > ERROR: while checking hashes from package/flannel/flannel.hash > > ERROR: flannel-0.25.2-go2.tar.gz has wrong sha256 hash: > > ERROR: expected: 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 > > ERROR: got : e181a5e4233db47b0f03718ea801274c3a6024d235ead76e974f3df4f4183de1 > I see this in the build log; > flannel-0.25.2-go2.tar.gz: OK (sha256: 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954) > >>> flannel 0.25.2 Extracting > Maybe there was some problem with your download of flannel-0.25.2-go2.tar.gz The issue has been identified: - we now require tar >= 1.35 (for reproducibility of tarballs) - we check whether the tar on the host system is suitable - if not, then we build our own host-tar, and use that So we should always use a valid tar: either the system one, or our own. However (there is always a "however"), the user can set TAR in their environment, to instruct Buildroot to use that specific tar. For example, it is possible to do: $ TAR=tar-1.35 make So, when we check whether the host tar is suitable, we in fact check that $(TAR) as provided by the user (and if not given, then we default to looking 'tar' in PATH). But we do not use $(TAR) from the download helper infrastructure, where we only use 'tar'. so, when the user has a system with an older tar in PATH, but provides a TAR=tar-1.35 when building, then there is a discrepancy between the tar we check, and the one we use. Boom. That's what happened to Peter. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2 2024-05-29 18:18 ` Yann E. MORIN @ 2024-05-30 18:17 ` Peter Korsgaard 0 siblings, 0 replies; 5+ messages in thread From: Peter Korsgaard @ 2024-05-30 18:17 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Geoff Levand, Thomas Petazzoni, buildroot >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > Geoff, All, > On 2024-05-29 17:58 +0900, Geoff Levand spake thusly: >> On 5/29/24 15:30, Peter Korsgaard wrote: >> >>>>>> "Geoff" == Geoff Levand <geoff@infradead.org> writes: >> > > -sha256 >> > > 8406a3b2b799344197c79f96e5b39ea7b6228f0bb2cb069b5f44dce684e29b9b >> > > flannel-0.25.1-go2.tar.gz >> > > +sha256 >> > > 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 >> > > flannel-0.25.2-go2.tar.gz >> > Hmm, I get a different hash here? >> > ERROR: while checking hashes from package/flannel/flannel.hash >> > ERROR: flannel-0.25.2-go2.tar.gz has wrong sha256 hash: >> > ERROR: expected: 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954 >> > ERROR: got : e181a5e4233db47b0f03718ea801274c3a6024d235ead76e974f3df4f4183de1 >> I see this in the build log; >> flannel-0.25.2-go2.tar.gz: OK (sha256: >> 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954) >> >>> flannel 0.25.2 Extracting >> Maybe there was some problem with your download of flannel-0.25.2-go2.tar.gz > The issue has been identified: > - we now require tar >= 1.35 (for reproducibility of tarballs) > - we check whether the tar on the host system is suitable > - if not, then we build our own host-tar, and use that > So we should always use a valid tar: either the system one, or our own. > However (there is always a "however"), the user can set TAR in their > environment, to instruct Buildroot to use that specific tar. For > example, it is possible to do: > $ TAR=tar-1.35 make > So, when we check whether the host tar is suitable, we in fact check > that $(TAR) as provided by the user (and if not given, then we default > to looking 'tar' in PATH). > But we do not use $(TAR) from the download helper infrastructure, where > we only use 'tar'. > so, when the user has a system with an older tar in PATH, but provides a > TAR=tar-1.35 when building, then there is a discrepancy between the tar > we check, and the one we use. > Boom. > That's what happened to Peter. Yes, sorry about the noise. Will get that issue fixed. Committed, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-30 18:18 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-05-29 0:15 [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2 Geoff Levand 2024-05-29 6:30 ` Peter Korsgaard 2024-05-29 8:58 ` Geoff Levand 2024-05-29 18:18 ` Yann E. MORIN 2024-05-30 18:17 ` Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox