* [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17
@ 2024-05-31 20:22 James Hilliard
2024-06-01 20:03 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: James Hilliard @ 2024-05-31 20:22 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
Add new host-gobject-introspection dependency.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/vala/vala.hash | 4 ++--
package/vala/vala.mk | 8 ++++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/package/vala/vala.hash b/package/vala/vala.hash
index b3716f0854..a16875ac6a 100644
--- a/package/vala/vala.hash
+++ b/package/vala/vala.hash
@@ -1,4 +1,4 @@
-# From https://download.gnome.org/sources/vala/0.56/vala-0.56.14.sha256sum
-sha256 9382c268ca9bdc02aaedc8152a9818bf3935273041f629c56de410e360a3f557 vala-0.56.14.tar.xz
+# From https://download.gnome.org/sources/vala/0.56/vala-0.56.17.sha256sum
+sha256 26100c4e4ef0049c619275f140d97cf565883d00c7543c82bcce5a426934ed6a vala-0.56.17.tar.xz
# Locally computed
sha256 5df07007198989c622f5d41de8d703e7bef3d0e79d62e24332ee739a452af62a COPYING
diff --git a/package/vala/vala.mk b/package/vala/vala.mk
index 415d996faa..7aebd4f395 100644
--- a/package/vala/vala.mk
+++ b/package/vala/vala.mk
@@ -5,14 +5,18 @@
################################################################################
VALA_VERSION_MAJOR = 0.56
-VALA_VERSION = $(VALA_VERSION_MAJOR).14
+VALA_VERSION = $(VALA_VERSION_MAJOR).17
VALA_SITE = http://download.gnome.org/sources/vala/$(VALA_VERSION_MAJOR)
VALA_SOURCE = vala-$(VALA_VERSION).tar.xz
VALA_LICENSE = LGPL-2.1+
VALA_LICENSE_FILES = COPYING
VALA_CPE_ID_VENDOR = gnome
-HOST_VALA_DEPENDENCIES = host-bison host-flex host-libglib2
+HOST_VALA_DEPENDENCIES = \
+ host-bison \
+ host-flex \
+ host-gobject-introspection \
+ host-libglib2
# Yes, the autoconf script understands ':' as "xsltproc is not
# available".
HOST_VALA_CONF_ENV = ac_cv_path_XSLTPROC=:
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17
2024-05-31 20:22 [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17 James Hilliard
@ 2024-06-01 20:03 ` Yann E. MORIN
2024-06-01 20:22 ` James Hilliard
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2024-06-01 20:03 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
James, All,
On 2024-05-31 14:22 -0600, James Hilliard spake thusly:
> Add new host-gobject-introspection dependency.
I can easily see that new dependency in the diff; saying so in the
commit log is not so usefull but to explain why it is now needed:
explain, don't describe.
So, why is this minor version bump now requiring host-GOI?
Regards,
Yann E. MORIN.
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/vala/vala.hash | 4 ++--
> package/vala/vala.mk | 8 ++++++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/package/vala/vala.hash b/package/vala/vala.hash
> index b3716f0854..a16875ac6a 100644
> --- a/package/vala/vala.hash
> +++ b/package/vala/vala.hash
> @@ -1,4 +1,4 @@
> -# From https://download.gnome.org/sources/vala/0.56/vala-0.56.14.sha256sum
> -sha256 9382c268ca9bdc02aaedc8152a9818bf3935273041f629c56de410e360a3f557 vala-0.56.14.tar.xz
> +# From https://download.gnome.org/sources/vala/0.56/vala-0.56.17.sha256sum
> +sha256 26100c4e4ef0049c619275f140d97cf565883d00c7543c82bcce5a426934ed6a vala-0.56.17.tar.xz
> # Locally computed
> sha256 5df07007198989c622f5d41de8d703e7bef3d0e79d62e24332ee739a452af62a COPYING
> diff --git a/package/vala/vala.mk b/package/vala/vala.mk
> index 415d996faa..7aebd4f395 100644
> --- a/package/vala/vala.mk
> +++ b/package/vala/vala.mk
> @@ -5,14 +5,18 @@
> ################################################################################
>
> VALA_VERSION_MAJOR = 0.56
> -VALA_VERSION = $(VALA_VERSION_MAJOR).14
> +VALA_VERSION = $(VALA_VERSION_MAJOR).17
> VALA_SITE = http://download.gnome.org/sources/vala/$(VALA_VERSION_MAJOR)
> VALA_SOURCE = vala-$(VALA_VERSION).tar.xz
> VALA_LICENSE = LGPL-2.1+
> VALA_LICENSE_FILES = COPYING
> VALA_CPE_ID_VENDOR = gnome
>
> -HOST_VALA_DEPENDENCIES = host-bison host-flex host-libglib2
> +HOST_VALA_DEPENDENCIES = \
> + host-bison \
> + host-flex \
> + host-gobject-introspection \
> + host-libglib2
> # Yes, the autoconf script understands ':' as "xsltproc is not
> # available".
> HOST_VALA_CONF_ENV = ac_cv_path_XSLTPROC=:
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17
2024-06-01 20:03 ` Yann E. MORIN
@ 2024-06-01 20:22 ` James Hilliard
2024-06-02 11:01 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: James Hilliard @ 2024-06-01 20:22 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: buildroot
On Sat, Jun 1, 2024 at 2:03 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> James, All,
>
> On 2024-05-31 14:22 -0600, James Hilliard spake thusly:
> > Add new host-gobject-introspection dependency.
>
> I can easily see that new dependency in the diff; saying so in the
> commit log is not so usefull but to explain why it is now needed:
> explain, don't describe.
>
> So, why is this minor version bump now requiring host-GOI?
Well the requirement was added here, so it seems to only be used
for finding girdir:
vala: Follow the logic of GIrParser.locate_gir() to find gir files
https://gitlab.gnome.org/GNOME/vala/-/commit/a9d38070ce86d7994b949f7cb426fbf670a953d8
There's some more background here on this issue although it's
somewhat unclear what the buildroot implications are exactly as
our GOI integration is rather complex:
https://gitlab.gnome.org/GNOME/vala/-/issues/1518
By the way this update happens to fix some build issues with GCC 14,
although that appears to be unrelated to the host-GOI dependency:
http://autobuild.buildroot.net/results/4a6/4a600f039ad5729a3fb131698ccde5132b3139ae/build-end.log
>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/vala/vala.hash | 4 ++--
> > package/vala/vala.mk | 8 ++++++--
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/package/vala/vala.hash b/package/vala/vala.hash
> > index b3716f0854..a16875ac6a 100644
> > --- a/package/vala/vala.hash
> > +++ b/package/vala/vala.hash
> > @@ -1,4 +1,4 @@
> > -# From https://download.gnome.org/sources/vala/0.56/vala-0.56.14.sha256sum
> > -sha256 9382c268ca9bdc02aaedc8152a9818bf3935273041f629c56de410e360a3f557 vala-0.56.14.tar.xz
> > +# From https://download.gnome.org/sources/vala/0.56/vala-0.56.17.sha256sum
> > +sha256 26100c4e4ef0049c619275f140d97cf565883d00c7543c82bcce5a426934ed6a vala-0.56.17.tar.xz
> > # Locally computed
> > sha256 5df07007198989c622f5d41de8d703e7bef3d0e79d62e24332ee739a452af62a COPYING
> > diff --git a/package/vala/vala.mk b/package/vala/vala.mk
> > index 415d996faa..7aebd4f395 100644
> > --- a/package/vala/vala.mk
> > +++ b/package/vala/vala.mk
> > @@ -5,14 +5,18 @@
> > ################################################################################
> >
> > VALA_VERSION_MAJOR = 0.56
> > -VALA_VERSION = $(VALA_VERSION_MAJOR).14
> > +VALA_VERSION = $(VALA_VERSION_MAJOR).17
> > VALA_SITE = http://download.gnome.org/sources/vala/$(VALA_VERSION_MAJOR)
> > VALA_SOURCE = vala-$(VALA_VERSION).tar.xz
> > VALA_LICENSE = LGPL-2.1+
> > VALA_LICENSE_FILES = COPYING
> > VALA_CPE_ID_VENDOR = gnome
> >
> > -HOST_VALA_DEPENDENCIES = host-bison host-flex host-libglib2
> > +HOST_VALA_DEPENDENCIES = \
> > + host-bison \
> > + host-flex \
> > + host-gobject-introspection \
> > + host-libglib2
> > # Yes, the autoconf script understands ':' as "xsltproc is not
> > # available".
> > HOST_VALA_CONF_ENV = ac_cv_path_XSLTPROC=:
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17
2024-06-01 20:22 ` James Hilliard
@ 2024-06-02 11:01 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2024-06-02 11:01 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
James, All,
On 2024-06-01 14:22 -0600, James Hilliard spake thusly:
> On Sat, Jun 1, 2024 at 2:03 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2024-05-31 14:22 -0600, James Hilliard spake thusly:
> > > Add new host-gobject-introspection dependency.
> > So, why is this minor version bump now requiring host-GOI?
> Well the requirement was added here, so it seems to only be used
> for finding girdir:
>
> vala: Follow the logic of GIrParser.locate_gir() to find gir files
> https://gitlab.gnome.org/GNOME/vala/-/commit/a9d38070ce86d7994b949f7cb426fbf670a953d8
But our vala-wrapper already passes the path to girdir:
$ cat package/vala/vala-wrapper
#!/bin/sh $0-@VALA_VERSION@ --vapidir=${STAGING_DIR}/usr/share/vala/vapi --girdir=${STAGING_DIR}/usr/share/gir-1.0 "$@"
In our situation, the girdir will always be ${STAGING_DIR}/usr/share/gir-1.0
and never anything else.
So adding host-GOI, which takes a while to build, as a dependency just
to get the contant value we already know, seems a little bit of an
overhead, no?
Can't we just pass GI_GIRDIR in the environment, as suggested in the
commit log you point at above?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-02 11:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-31 20:22 [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17 James Hilliard
2024-06-01 20:03 ` Yann E. MORIN
2024-06-01 20:22 ` James Hilliard
2024-06-02 11:01 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox