Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
@ 2024-06-13 11:39 yegorslists
  2024-06-13 11:51 ` Yegor Yefremov
  2024-06-16 11:22 ` Yann E. MORIN
  0 siblings, 2 replies; 7+ messages in thread
From: yegorslists @ 2024-06-13 11:39 UTC (permalink / raw)
  To: buildroot

From: Yegor Yefremov <yegorslists@googlemail.com>

Patches were taken from Gentoo:

https://bugs.gentoo.org/921487
https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch

Fixes:
http://autobuild.buildroot.net/results/058578eae885ce6e206c25b5a24aa11b625adf88/

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 .checkpackageignore                           |  2 +
 .../ncftp/0001-ncftp-3.2.7-fix-gcc14.patch    | 17 +++++
 .../ncftp/0002-ncftp-3.2.7-fix-clang.patch    | 70 +++++++++++++++++++
 3 files changed, 89 insertions(+)
 create mode 100644 package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
 create mode 100644 package/ncftp/0002-ncftp-3.2.7-fix-clang.patch

diff --git a/.checkpackageignore b/.checkpackageignore
index dd1fd31e86..52b5090034 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
 package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
 package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
 package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
+package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
+package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream
 package/ncmpc/0001-meson.build-add-atomic-dependency-for-sparc.patch lib_patch.Upstream
 package/ne10/0001-CMakeLists-don-t-hard-code-thumb-code-generation.patch lib_patch.Upstream
 package/ne10/0002-fix-build-without-C.patch lib_patch.Upstream
diff --git a/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch b/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
new file mode 100644
index 0000000000..f93abb1142
--- /dev/null
+++ b/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
@@ -0,0 +1,17 @@
+fix select arg detection
+
+Reference:
+ https://bugs.gentoo.org/921487
+
+Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
+--- a/autoconf_local/aclocal.m4
++++ b/autoconf_local/aclocal.m4
+@@ -4196,7 +4196,7 @@
+ #include <sys/select.h>
+ #endif
+ #include <sys/socket.h>	/* MG: always incl */
+-extern select ($ac_cv_func_select_arg1,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg5);],,dnl
++extern int select ($ac_cv_func_select_arg1,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg5);],,dnl
+         [ac_not_found=no ; break 3],ac_not_found=yes)
+       done
+      done
diff --git a/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch b/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
new file mode 100644
index 0000000000..8a71fa3284
--- /dev/null
+++ b/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
@@ -0,0 +1,70 @@
+Fix compilation with clang-16
+
+aclocal.m4 contains code that no longer compiles: missing headers and missing
+return types.
+
+Reference:
+ https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
+
+Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
+--- a/autoconf_local/aclocal.m4
++++ b/autoconf_local/aclocal.m4
+@@ -3057,6 +3057,7 @@
+ #include <sys/uio.h>
+ #include <sys/socket.h>
+ #include <sys/un.h>
++#include <string.h>
+ ],[
+ struct sockaddr_un uaddr;
+ 
+@@ -3285,6 +3286,7 @@
+ #ifdef HAVE_RESOLV_H
+ #	include <resolv.h>
+ #endif
++#include <string.h>
+ ],[
+ 	/* function-body */
+ 	int len;
+@@ -3363,6 +3365,7 @@
+ #include <stdio.h>
+ #include <stdlib.h>
+ 		 
++			int
+ 			main(int argc, char **argv)
+ 			{
+ 				/* Note:  don't actually call readline,
+@@ -5145,6 +5148,7 @@
+ #ifdef HAVE_STDLIB_H
+ #	include <stdlib.h>
+ #endif
++#include <string.h>
+ 
+ #ifdef HAVE_NCURSES_H
+ #	define NCURSES_OPAQUE 0
+@@ -5176,6 +5180,7 @@
+ #endif
+ 
+  
++int
+ main(int argc, char **argv)
+ {
+ 	/* Note:  don't actually call curses, since it may block;
+@@ -6510,7 +6515,6 @@
+ #endif
+ #endif			/* MG */
+ 
+-int
+ int  main(void)
+ {
+ 	char *data, *data2, *data3;
+@@ -6607,8 +6611,9 @@
+ 	AC_CACHE_CHECK(whether setvbuf arguments are reversed,
+ 	  ac_cv_func_setvbuf_reversed,
+ 	[AC_TRY_RUN([#include <stdio.h>
++	$include <stdlib.h>
+ 	/* If setvbuf has the reversed format, exit 0. */
+-	main () {
++	int main (void) {
+ 	  /* This call has the arguments reversed.
+ 	     A reversed system may check and see that the address of main
+ 	     is not _IOLBF, _IONBF, or _IOFBF, and return nonzero.  */
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
  2024-06-13 11:39 [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors yegorslists
@ 2024-06-13 11:51 ` Yegor Yefremov
  2024-06-16 11:43   ` Yann E. MORIN
  2024-06-16 11:22 ` Yann E. MORIN
  1 sibling, 1 reply; 7+ messages in thread
From: Yegor Yefremov @ 2024-06-13 11:51 UTC (permalink / raw)
  To: buildroot

Hi All,

On Thu, Jun 13, 2024 at 1:40 PM <yegorslists@googlemail.com> wrote:
>
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Patches were taken from Gentoo:
>
> https://bugs.gentoo.org/921487
> https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
>
> Fixes:
> http://autobuild.buildroot.net/results/058578eae885ce6e206c25b5a24aa11b625adf88/
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  .checkpackageignore                           |  2 +
>  .../ncftp/0001-ncftp-3.2.7-fix-gcc14.patch    | 17 +++++
>  .../ncftp/0002-ncftp-3.2.7-fix-clang.patch    | 70 +++++++++++++++++++
>  3 files changed, 89 insertions(+)
>  create mode 100644 package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
>  create mode 100644 package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
>
> diff --git a/.checkpackageignore b/.checkpackageignore
> index dd1fd31e86..52b5090034 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
>  package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
>  package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
>  package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
> +package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
> +package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream
>  package/ncmpc/0001-meson.build-add-atomic-dependency-for-sparc.patch lib_patch.Upstream
>  package/ne10/0001-CMakeLists-don-t-hard-code-thumb-code-generation.patch lib_patch.Upstream
>  package/ne10/0002-fix-build-without-C.patch lib_patch.Upstream
> diff --git a/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch b/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
> new file mode 100644
> index 0000000000..f93abb1142
> --- /dev/null
> +++ b/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
> @@ -0,0 +1,17 @@
> +fix select arg detection
> +
> +Reference:
> + https://bugs.gentoo.org/921487
> +
> +Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> +--- a/autoconf_local/aclocal.m4
> ++++ b/autoconf_local/aclocal.m4
> +@@ -4196,7 +4196,7 @@
> + #include <sys/select.h>
> + #endif
> + #include <sys/socket.h>       /* MG: always incl */
> +-extern select ($ac_cv_func_select_arg1,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg5);],,dnl
> ++extern int select ($ac_cv_func_select_arg1,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg5);],,dnl
> +         [ac_not_found=no ; break 3],ac_not_found=yes)
> +       done
> +      done
> diff --git a/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch b/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
> new file mode 100644
> index 0000000000..8a71fa3284
> --- /dev/null
> +++ b/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
> @@ -0,0 +1,70 @@
> +Fix compilation with clang-16
> +
> +aclocal.m4 contains code that no longer compiles: missing headers and missing
> +return types.
> +
> +Reference:
> + https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
> +
> +Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> +--- a/autoconf_local/aclocal.m4
> ++++ b/autoconf_local/aclocal.m4
> +@@ -3057,6 +3057,7 @@
> + #include <sys/uio.h>
> + #include <sys/socket.h>
> + #include <sys/un.h>
> ++#include <string.h>
> + ],[
> + struct sockaddr_un uaddr;
> +
> +@@ -3285,6 +3286,7 @@
> + #ifdef HAVE_RESOLV_H
> + #     include <resolv.h>
> + #endif
> ++#include <string.h>
> + ],[
> +       /* function-body */
> +       int len;
> +@@ -3363,6 +3365,7 @@
> + #include <stdio.h>
> + #include <stdlib.h>
> +
> ++                      int
> +                       main(int argc, char **argv)
> +                       {
> +                               /* Note:  don't actually call readline,
> +@@ -5145,6 +5148,7 @@
> + #ifdef HAVE_STDLIB_H
> + #     include <stdlib.h>
> + #endif
> ++#include <string.h>
> +
> + #ifdef HAVE_NCURSES_H
> + #     define NCURSES_OPAQUE 0
> +@@ -5176,6 +5180,7 @@
> + #endif
> +
> +
> ++int
> + main(int argc, char **argv)
> + {
> +       /* Note:  don't actually call curses, since it may block;
> +@@ -6510,7 +6515,6 @@
> + #endif
> + #endif                        /* MG */
> +
> +-int
> + int  main(void)
> + {
> +       char *data, *data2, *data3;
> +@@ -6607,8 +6611,9 @@
> +       AC_CACHE_CHECK(whether setvbuf arguments are reversed,
> +         ac_cv_func_setvbuf_reversed,
> +       [AC_TRY_RUN([#include <stdio.h>
> ++      $include <stdlib.h>
> +       /* If setvbuf has the reversed format, exit 0. */
> +-      main () {
> ++      int main (void) {
> +         /* This call has the arguments reversed.
> +            A reversed system may check and see that the address of main
> +            is not _IOLBF, _IONBF, or _IOFBF, and return nonzero.  */
> --
> 2.34.1

But the third problem remains and I don't know how to fix this:

spoolutil.c: In function ‘WriteSpoolEntry’:
spoolutil.c:286:38: error: passing argument 2 of ‘lstat’ from
incompatible pointer type [-Wincompatible-pointer-types]
  286 |                 if (lstat(lpathname, &st) == 0) {
      |                                      ^~~
      |                                      |
      |                                      struct stat64 *
In file included from
/home/user/buildroot/bsp-barebox/per-package/ncftp/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/features.h:503,
                 from
/home/user/buildroot/bsp-barebox/per-package/ncftp/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/unistd.h:25,
                 from syshdrs.h:143,
                 from spoolutil.c:8:
/home/user/buildroot/bsp-barebox/per-package/ncftp/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/sys/stat.h:327:12:
note: expected ‘struct stat * restrict’ but argument is of type
‘struct stat64 *’
  327 | extern int __REDIRECT_NTH (lstat,
      |            ^~~~~~~~~~~~~~

The toolchain was built via BR for armv7 and glibc. Any ideas? Why
should one use struct stat64 directly?

Regards,
Yegor
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
  2024-06-13 11:39 [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors yegorslists
  2024-06-13 11:51 ` Yegor Yefremov
@ 2024-06-16 11:22 ` Yann E. MORIN
  2024-06-16 11:42   ` Yegor Yefremov
  1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2024-06-16 11:22 UTC (permalink / raw)
  To: yegorslists; +Cc: buildroot

Yegor, All,

On 2024-06-13 13:39 +0200, yegorslists@googlemail.com spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Patches were taken from Gentoo:
> 
> https://bugs.gentoo.org/921487
> https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
> 
> Fixes:
> http://autobuild.buildroot.net/results/058578eae885ce6e206c25b5a24aa11b625adf88/

Thank you for your efforts in helping fix build failures! 👍

> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
[--SNIP--]
> diff --git a/.checkpackageignore b/.checkpackageignore
> index dd1fd31e86..52b5090034 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
>  package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
>  package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
>  package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
> +package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
> +package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream

Do not add an exclusion for new patches; instead, add an Upstream tag.

If the patches were not from upstream, then submit them and add the URL
to that submission as an Upstream tag; if the patches are not suitable
for upstream, then state so in the Upstream tag, and explain why.

See the manual:
    https://buildroot.org/downloads/manual/manual.html#_additional_patch_documentation

Could you rework this and resubmit, please?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
  2024-06-16 11:22 ` Yann E. MORIN
@ 2024-06-16 11:42   ` Yegor Yefremov
  2024-06-16 11:55     ` Yann E. MORIN
  0 siblings, 1 reply; 7+ messages in thread
From: Yegor Yefremov @ 2024-06-16 11:42 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot

Hi Yann, All,

On Sun, Jun 16, 2024 at 1:22 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Yegor, All,
>
> On 2024-06-13 13:39 +0200, yegorslists@googlemail.com spake thusly:
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > Patches were taken from Gentoo:
> >
> > https://bugs.gentoo.org/921487
> > https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/058578eae885ce6e206c25b5a24aa11b625adf88/
>
> Thank you for your efforts in helping fix build failures! 👍
>
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> [--SNIP--]
> > diff --git a/.checkpackageignore b/.checkpackageignore
> > index dd1fd31e86..52b5090034 100644
> > --- a/.checkpackageignore
> > +++ b/.checkpackageignore
> > @@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
> >  package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
> >  package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
> >  package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
> > +package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
> > +package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream
>
> Do not add an exclusion for new patches; instead, add an Upstream tag.
>
> If the patches were not from upstream, then submit them and add the URL
> to that submission as an Upstream tag; if the patches are not suitable
> for upstream, then state so in the Upstream tag, and explain why.
>
> See the manual:
>     https://buildroot.org/downloads/manual/manual.html#_additional_patch_documentation

The reason for the missing Upstream tag is that there is neither bug
tracker nor mailing list. The only communication channel is an e-mail
address. I have already sent both patches and asked gazillions of
questions but all was in vain :-(

> Could you rework this and resubmit, please?

I'll send v2. Thanks for your review.

Yegor
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
  2024-06-13 11:51 ` Yegor Yefremov
@ 2024-06-16 11:43   ` Yann E. MORIN
  0 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2024-06-16 11:43 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: buildroot

Yegor, All,

On 2024-06-13 13:51 +0200, Yegor Yefremov spake thusly:
[--SNIP--]
> But the third problem remains and I don't know how to fix this:
> 
> spoolutil.c: In function ‘WriteSpoolEntry’:
> spoolutil.c:286:38: error: passing argument 2 of ‘lstat’ from
> incompatible pointer type [-Wincompatible-pointer-types]
>   286 |                 if (lstat(lpathname, &st) == 0) {
>       |                                      ^~~
>       |                                      |
>       |                                      struct stat64 *
> In file included from
> /home/user/buildroot/bsp-barebox/per-package/ncftp/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/features.h:503,
>                  from
> /home/user/buildroot/bsp-barebox/per-package/ncftp/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/unistd.h:25,
>                  from syshdrs.h:143,
>                  from spoolutil.c:8:
> /home/user/buildroot/bsp-barebox/per-package/ncftp/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/sys/stat.h:327:12:
> note: expected ‘struct stat * restrict’ but argument is of type
> ‘struct stat64 *’
>   327 | extern int __REDIRECT_NTH (lstat,
>       |            ^~~~~~~~~~~~~~
> 
> The toolchain was built via BR for armv7 and glibc. Any ideas? Why
> should one use struct stat64 directly?

It looks like a little bit of magic to me, but what I take from the
__REDIRECT_NTH macro, is that it instructs the compiler (and linker) to
really redirect calls to lstat() to lstat64() instead (NTH) means no
throw, which is completely something else and of no conern here I
think).

So, it is again a misfit between 32-bit functions and 64-bit structure
(or the other way around).

I'vbe looked at the glibc source, and basically here is what it does in
bits/struct_stat.h:

    struct stat {
    #ifdef __USE_TIME_BITS64
    # include <bits/struct_stat_time64_helper.h>
    #else
    /* defines stat fields here ...*/
    #endif
    };

    #ifdef __USE_LARGEFILE64
    struct stat64{
    #ifdef __USE_TIME_BITS64
    # include <bits/struct_stat_time64_helper.h>
    #else
    /* defines stat64 fields here ...*/
    #endif
    };
    #endif

So, basically:

  - for 64-bit time, both structs are exactly the same.

  - for 32-bit time, they do differ, but the C library should do its
    magic:

    $ man lstat

    C library/kernel differences
        Over  time,  increases in the size of the stat structure have led
        to three successive versions of stat() [...]

        The  kernel-internal  versions  of the stat structure dealt with
        by the different versions are, respectively:

        __old_kernel_stat [...]
        stat [...]
        stat64 [...]

        The glibc stat() wrapper function hides these details from
        applications, invoking the most recent version of the system call
        provided by the kernel, and repacking the returned in‐ formation
        if required for old binaries.

With my limited understanding: "it should be fine!".

So yes, calls to lstat() should use struct stat. Or an explicit call to
lstat64() should be made, maybe?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
  2024-06-16 11:42   ` Yegor Yefremov
@ 2024-06-16 11:55     ` Yann E. MORIN
  2024-06-17  9:41       ` Yegor Yefremov
  0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2024-06-16 11:55 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: buildroot

Yegor, All,

On 2024-06-16 13:42 +0200, Yegor Yefremov spake thusly:
> On Sun, Jun 16, 2024 at 1:22 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > > diff --git a/.checkpackageignore b/.checkpackageignore
> > > index dd1fd31e86..52b5090034 100644
> > > --- a/.checkpackageignore
> > > +++ b/.checkpackageignore
> > > @@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
> > >  package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
> > >  package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
> > >  package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
> > > +package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
> > > +package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream
> >
> > Do not add an exclusion for new patches; instead, add an Upstream tag.
[--SNIP--]
> The reason for the missing Upstream tag is that there is neither bug
> tracker nor mailing list. The only communication channel is an e-mail
> address. I have already sent both patches and asked gazillions of
> questions but all was in vain :-(

Ah, now that I looked, it indeeds look bleak... :-(

In that case, state briefly so:

    Upstream: N/A, unresponsive contact email address

Thanks for trying! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
  2024-06-16 11:55     ` Yann E. MORIN
@ 2024-06-17  9:41       ` Yegor Yefremov
  0 siblings, 0 replies; 7+ messages in thread
From: Yegor Yefremov @ 2024-06-17  9:41 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot

Yann, All,

On Sun, Jun 16, 2024 at 1:55 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Yegor, All,
>
> On 2024-06-16 13:42 +0200, Yegor Yefremov spake thusly:
> > On Sun, Jun 16, 2024 at 1:22 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> [--SNIP--]
> > > > diff --git a/.checkpackageignore b/.checkpackageignore
> > > > index dd1fd31e86..52b5090034 100644
> > > > --- a/.checkpackageignore
> > > > +++ b/.checkpackageignore
> > > > @@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
> > > >  package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
> > > >  package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
> > > >  package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
> > > > +package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
> > > > +package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream
> > >
> > > Do not add an exclusion for new patches; instead, add an Upstream tag.
> [--SNIP--]
> > The reason for the missing Upstream tag is that there is neither bug
> > tracker nor mailing list. The only communication channel is an e-mail
> > address. I have already sent both patches and asked gazillions of
> > questions but all was in vain :-(
>
> Ah, now that I looked, it indeeds look bleak... :-(
>
> In that case, state briefly so:
>
>     Upstream: N/A, unresponsive contact email address
>
> Thanks for trying! :-)

I have sent v2. Meanwhile, I'll try to fix the stat64 issue.

Yegor
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-06-17  9:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-13 11:39 [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors yegorslists
2024-06-13 11:51 ` Yegor Yefremov
2024-06-16 11:43   ` Yann E. MORIN
2024-06-16 11:22 ` Yann E. MORIN
2024-06-16 11:42   ` Yegor Yefremov
2024-06-16 11:55     ` Yann E. MORIN
2024-06-17  9:41       ` Yegor Yefremov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox