* [Buildroot] [PATCH 1/1] package/mpd: fix shellcheck warnings
@ 2026-01-20 9:07 Andreas Ziegler
2026-01-20 15:00 ` J. Neuschäfer via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Ziegler @ 2026-01-20 9:07 UTC (permalink / raw)
To: buildroot; +Cc: Andreas Ziegler, Fiona Klute
Shellcheck commit 4f81dbe [1] added SC2329 (function is never invoked)
and fixed SC2317 (Command appears to be unreachable).
[1] https://github.com/koalaman/shellcheck/commit/4f81dbe839091a06a5cfaea695cf1c451ff07565
$ shellcheck package/mpd/S95mpd
In package/mpd/S95mpd line 13:
start() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
Change shellcheck exception number in header of S95mpd.
Signed-off-by: Andreas Ziegler <br025@umbiko.net>
---
package/mpd/S95mpd | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/mpd/S95mpd b/package/mpd/S95mpd
index ac971e04a2..481ee70a20 100644
--- a/package/mpd/S95mpd
+++ b/package/mpd/S95mpd
@@ -2,7 +2,7 @@
#
# S95mpd Starts Music Player daemon.
#
-# shellcheck disable=SC2317 # functions are called via variable
+# shellcheck disable=SC2329 # functions are called via variable
DAEMON="mpd"
PIDFILE="/var/run/$DAEMON.pid"
--
2.51.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/mpd: fix shellcheck warnings
2026-01-20 9:07 [Buildroot] [PATCH 1/1] package/mpd: fix shellcheck warnings Andreas Ziegler
@ 2026-01-20 15:00 ` J. Neuschäfer via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: J. Neuschäfer via buildroot @ 2026-01-20 15:00 UTC (permalink / raw)
To: Andreas Ziegler; +Cc: buildroot, Fiona Klute
On Tue, Jan 20, 2026 at 10:07:24AM +0100, Andreas Ziegler wrote:
> Shellcheck commit 4f81dbe [1] added SC2329 (function is never invoked)
> and fixed SC2317 (Command appears to be unreachable).
>
> [1] https://github.com/koalaman/shellcheck/commit/4f81dbe839091a06a5cfaea695cf1c451ff07565
>
> $ shellcheck package/mpd/S95mpd
>
> In package/mpd/S95mpd line 13:
> start() {
> ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
>
> Change shellcheck exception number in header of S95mpd.
>
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>
> ---
Looks good,
Reviewed-by: J. Neuschäfer <j.neuschaefer@gmx.net>
Thanks!
> package/mpd/S95mpd | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/mpd/S95mpd b/package/mpd/S95mpd
> index ac971e04a2..481ee70a20 100644
> --- a/package/mpd/S95mpd
> +++ b/package/mpd/S95mpd
> @@ -2,7 +2,7 @@
> #
> # S95mpd Starts Music Player daemon.
> #
> -# shellcheck disable=SC2317 # functions are called via variable
> +# shellcheck disable=SC2329 # functions are called via variable
>
> DAEMON="mpd"
> PIDFILE="/var/run/$DAEMON.pid"
> --
> 2.51.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-20 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-20 9:07 [Buildroot] [PATCH 1/1] package/mpd: fix shellcheck warnings Andreas Ziegler
2026-01-20 15:00 ` J. Neuschäfer via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox