Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/5] package/stellarium: fix qt5serialport dependency
@ 2026-05-01 18:34 Bernd Kuhls
  2026-05-01 18:34 ` [Buildroot] [PATCH 2/5] package/stellarium: bump version to 26.1 Bernd Kuhls
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Bernd Kuhls @ 2026-05-01 18:34 UTC (permalink / raw)
  To: buildroot; +Cc: Jesse Van Gavere, Roy Kollen Svendsen, Thomas Petazzoni

qt5serialport is only needed when GPS support is enabled:
https://github.com/Stellarium/stellarium/blob/v26.1/CMakeLists.txt#L632

A backport to the LTS branches should be considered, the wrong order of
dependencies in buildroot exists for years and is not caused by recent
upstream changes.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/stellarium/stellarium.mk | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/package/stellarium/stellarium.mk b/package/stellarium/stellarium.mk
index 660d518860..48dadfec61 100644
--- a/package/stellarium/stellarium.mk
+++ b/package/stellarium/stellarium.mk
@@ -32,11 +32,8 @@ else
 STELLARIUM_CONF_OPTS += -DENABLE_SCRIPTING=OFF
 endif
 
-ifeq ($(BR2_PACKAGE_QT5SERIALPORT),y)
-STELLARIUM_DEPENDENCIES += qt5serialport
-ifeq ($(BR2_PACKAGE_GPSD),y)
-STELLARIUM_DEPENDENCIES += gpsd
-endif
+ifeq ($(BR2_PACKAGE_GPSD)$(BR2_PACKAGE_QT5SERIALPORT),yy)
+STELLARIUM_DEPENDENCIES += gpsd qt5serialport
 STELLARIUM_CONF_OPTS += -DENABLE_GPS=ON
 else
 STELLARIUM_CONF_OPTS += -DENABLE_GPS=OFF
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-05-29 21:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 18:34 [Buildroot] [PATCH 1/5] package/stellarium: fix qt5serialport dependency Bernd Kuhls
2026-05-01 18:34 ` [Buildroot] [PATCH 2/5] package/stellarium: bump version to 26.1 Bernd Kuhls
2026-05-01 18:34 ` [Buildroot] [PATCH 3/5] package/stellarium: add extra downloads Bernd Kuhls
2026-05-29 21:20   ` Thomas Petazzoni via buildroot
2026-05-01 18:34 ` [Buildroot] [PATCH 4/5] package/qt6/qt6positioning: new package Bernd Kuhls
2026-05-01 18:34 ` [Buildroot] [PATCH 5/5] package/stellarium: allow build with qt6 Bernd Kuhls
2026-05-29 18:37 ` [Buildroot] [PATCH 1/5] package/stellarium: fix qt5serialport dependency Thomas Petazzoni via buildroot
2026-05-29 19:13   ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox