Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/5] package/stellarium: fix qt5serialport dependency
@ 2026-05-30 15:57 Bernd Kuhls
  2026-05-30 15:57 ` [Buildroot] [PATCH v2 2/5] package/stellarium: add extra downloads Bernd Kuhls
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Bernd Kuhls @ 2026-05-30 15:57 UTC (permalink / raw)
  To: buildroot; +Cc: Jesse Van Gavere, Roy Kollen Svendsen, Thomas Petazzoni

qt5serialport is only needed when GPS support is enabled:
https://github.com/Stellarium/stellarium/blob/v25.4/CMakeLists.txt#L623

Please note that we disable telescope support by default so only gpsd
enables the usage of qt5serialport.

A backport to the LTS branches should be considered, adding
qt5serialport as dependency without gpsd support causes the unneeded
build of qt5serialport for stellarium. This situation exists for years
and is not caused by recent upstream changes.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v2: rephrased commit message
    Series passed qt5-based Gitlab pipelines:
    https://gitlab.com/bkuhls/buildroot/-/commits/d4c3a7f6096e3dc48fa33a27c697d76fc3f38d48

 package/stellarium/stellarium.mk | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/package/stellarium/stellarium.mk b/package/stellarium/stellarium.mk
index 660d518860..48dadfec61 100644
--- a/package/stellarium/stellarium.mk
+++ b/package/stellarium/stellarium.mk
@@ -32,11 +32,8 @@ else
 STELLARIUM_CONF_OPTS += -DENABLE_SCRIPTING=OFF
 endif
 
-ifeq ($(BR2_PACKAGE_QT5SERIALPORT),y)
-STELLARIUM_DEPENDENCIES += qt5serialport
-ifeq ($(BR2_PACKAGE_GPSD),y)
-STELLARIUM_DEPENDENCIES += gpsd
-endif
+ifeq ($(BR2_PACKAGE_GPSD)$(BR2_PACKAGE_QT5SERIALPORT),yy)
+STELLARIUM_DEPENDENCIES += gpsd qt5serialport
 STELLARIUM_CONF_OPTS += -DENABLE_GPS=ON
 else
 STELLARIUM_CONF_OPTS += -DENABLE_GPS=OFF
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-06-05 12:49 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-30 15:57 [Buildroot] [PATCH v2 1/5] package/stellarium: fix qt5serialport dependency Bernd Kuhls
2026-05-30 15:57 ` [Buildroot] [PATCH v2 2/5] package/stellarium: add extra downloads Bernd Kuhls
2026-05-30 20:36   ` Thomas Petazzoni via buildroot
2026-06-05 12:49   ` Thomas Perale via buildroot
2026-05-30 15:57 ` [Buildroot] [PATCH v2 3/5] package/stellarium: bump version to 26.1 Bernd Kuhls
2026-05-30 20:46   ` Thomas Petazzoni via buildroot
2026-05-30 15:57 ` [Buildroot] [PATCH v2 4/5] package/qt6/qt6positioning: new package Bernd Kuhls
2026-05-30 21:15   ` Thomas Petazzoni via buildroot
2026-05-30 15:57 ` [Buildroot] [PATCH v2 5/5] package/stellarium: allow build with qt6 Bernd Kuhls
2026-05-30 21:20   ` Thomas Petazzoni via buildroot
2026-05-30 20:33 ` [Buildroot] [PATCH v2 1/5] package/stellarium: fix qt5serialport dependency Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox