Re: [Buildroot] [PATCH v2 04/11] support/testing: add test data for mpd (1/6)

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Andreas Ziegler <br025@umbiko.net>
Cc: buildroot@buildroot.org, Marcus Hoffmann <buildroot@bubu1.eu>
Subject: Re: [Buildroot] [PATCH v2 04/11] support/testing: add test data for mpd (1/6)
Date: Sat, 15 Aug 2026 21:41:32 +0200	[thread overview]
Message-ID: <aoDASYp4PBJt3wCJ@windsurf> (raw)
In-Reply-To: <20260709110822.305873-5-br025@umbiko.net>

Hello Andreas,

On Thu, Jul 09, 2026 at 01:08:08PM +0200, Andreas Ziegler wrote:
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>
> ---
> Changes v1 -> v2:
> 	separate test data from test scripts
> 	create archive chunks of test data that are re-combined during build

I am sorry but unfortunately, I disagree with the addition of such
significant obscure binary blobs in Buildroot, for two reasons:

1. It adds a significant weight (in terms of size) to Buildroot if
   each and every test comes with 1 MB of test data

2. There is no way to know/verify what this obscure binary data
   is. When I saw your patches the immediate thing that came to my
   mind is: "it looks like the xz backdoor where some obscure test
   data was used to sneak in some malicious code".

So I don't know what this data is, but instead you have two options:

1. Generate it at run-time during the test, if at all possible

2. Create a Buildroot package that downloads test data. "mpd" probably
   needs music, so you can create a Buildroot package in a
   br2-external inside the mpd test that downloads a bunch of music
   files, and puts them inside the test root filesystem.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot