Re: [Buildroot] [PATCH v2 03/11] package/mpd: reorder config items based on order in meson_options.txt

[Andreas Ziegler <br025@umbiko.net>]

Hi Thomas, Everyone,

On 2026-08-15 19:38, Thomas Petazzoni wrote:
> Hello Andreas,
> 
> On Thu, Jul 09, 2026 at 01:08:07PM +0200, Andreas Ziegler wrote:
>> MPD has 99 configurable options; of these, 44 are exposed in 
>> Buildroot's
>> Config.in. Sort order and grouping of these options are different 
>> within
>> the MPD project and Buildroot, which makes a comparison difficult.
>> 
>> Reorder entries in Config.in to reflect their order in 
>> meson_options.txt.
>> Also update at least some of the help texts to more closely resemble 
>> what
>> is published in the MPD manual.
> 
> Thanks for your patch.
> 
> The Buildroot policy in terms of sorting options in Config.in is
> rather "alphabetic ordering" and not "whatever order is used in the
> upstream meson_options.txt or configure.ac".

The original order in the mpd Config.in was by functional groups. These 
are indeed sorted alphabetical. Using the meson_options.txt order would 
make comparisons much easier ...

> Note that it is very possible that alphabetic ordering is already
> broken, in which case it would be totally OK to fix. But we will
> prefer to keep alphabetic ordering vs. meson_options.txt
> ordering. This is most notably to have a consistent policy between all
> our packages.

I will leave the file as-is for now.

> Best regards,
> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot