Re: [Buildroot] [PATCH v2 00/11] add runtime test for mpd

[Fiona Klute via buildroot <buildroot@buildroot.org>]

Hi Andreas,

thank you for working on these tests!

Am 09.07.26 um 13:08 schrieb Andreas Ziegler:
> Testing MPD in a real world situation is fairly straightforward: build,
> deploy, play some music. Representing this simple test within a test
> framework is quite complex.
> 
> I tried to break down my simple test case into a few atomic steps that
> interact with MPD via the built-in protocol. The necessary test data was
> generated with ffmpeg and imagemagick and is royalty-free :-D
> 
> In good old usenet tradition, test data had to be split in archive
> chunks, to overcome the limitations of the mailing list. The data will
> be re-combined in a post-build script.

I don't like the idea of adding a bunch of binary test data to the 
repository. Why not generate it as part of the test or build? Sure, 
adding ffmpeg/imagemagick to the config would make the build heavier, 
but having a clearly visible generation command and no binary data in 
the repository seems more important to me.

Best regards,
Fiona

> Working on this also triggered some changes in the Buildroot setup:
> 
> The configuration file supplied by Buildroot is only a sample; it will not
> start MPD on a default installation. Usually a custom mpd.conf is supplied
> in a rootfs overlay. Drop the Buildroot configuration file and install the
> sample supplied by MPD instead, it is more complete, contains useful
> examples and is update regularly.
> 
> After various updates since version 0.20, most dependencies placing
> restrictions on sub-components are now superseded by restrictions placed on
> MPD itself. Example: io_uring needs kernel headers > 5.1; MPD needs kernel
> headers > 5.6. Remove dependencies from sub-options if they are already
> imposed on MPD.
> 
> MPD has 99 configurable options; of these, 44 are exposed in Buildroot's
> Config.in. Sort order and grouping of these options are different within
> the MPD project and Buildroot, which makes a comparison difficult.
> Reorder entries in Config.in to reflect their order in meson_options.txt.
> Also update at least some of the help texts to more closely resemble what
> is published in the MPD manual.
> 
> Changes v1 -> v2:
> 	split test data in chunks to overcome mailing list restrictions
> 
> Andreas Ziegler (11):
>    package/mpd: install provided sample configuration file as mpd.conf
>    package/mpd: remove duplicated dependencies from sub-options
>    package/mpd: reorder config items based on order in meson_options.txt
>    support/testing: add test data for mpd
>    support/testing: add test data for mpd
>    support/testing: add test data for mpd
>    support/testing: add test data for mpd
>    support/testing: add test data for mpd
>    support/testing: add test data for mpd
>    support/testing: add runtime test for mpd
>    DEVELOPERS: add entry for test_mpd
> 
>   DEVELOPERS                                    |   2 +
>   package/mpd/Config.in                         | 364 +++++++++---------
>   package/mpd/mpd.conf                          |  32 --
>   package/mpd/mpd.mk                            |   2 +-
>   support/testing/tests/package/test_mpd.py     |  57 +++
>   .../tests/package/test_mpd/_test_data0        | Bin 0 -> 223630 bytes
>   .../tests/package/test_mpd/_test_data1        | Bin 0 -> 223630 bytes
>   .../tests/package/test_mpd/_test_data2        | Bin 0 -> 223630 bytes
>   .../tests/package/test_mpd/_test_data3        | Bin 0 -> 223630 bytes
>   .../tests/package/test_mpd/_test_data4        | Bin 0 -> 223630 bytes
>   .../tests/package/test_mpd/_test_data5        | Bin 0 -> 223630 bytes
>   .../tests/package/test_mpd/busybox.fragment   |   4 +
>   .../tests/package/test_mpd/post-build.sh      |   6 +
>   .../test_mpd/rootfs-overlay/etc/mpd.conf      |  14 +
>   .../test_mpd/rootfs-overlay/root/test_mpd.sh  |  74 ++++
>   15 files changed, 348 insertions(+), 207 deletions(-)
>   delete mode 100644 package/mpd/mpd.conf
>   create mode 100644 support/testing/tests/package/test_mpd.py
>   create mode 100644 support/testing/tests/package/test_mpd/_test_data0
>   create mode 100644 support/testing/tests/package/test_mpd/_test_data1
>   create mode 100644 support/testing/tests/package/test_mpd/_test_data2
>   create mode 100644 support/testing/tests/package/test_mpd/_test_data3
>   create mode 100644 support/testing/tests/package/test_mpd/_test_data4
>   create mode 100644 support/testing/tests/package/test_mpd/_test_data5
>   create mode 100644 support/testing/tests/package/test_mpd/busybox.fragment
>   create mode 100755 support/testing/tests/package/test_mpd/post-build.sh
>   create mode 100644 support/testing/tests/package/test_mpd/rootfs-overlay/etc/mpd.conf
>   create mode 100755 support/testing/tests/package/test_mpd/rootfs-overlay/root/test_mpd.sh
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot