From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Andreas Ziegler <br025@umbiko.net>
Cc: buildroot@buildroot.org, Marcus Hoffmann <buildroot@bubu1.eu>
Subject: Re: [Buildroot] [PATCH v4 1/2] package/mpd: remove unused, add mandatory configuration items
Date: Sat, 5 Sep 2026 16:14:23 +0200 [thread overview]
Message-ID: <apwjYdxffhgRv79A@windsurf> (raw)
In-Reply-To: <20260905040256.2221199-2-br025@umbiko.net>
Hello Andreas,
On Sat, Sep 05, 2026 at 06:02:52AM +0200, Andreas Ziegler wrote:
> The configuration file supplied by Buildroot is only a sample; it will
> not start MPD on a default installation. In a production build, a custom
> mpd.conf has to be supplied via rootfs overlay or on the target system.
>
> Supply the necessary configuration items to start mpd in a default build,
> and discard unused customizations.
>
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>
Thanks for the new iteration.
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 1b6815e904..bbd6fc16e5 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -119,7 +119,6 @@ config BR2_PACKAGE_MPD_LIBSNDFILE
>
> config BR2_PACKAGE_MPD_MAD
> bool "mad"
> - default y
Why?
> select BR2_PACKAGE_MPD_ID3TAG
> select BR2_PACKAGE_LIBMAD
> help
> @@ -244,7 +243,6 @@ comment "Output plugins"
>
> config BR2_PACKAGE_MPD_ALSA
> bool "alsa"
> - default y
Why?
These changes are not really explained in your commit message. Also
this change will break existing defconfigs that assume those options
"default y". Is it important to change this? (Even though I agree they
should not have been "default y" in the first place).
> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
> index 4db0aee7cb..5852bbe73f 100644
> --- a/package/mpd/mpd.mk
> +++ b/package/mpd/mpd.mk
> @@ -347,8 +347,6 @@ endif
>
> define MPD_INSTALL_EXTRA_FILES
> $(INSTALL) -m 0644 -D package/mpd/mpd.conf $(TARGET_DIR)/etc/mpd.conf
> - mkdir -p $(TARGET_DIR)/var/lib/mpd/music
> - mkdir -p $(TARGET_DIR)/var/lib/mpd/playlists
Why is that no longer needed? Because of the configuration file
change? Or because it was bogus/useless anyway?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-09-05 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 4:02 [Buildroot] [PATCH v4 0/2] Add runtime test for mpd Andreas Ziegler
2026-09-05 4:02 ` [Buildroot] [PATCH v4 1/2] package/mpd: remove unused, add mandatory configuration items Andreas Ziegler
2026-09-05 14:14 ` Thomas Petazzoni via buildroot [this message]
2026-09-06 4:34 ` Andreas Ziegler
2026-09-05 4:02 ` [Buildroot] [PATCH v4 2/2] support/testing: add runtime test for mpd Andreas Ziegler
2026-09-05 14:17 ` Thomas Petazzoni via buildroot
2026-09-06 4:54 ` Andreas Ziegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apwjYdxffhgRv79A@windsurf \
--to=buildroot@buildroot.org \
--cc=br025@umbiko.net \
--cc=buildroot@bubu1.eu \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox