Re: [Buildroot] [PATCH v4 2/2] support/testing: add runtime test for mpd

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Andreas,

On Sat, Sep 05, 2026 at 06:02:53AM +0200, Andreas Ziegler wrote:
> The test determines if mpd was started by the init system by querying
> mpd status via the built-in protocol and evaluating the result.
> 
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>

Thanks for this new iteration!

> new file mode 100755
> index 0000000000..4cc6895602
> --- /dev/null
> +++ b/support/testing/tests/package/test_mpd/rootfs-overlay/root/test_mpd.sh
> @@ -0,0 +1,35 @@
> +#!/bin/sh
> +
> +mpd_command() {
> +	mpd_result=""
> +	mpd_state=""
> +	printf "Execute %s" "$1"
> +	while IFS= read -r line; do
> +		case $line in
> +			OK) 						mpd_result=$line ;;
> +			OK\ MPD*)					mpd_protocol=${line##* } ;;
> +			state:*)					mpd_state=${line##*: } ;;
> +			ACK\ \[[0-9]*@[0-9]*\]*)	mpd_error=${line##*\} } ;;
> +		esac
> +	done <<- EOF

Why are we "hacking" a minimal mpd client here instead of adding
mpd-mpc to the image and using it to test mpd?

> +	export mpd_protocol
> +	export mpd_state

Why does this needs to be exported?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot