Re: [Buildroot] [PATCH v4 1/2] package/mpd: remove unused, add mandatory configuration items

[Andreas Ziegler <br025@umbiko.net>]

Hi Thomas,

On 2026-09-05 14:14, Thomas Petazzoni wrote:
> Hello Andreas,
> 
> On Sat, Sep 05, 2026 at 06:02:52AM +0200, Andreas Ziegler wrote:
>> The configuration file supplied by Buildroot is only a sample; it will
>> not start MPD on a default installation. In a production build, a 
>> custom
>> mpd.conf has to be supplied via rootfs overlay or on the target 
>> system.
>> 
>> Supply the necessary configuration items to start mpd in a default 
>> build,
>> and discard unused customizations.
>> 
>> Signed-off-by: Andreas Ziegler <br025@umbiko.net>
> 
> Thanks for the new iteration.
> 
>> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
>> index 1b6815e904..bbd6fc16e5 100644
>> --- a/package/mpd/Config.in
>> +++ b/package/mpd/Config.in
>> @@ -119,7 +119,6 @@ config BR2_PACKAGE_MPD_LIBSNDFILE
>> 
>>  config BR2_PACKAGE_MPD_MAD
>>  	bool "mad"
>> -	default y
> 
> Why?

This is an optional component. It was never used by any Buildroot, in a 
user configuration it is also optional. I was always wondering why I was 
never able to get rid of this library ... It was also never used by the 
Buildroot configuration.

> 
>>  	select BR2_PACKAGE_MPD_ID3TAG
>>  	select BR2_PACKAGE_LIBMAD
>>  	help
>> @@ -244,7 +243,6 @@ comment "Output plugins"
>> 
>>  config BR2_PACKAGE_MPD_ALSA
>>  	bool "alsa"
>> -	default y
> 
> Why?

Also optional, a MPD server or a streaming setup will never use local 
output. Also, other output options might be selected. The buildroot 
configuration never contained an output section, so this was unused.

> 
> These changes are not really explained in your commit message. Also
> this change will break existing defconfigs that assume those options
> "default y". Is it important to change this? (Even though I agree they
> should not have been "default y" in the first place).

It may break a few, but also fix other configurations; I always have to 
check my own configs after running make defconfig. It will remove some 
of the complexity from Buildroot's mpd setup (and it handles only ~50% 
of available options).

>> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
>> index 4db0aee7cb..5852bbe73f 100644
>> --- a/package/mpd/mpd.mk
>> +++ b/package/mpd/mpd.mk
>> @@ -347,8 +347,6 @@ endif
>> 
>>  define MPD_INSTALL_EXTRA_FILES
>>  	$(INSTALL) -m 0644 -D package/mpd/mpd.conf 
>> $(TARGET_DIR)/etc/mpd.conf
>> -	mkdir -p $(TARGET_DIR)/var/lib/mpd/music
>> -	mkdir -p $(TARGET_DIR)/var/lib/mpd/playlists
> 
> Why is that no longer needed? Because of the configuration file
> change? Or because it was bogus/useless anyway?

/var/lib/mpd was the standard place where MPD used to place its files. 
But /var/lib is part of the root mount, you should not put music data 
there. The MPD manual itself advises to check and change this setting.  
Stored playlists are an optional component, and not every setup uses 
them. The full set of directories might have been necessary in the 
beginning, but became obsolete when MPD added remote database access in 
version 0.21.

> Thanks!
> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot