[Buildroot] [PATCH 1/1] package/nnn: bump to version 5.3

[Buildroot] [PATCH 1/1] package/nnn: bump to version 5.3

[Alexander Shirokov]

This commit updates the package version to 5.3.

Changelog: https://github.com/jarun/nnn/blob/v5.3/CHANGELOG

It also brings some improvements.

1. Adds libatomic dependency, as the library is required since commit
7ce4913bc39bc3b34a0e2c3de7153fb09d489152.

2. Adds a dependency on BR2_TOOLCHAIN_HAS_THREADS to prevent failures
in test-pkg.

3. Replaces a symbol in Config.in to make the file ASCII-only.

Signed-off-by: Alexander Shirokov <shirokovalexs@gmail.com>
---
 package/nnn/Config.in | 4 +++-
 package/nnn/nnn.hash  | 4 ++--
 package/nnn/nnn.mk    | 8 +++++---
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/package/nnn/Config.in b/package/nnn/Config.in
index 64cfa8e0a5..eb409677a0 100644
--- a/package/nnn/Config.in
+++ b/package/nnn/Config.in
@@ -1,9 +1,11 @@
 config BR2_PACKAGE_NNN
 	bool "nnn"
 	depends on BR2_USE_MMU # fork
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	# Building nnn without widechar/UTF support is theoretically
 	# possible, but in practice it leads to unstable builds.
-	# That’s why the WCHAR dependency is here.
+	# That's why the WCHAR dependency is here.
 	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_NCURSES
 	select BR2_PACKAGE_NCURSES_WCHAR
diff --git a/package/nnn/nnn.hash b/package/nnn/nnn.hash
index 670a591afb..11041e8b9d 100644
--- a/package/nnn/nnn.hash
+++ b/package/nnn/nnn.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  9faaff1e3f5a2fd3ed570a83f6fb3baf0bfc6ebd6a9abac16203d057ac3fffe3  nnn-5.1.tar.gz
-sha256  829f485dc4f2f51c2471b36a99e22f15ff214966e16b72cd79768b2338b4132b  LICENSE
+sha256  79ee69f3ced7c0778d207df76b4d4d680636975ccda002eeb19d0917fcba3d36  nnn-5.3.tar.gz
+sha256  209238e9eff3997a4e43176dadf7e41e71f07784d1a6c8d89380777976f5e2dc  LICENSE
diff --git a/package/nnn/nnn.mk b/package/nnn/nnn.mk
index acbd0ce314..0ceebe8261 100644
--- a/package/nnn/nnn.mk
+++ b/package/nnn/nnn.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-NNN_VERSION = 5.1
+NNN_VERSION = 5.3
 NNN_LICENSE = BSD-2-Clause
 NNN_LICENSE_FILES = LICENSE
 NNN_SITE = $(call github,jarun,nnn,v$(NNN_VERSION))
@@ -15,10 +15,12 @@ NNN_MAKE_FLAGS = \
 	CFLAGS_OPTIMIZATION= \
 	PREFIX=/usr
 
+# Must be passed in env so it can be appended to by the Makefile
+NNN_MAKE_ENV += LDLIBS="-latomic"
+
 ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
 NNN_DEPENDENCIES += musl-fts
-# Must be passed in env so it can be appended to by the Makefile
-NNN_MAKE_ENV += LDLIBS="-lfts"
+NNN_MAKE_ENV += LDLIBS="-lfts -latomic"
 endif
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/nnn: bump to version 5.3

[Thomas Petazzoni via buildroot]

Hello,

Thanks for your patch! A number of questions/comments below.

On Mon, Sep 07, 2026 at 09:45:37PM +0200, Alexander Shirokov wrote:
> This commit updates the package version to 5.3.
> 
> Changelog: https://github.com/jarun/nnn/blob/v5.3/CHANGELOG
> 
> It also brings some improvements.
> 
> 1. Adds libatomic dependency, as the library is required since commit
> 7ce4913bc39bc3b34a0e2c3de7153fb09d489152.

Is this upstream commit part of this version bump 5.1 -> 5.3, or did
it already exist?

> 
> 2. Adds a dependency on BR2_TOOLCHAIN_HAS_THREADS to prevent failures
> in test-pkg.

Is this new dependency needed because of the version bump, or was it
already needed with version 5.1?

If some of those topics are independent from the version bump, they
should be in a separate commit.


> config BR2_PACKAGE_NNN
> 	bool "nnn"
> 	depends on BR2_USE_MMU # fork
>+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
>+	depends on BR2_TOOLCHAIN_HAS_THREADS

This needs an update of the Config.in comment:

comment "nnn needs a toolchain with wchar"
        depends on BR2_USE_MMU # fork
        depends on !BR2_USE_WCHAR

should become:

comment "nnn needs a toolchain with wchar, threads"
        depends on BR2_USE_MMU # fork
	depends on BR2_TOOLCHAIN_HAS_ATOMIC
        depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

>  ################################################################################
>  
> -NNN_VERSION = 5.1
> +NNN_VERSION = 5.3
>  NNN_LICENSE = BSD-2-Clause
>  NNN_LICENSE_FILES = LICENSE
>  NNN_SITE = $(call github,jarun,nnn,v$(NNN_VERSION))
> @@ -15,10 +15,12 @@ NNN_MAKE_FLAGS = \
>  	CFLAGS_OPTIMIZATION= \
>  	PREFIX=/usr
>  
> +# Must be passed in env so it can be appended to by the Makefile
> +NNN_MAKE_ENV += LDLIBS="-latomic"

Should be conditional on BR2_TOOLCHAIN_HAS_LIBATOMIC.

>  ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
>  NNN_DEPENDENCIES += musl-fts
> -# Must be passed in env so it can be appended to by the Makefile
> -NNN_MAKE_ENV += LDLIBS="-lfts"
> +NNN_MAKE_ENV += LDLIBS="-lfts -latomic"

We want to avoid duplicating this.

>  endif

So probably:

ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
NNN_LDLIBS = -latomic
endif

ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
NNN_DEPENDENCIES += musl-fts
NNN_LDLIBS += -lfts
endif

NNN_MAKE_ENV += LDLIBS="$(NNN_LDLIBS)"

Could you have a look at sending a new version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/nnn: bump to version 5.3

[Alexander Shirokov]

Hello Thomas,

Thank you for the review and detailed feedback.

> > 1. Adds libatomic dependency, as the library is required since commit
> > 7ce4913bc39bc3b34a0e2c3de7153fb09d489152.
> 
> Is this upstream commit part of this version bump 5.1 -> 5.3, or did
> it already exist?

Yes, it is part of the version bump. This commit is from 1 Feb 2026, while 5.1
is from 23 Mar 2025. It updates some functionality and adds the use of atomics.

	#if defined(__GNUC__) || defined(__clang__)
	       /* Relaxed ordering is sufficient: only need atomicity for this bitmap */
	       ullong_t old = __atomic_fetch_or(m, bit, __ATOMIC_RELAXED);
	       return (old & bit) == 0;
	#else

In newer versions (5.2 and 5.3) atomics are needed. Otherwise, builds may fail
on some toolchains. For example:

	/home/user/br-test-pkg/bootlin-sh4-uclibc/host/opt/ext-toolchain/bin/../lib/gcc/
	sh4-buildroot-linux-uclibc/14.3.0/../../../../sh4-buildroot-linux-uclibc/bin/ld:
	/tmp/cc1CMtRl.o: in function `du_walk_dir.constprop.0':
	nnn.c:(.text+0x8d7c): undefined reference to `__atomic_fetch_or_8'
	collect2: error: ld returned 1 exit status

So I added the atomics dependency explicitly to avoid such failures.

> > 
> > 2. Adds a dependency on BR2_TOOLCHAIN_HAS_THREADS to prevent failures
> > in test-pkg.
> 
> Is this new dependency needed because of the version bump, or was it
> already needed with version 5.1?
> 
> If some of those topics are independent from the version bump, they
> should be in a separate commit.

Here we have the opposite situation. Both old and new versions of nnn use
pthreads. Adding BR2_TOOLCHAIN_HAS_THREADS is not connected with the version
bump. It just fixes my mistake: the dependency was missing in 5.1. As a result,
the build may fail on some toolchains, like br-arm-full-nothread. Sorry.

	/home/user/br-test-pkg/br-arm-full-nothread/host/bin/arm-linux-gcc
	-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DNORL
	-DDIM_FILTERED -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
	-O2 -g0  -std=c11 -Wall -Wextra -Wshadow  -D_GNU_SOURCE -DNCURSES_WIDECHAR  -o
	nnn  src/nnn.c -lfts -latomic -lncursesw -lpthread
	src/nnn.c:84:10: fatal error: pthread.h: No such file or directory
	   84 | #include <pthread.h>

I'll send a separate small patch to fix that for 5.1. Then I'll prepare and send
a version bump patch with only the changes related to the bump.


Regards,
Alexander

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/nnn: bump to version 5.3

[Thomas Petazzoni via buildroot]

Hello,

On Sat, Sep 19, 2026 at 04:19:35PM +0200, Alexander Shirokov wrote:

> I'll send a separate small patch to fix that for 5.1. Then I'll prepare and send
> a version bump patch with only the changes related to the bump.

Thanks a lot for your super detailed feedback, looking forward to your
next iteration!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot