[Buildroot] [PATCH] package/umtprd: expose package build options

[Buildroot] [PATCH] package/umtprd: expose package build options

[Nevo Hed via buildroot]

Primary impetus: BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY:
    By default umtprd does not communicate daemon readyness.  Version
    1.6.8 added a build option that enables creating a Type=notify
    systemd service.

Added two other relevant build options that were available in the
Makefile:
- BR2_PACKAGE_UMTPRD_DEBUG
- BR2_PACKAGE_UMTPRD_SYSLOG

Signed-off-by: Nevo Hed <nhed+buildroot@starry.com>
---
 package/umtprd/Config.in | 19 ++++++++++++++++++-
 package/umtprd/umtprd.mk | 14 +++++++++++++-
 2 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/package/umtprd/Config.in b/package/umtprd/Config.in
index 24bf119549..dff5a44583 100644
--- a/package/umtprd/Config.in
+++ b/package/umtprd/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_UMTPRD
+menuconfig BR2_PACKAGE_UMTPRD
 	bool "umtprd"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15
@@ -7,5 +7,22 @@ config BR2_PACKAGE_UMTPRD
 
 	  https://github.com/viveris/uMTP-Responder
 
+if BR2_PACKAGE_UMTPRD
+
+if BR2_PACKAGE_SYSTEMD
+
+config BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY
+	bool "Tell Systemd when uMTP-Responder is ready "
+
+endif
+
+config BR2_PACKAGE_UMTPRD_DEBUG
+	bool "Enable debug"
+
+config BR2_PACKAGE_UMTPRD_SYSLOG
+	bool "Send output to syslog"
+
+endif
+
 comment "umtprd needs a toolchain w/ threads, headers >= 3.15"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15
diff --git a/package/umtprd/umtprd.mk b/package/umtprd/umtprd.mk
index 1a2b387219..06c75d5c55 100644
--- a/package/umtprd/umtprd.mk
+++ b/package/umtprd/umtprd.mk
@@ -9,8 +9,20 @@ UMTPRD_SITE = https://github.com/viveris/uMTP-Responder/archive
 UMTPRD_LICENSE = GPL-3.0+
 UMTPRD_LICENSE_FILES = LICENSE
 
+ifneq ($(BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY),"")
+UMTPRD_BUILD_OPTS += SYSTEMD=1
+endif
+
+ifneq ($(BR2_PACKAGE_UMTPRD_DEBUG),"")
+UMTPRD_BUILD_OPTS += DEBUG=1
+endif
+
+ifneq ($(BR2_PACKAGE_UMTPRD_SYSLOG),"")
+UMTPRD_BUILD_OPTS += USE_SYSLOG=1
+endif
+
 define UMTPRD_BUILD_CMDS
-	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) $(UMTPRD_BUILD_OPTS)
 endef
 
 define UMTPRD_INSTALL_TARGET_CMDS
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/umtprd: expose package build options

[Thomas Petazzoni via buildroot]

Hello Nevo,

Thanks a lot for your patch, and sorry for the delay! See below some
review.

On Thu, Jun 04, 2026 at 09:14:01PM +0000, Nevo Hed via buildroot wrote:
> Primary impetus: BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY:
>     By default umtprd does not communicate daemon readyness.  Version
>     1.6.8 added a build option that enables creating a Type=notify
>     systemd service.
> 
> Added two other relevant build options that were available in the
> Makefile:
> - BR2_PACKAGE_UMTPRD_DEBUG
> - BR2_PACKAGE_UMTPRD_SYSLOG
> 
> Signed-off-by: Nevo Hed <nhed+buildroot@starry.com>
> ---
>  package/umtprd/Config.in | 19 ++++++++++++++++++-
>  package/umtprd/umtprd.mk | 14 +++++++++++++-
>  2 files changed, 31 insertions(+), 2 deletions(-)
> 
> diff --git a/package/umtprd/Config.in b/package/umtprd/Config.in
> index 24bf119549..dff5a44583 100644
> --- a/package/umtprd/Config.in
> +++ b/package/umtprd/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_UMTPRD
> +menuconfig BR2_PACKAGE_UMTPRD
>  	bool "umtprd"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15
> @@ -7,5 +7,22 @@ config BR2_PACKAGE_UMTPRD
>  
>  	  https://github.com/viveris/uMTP-Responder
>  
> +if BR2_PACKAGE_UMTPRD
> +
> +if BR2_PACKAGE_SYSTEMD
> +
> +config BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY
> +	bool "Tell Systemd when uMTP-Responder is ready "

There is no need to have a separate option for this, just enable
systemd notify support at soon as BR2_PACKAGE_SYSTEMD=y.

> +endif
> +
> +config BR2_PACKAGE_UMTPRD_DEBUG
> +	bool "Enable debug"

What does it do? Perhaps we want to use BR2_ENABLE_RUNTIME_DEBUG=y
instead of having a custom option?

> +config BR2_PACKAGE_UMTPRD_SYSLOG
> +	bool "Send output to syslog"

Where is the output going otherwise? Shouldn't sending the output to
syslog simply be the unconditional default?

Peter, Arnout, any opinion on this?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/umtprd: expose package build options

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

Hi,

 >> +config BR2_PACKAGE_UMTPRD_SYSLOG
 >> +	bool "Send output to syslog"

 > Where is the output going otherwise? Shouldn't sending the output to
 > syslog simply be the unconditional default?

 > Peter, Arnout, any opinion on this?

Looking at the code, it indeed seems to be a build time switch:

https://github.com/viveris/uMTP-Responder/blob/b174b03a3c2641a578b9299e540994a35b2f03a9/inc/logs_out.h#L46

Which is not so nice, but oh well.

So I guess it does make sense with the option, unless we say that it
should always log to syslog given that it is a daemon.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/umtprd: expose package build options

[Thomas Petazzoni via buildroot]

On Tue, Oct 13, 2026 at 01:12:50PM +0200, Peter Korsgaard wrote:

> So I guess it does make sense with the option, unless we say that it
> should always log to syslog given that it is a daemon.

That was my thinking: it's a daemon, so "of course" one will want it
to log to syslog, no?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/umtprd: expose package build options

[Nevo Hed via buildroot]

[-- Attachment #1.1: Type: text/plain, Size: 1409 bytes --]

Maybe overcorrection on my behalf but I was just trying to make all the
options in the component configurable

Re: SYSLOG:
    I actually don't enable or need it.  Yes it is a daemon but in my
systemd-based platform without
    this flag it goes to stdout and stdout goes to the journal by default
but is otherwise controlled by `StandardOutput*=` *

Re: DEBUG:
    I needed it when I was integrating into my system and things were not
working WRT umtprd.  In that case I would
    never have enabled BR2_ENABLE_RUNTIME_DEBUG as I'm interested in
debugging that specific component.
    Granted I can forgo this and just patch the makefile for a debug build.

So if you guys think its cleaner and easier I can replace this whole patch
with the addition of:
    ifeq ($(BR2_PACKAGE_SYSTEMD),y)
    UMTPRD_BUILD_OPTS += SYSTEMD=1
    endif



On Tue, Oct 13, 2026 at 9:04 AM Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> On Tue, Oct 13, 2026 at 01:12:50PM +0200, Peter Korsgaard wrote:
>
> > So I guess it does make sense with the option, unless we say that it
> > should always log to syslog given that it is a daemon.
>
> That was my thinking: it's a daemon, so "of course" one will want it
> to log to syslog, no?
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 2698 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/umtprd: expose package build options

[Thomas Petazzoni via buildroot]

On Fri, Oct 23, 2026 at 12:14:40PM -0400, Nevo Hed wrote:

> So if you guys think its cleaner and easier I can replace this whole patch with
> the addition of:
>     ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>     UMTPRD_BUILD_OPTS += SYSTEMD=1
>     endif

Sounds good to me!

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot