Changing code in a subproject ceph-erasure-code-corpus

Changing code in a subproject ceph-erasure-code-corpus

[Willem Jan Withagen]

Hi,

I have  one-line change in the erasure-code subproject.
but git status reports:
   modified:   ceph-erasure-code-corpus (modified content)

So that change is not going to make it in my pull...
But it is influencing my tests, and I keep fixing it after
every fetch of the tree

It is in
./ceph-erasure-code-corpus/v0.92-988/non-regression.sh:25

and it replaces
	TMP=$(mktemp --directory)
by
	TMP=$(mktemp -d)

So how do get something like this commited?

Thanx,
--WjW

Re: Changing code in a subproject ceph-erasure-code-corpus

[Loic Dachary]

Hi,

You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus

Cheers

On 10/02/2016 18:16, Willem Jan Withagen wrote:
> Hi,
> 
> I have  one-line change in the erasure-code subproject.
> but git status reports:
>   modified:   ceph-erasure-code-corpus (modified content)
> 
> So that change is not going to make it in my pull...
> But it is influencing my tests, and I keep fixing it after
> every fetch of the tree
> 
> It is in
> ./ceph-erasure-code-corpus/v0.92-988/non-regression.sh:25
> 
> and it replaces
>     TMP=$(mktemp --directory)
> by
>     TMP=$(mktemp -d)
> 
> So how do get something like this commited?
> 
> Thanx,
> --WjW
> 
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Loïc Dachary, Artisan Logiciel Libre
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Changing code in a subproject ceph-erasure-code-corpus

[Loic Dachary]

Hi,

On 10/02/2016 19:01, Willem Jan Withagen wrote:
> On 10-2-2016 12:31, Loic Dachary wrote:
>> Hi,
>>
>> You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus
> 
> Right,
> 
> Thru the github interface that went more than easy.....
> 
> https://github.com/ceph/ceph-erasure-code-corpus/pull/3

Merged, thanks !

-- 
Loïc Dachary, Artisan Logiciel Libre
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Changing code in a subproject ceph-erasure-code-corpus

[Loic Dachary]

Once https://github.com/ceph/ceph/pull/7596 is merged, your change will be in use. Would you mind verifying it's the case ?

On 10/02/2016 21:01, Loic Dachary wrote:
> Hi,
> 
> On 10/02/2016 19:01, Willem Jan Withagen wrote:
>> On 10-2-2016 12:31, Loic Dachary wrote:
>>> Hi,
>>>
>>> You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus
>>
>> Right,
>>
>> Thru the github interface that went more than easy.....
>>
>> https://github.com/ceph/ceph-erasure-code-corpus/pull/3
> 
> Merged, thanks !
> 

-- 
Loïc Dachary, Artisan Logiciel Libre
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Changing code in a subproject ceph-erasure-code-corpus

[Willem Jan Withagen]

On 10-2-2016 15:09, Loic Dachary wrote:
> Once https://github.com/ceph/ceph/pull/7596 is merged, your change will be in use. Would you mind verifying it's the case ?

Thanx,
And it'll show itself immediately on a next 'make check' run.
IF it's not there, I'll let you know.

--WjW

> On 10/02/2016 21:01, Loic Dachary wrote:
>> Hi,
>>
>> On 10/02/2016 19:01, Willem Jan Withagen wrote:
>>> On 10-2-2016 12:31, Loic Dachary wrote:
>>>> Hi,
>>>>
>>>> You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus
>>>
>>> Right,
>>>
>>> Thru the github interface that went more than easy.....
>>>
>>> https://github.com/ceph/ceph-erasure-code-corpus/pull/3
>>
>> Merged, thanks !
>>
>

Re: Changing code in a subproject ceph-erasure-code-corpus

[Willem Jan Withagen]

On 10-2-2016 16:03, Willem Jan Withagen wrote:
> On 10-2-2016 15:09, Loic Dachary wrote:
>> Once https://github.com/ceph/ceph/pull/7596 is merged, your change
>> will be in use. Would you mind verifying it's the case ?
>
> Thanx,
> And it'll show itself immediately on a next 'make check' run.
> IF it's not there, I'll let you know.

Hi Loic,

It has arived. Currently running a large recompile.

--WjW


>
> --WjW
>
>> On 10/02/2016 21:01, Loic Dachary wrote:
>>> Hi,
>>>
>>> On 10/02/2016 19:01, Willem Jan Withagen wrote:
>>>> On 10-2-2016 12:31, Loic Dachary wrote:
>>>>> Hi,
>>>>>
>>>>> You can submit a patch against
>>>>> https://github.com/ceph/ceph-erasure-code-corpus
>>>>
>>>> Right,
>>>>
>>>> Thru the github interface that went more than easy.....
>>>>
>>>> https://github.com/ceph/ceph-erasure-code-corpus/pull/3
>>>
>>> Merged, thanks !
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html