* Changing code in a subproject ceph-erasure-code-corpus
@ 2016-02-10 11:16 Willem Jan Withagen
2016-02-10 11:31 ` Loic Dachary
0 siblings, 1 reply; 6+ messages in thread
From: Willem Jan Withagen @ 2016-02-10 11:16 UTC (permalink / raw)
To: ceph-devel
Hi,
I have one-line change in the erasure-code subproject.
but git status reports:
modified: ceph-erasure-code-corpus (modified content)
So that change is not going to make it in my pull...
But it is influencing my tests, and I keep fixing it after
every fetch of the tree
It is in
./ceph-erasure-code-corpus/v0.92-988/non-regression.sh:25
and it replaces
TMP=$(mktemp --directory)
by
TMP=$(mktemp -d)
So how do get something like this commited?
Thanx,
--WjW
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Changing code in a subproject ceph-erasure-code-corpus
2016-02-10 11:16 Changing code in a subproject ceph-erasure-code-corpus Willem Jan Withagen
@ 2016-02-10 11:31 ` Loic Dachary
[not found] ` <56BB2696.30505@digiware.nl>
0 siblings, 1 reply; 6+ messages in thread
From: Loic Dachary @ 2016-02-10 11:31 UTC (permalink / raw)
To: Willem Jan Withagen, ceph-devel
Hi,
You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus
Cheers
On 10/02/2016 18:16, Willem Jan Withagen wrote:
> Hi,
>
> I have one-line change in the erasure-code subproject.
> but git status reports:
> modified: ceph-erasure-code-corpus (modified content)
>
> So that change is not going to make it in my pull...
> But it is influencing my tests, and I keep fixing it after
> every fetch of the tree
>
> It is in
> ./ceph-erasure-code-corpus/v0.92-988/non-regression.sh:25
>
> and it replaces
> TMP=$(mktemp --directory)
> by
> TMP=$(mktemp -d)
>
> So how do get something like this commited?
>
> Thanx,
> --WjW
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Loïc Dachary, Artisan Logiciel Libre
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Changing code in a subproject ceph-erasure-code-corpus
[not found] ` <56BB2696.30505@digiware.nl>
@ 2016-02-10 14:01 ` Loic Dachary
2016-02-10 14:09 ` Loic Dachary
0 siblings, 1 reply; 6+ messages in thread
From: Loic Dachary @ 2016-02-10 14:01 UTC (permalink / raw)
To: Willem Jan Withagen; +Cc: Ceph Development
Hi,
On 10/02/2016 19:01, Willem Jan Withagen wrote:
> On 10-2-2016 12:31, Loic Dachary wrote:
>> Hi,
>>
>> You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus
>
> Right,
>
> Thru the github interface that went more than easy.....
>
> https://github.com/ceph/ceph-erasure-code-corpus/pull/3
Merged, thanks !
--
Loïc Dachary, Artisan Logiciel Libre
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Changing code in a subproject ceph-erasure-code-corpus
2016-02-10 14:01 ` Loic Dachary
@ 2016-02-10 14:09 ` Loic Dachary
2016-02-10 15:03 ` Willem Jan Withagen
0 siblings, 1 reply; 6+ messages in thread
From: Loic Dachary @ 2016-02-10 14:09 UTC (permalink / raw)
To: Willem Jan Withagen; +Cc: Ceph Development
Once https://github.com/ceph/ceph/pull/7596 is merged, your change will be in use. Would you mind verifying it's the case ?
On 10/02/2016 21:01, Loic Dachary wrote:
> Hi,
>
> On 10/02/2016 19:01, Willem Jan Withagen wrote:
>> On 10-2-2016 12:31, Loic Dachary wrote:
>>> Hi,
>>>
>>> You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus
>>
>> Right,
>>
>> Thru the github interface that went more than easy.....
>>
>> https://github.com/ceph/ceph-erasure-code-corpus/pull/3
>
> Merged, thanks !
>
--
Loïc Dachary, Artisan Logiciel Libre
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Changing code in a subproject ceph-erasure-code-corpus
2016-02-10 14:09 ` Loic Dachary
@ 2016-02-10 15:03 ` Willem Jan Withagen
2016-02-11 13:07 ` Willem Jan Withagen
0 siblings, 1 reply; 6+ messages in thread
From: Willem Jan Withagen @ 2016-02-10 15:03 UTC (permalink / raw)
To: Loic Dachary; +Cc: Ceph Development
On 10-2-2016 15:09, Loic Dachary wrote:
> Once https://github.com/ceph/ceph/pull/7596 is merged, your change will be in use. Would you mind verifying it's the case ?
Thanx,
And it'll show itself immediately on a next 'make check' run.
IF it's not there, I'll let you know.
--WjW
> On 10/02/2016 21:01, Loic Dachary wrote:
>> Hi,
>>
>> On 10/02/2016 19:01, Willem Jan Withagen wrote:
>>> On 10-2-2016 12:31, Loic Dachary wrote:
>>>> Hi,
>>>>
>>>> You can submit a patch against https://github.com/ceph/ceph-erasure-code-corpus
>>>
>>> Right,
>>>
>>> Thru the github interface that went more than easy.....
>>>
>>> https://github.com/ceph/ceph-erasure-code-corpus/pull/3
>>
>> Merged, thanks !
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Changing code in a subproject ceph-erasure-code-corpus
2016-02-10 15:03 ` Willem Jan Withagen
@ 2016-02-11 13:07 ` Willem Jan Withagen
0 siblings, 0 replies; 6+ messages in thread
From: Willem Jan Withagen @ 2016-02-11 13:07 UTC (permalink / raw)
To: Loic Dachary; +Cc: Ceph Development
On 10-2-2016 16:03, Willem Jan Withagen wrote:
> On 10-2-2016 15:09, Loic Dachary wrote:
>> Once https://github.com/ceph/ceph/pull/7596 is merged, your change
>> will be in use. Would you mind verifying it's the case ?
>
> Thanx,
> And it'll show itself immediately on a next 'make check' run.
> IF it's not there, I'll let you know.
Hi Loic,
It has arived. Currently running a large recompile.
--WjW
>
> --WjW
>
>> On 10/02/2016 21:01, Loic Dachary wrote:
>>> Hi,
>>>
>>> On 10/02/2016 19:01, Willem Jan Withagen wrote:
>>>> On 10-2-2016 12:31, Loic Dachary wrote:
>>>>> Hi,
>>>>>
>>>>> You can submit a patch against
>>>>> https://github.com/ceph/ceph-erasure-code-corpus
>>>>
>>>> Right,
>>>>
>>>> Thru the github interface that went more than easy.....
>>>>
>>>> https://github.com/ceph/ceph-erasure-code-corpus/pull/3
>>>
>>> Merged, thanks !
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-11 13:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 11:16 Changing code in a subproject ceph-erasure-code-corpus Willem Jan Withagen
2016-02-10 11:31 ` Loic Dachary
[not found] ` <56BB2696.30505@digiware.nl>
2016-02-10 14:01 ` Loic Dachary
2016-02-10 14:09 ` Loic Dachary
2016-02-10 15:03 ` Willem Jan Withagen
2016-02-11 13:07 ` Willem Jan Withagen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox