From: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Andrey Ryabinin
<aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v5 2/2] mm/memcontrol.c: Reduce reclaim retries in mem_cgroup_resize_limit()
Date: Fri, 19 Jan 2018 16:31:32 +0100 [thread overview]
Message-ID: <20180119153132.GF6584@dhcp22.suse.cz> (raw)
In-Reply-To: <CALvZod6q8ExRW-EkG_eMyJeGhhMcbSQZMQEqmHEHj7PhRYwJ1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri 19-01-18 07:24:08, Shakeel Butt wrote:
[...]
> Thanks for the explanation. Another query, we do not call
> drain_all_stock() in mem_cgroup_resize_limit() but memory_max_write()
> does call drain_all_stock(). Was this intentional or missed
> accidentally?
I think it is just an omission. I would have to look closer but I am
just leaving now and will be back on Tuesday. This is unrelated so I
would rather discuss it in a separate email thread.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-01-19 15:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 10:24 [PATCH 1/2] mm/memcg: try harder to decrease [memory,memsw].limit_in_bytes Andrey Ryabinin
2017-12-20 10:24 ` [PATCH 2/2] mm/memcg: Consolidate mem_cgroup_resize_[memsw]_limit() functions Andrey Ryabinin
2017-12-20 10:33 ` [PATCH 1/2] mm/memcg: try harder to decrease [memory,memsw].limit_in_bytes Michal Hocko
2017-12-20 11:32 ` Andrey Ryabinin
2017-12-20 11:34 ` Michal Hocko
2017-12-20 18:15 ` Shakeel Butt
[not found] ` <CALvZod7ED3qaqekGTd-2PHmbTjY+D_NcFP1bE5_AgP8OF=jXJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-21 10:00 ` Andrey Ryabinin
2017-12-20 13:21 ` [PATCH v2 " Andrey Ryabinin
2017-12-20 13:21 ` [PATCH v2 2/2] mm/memcg: Consolidate mem_cgroup_resize_[memsw]_limit() functions Andrey Ryabinin
2017-12-20 13:53 ` [PATCH v2 1/2] mm/memcg: try harder to decrease [memory,memsw].limit_in_bytes Michal Hocko
2018-01-09 16:58 ` [PATCH v3 " Andrey Ryabinin
2018-01-09 16:58 ` [PATCH v3 2/2] mm/memcg: Consolidate mem_cgroup_resize_[memsw]_limit() functions Andrey Ryabinin
[not found] ` <20180109165815.8329-2-aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-09 17:10 ` Shakeel Butt
2018-01-09 17:26 ` Andrey Ryabinin
2018-01-09 23:26 ` Andrew Morton
[not found] ` <20180109152622.31ca558acb0cc25a1b14f38c-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2018-01-10 12:43 ` [PATCH v4] mm/memcg: try harder to decrease [memory,memsw].limit_in_bytes Andrey Ryabinin
2018-01-10 22:31 ` Andrew Morton
2018-01-11 11:59 ` Andrey Ryabinin
[not found] ` <47856d2b-1534-6198-c2e2-6d2356973bef-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-12 0:21 ` Andrew Morton
2018-01-12 9:08 ` Andrey Ryabinin
[not found] ` <20180110124317.28887-1-aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-11 10:42 ` Michal Hocko
[not found] ` <20180111104239.GZ1732-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-01-11 12:21 ` Andrey Ryabinin
2018-01-11 12:46 ` Michal Hocko
[not found] ` <20180111124629.GA1732-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-01-11 15:23 ` Andrey Ryabinin
[not found] ` <ce885a69-67af-5f4c-1116-9f6803fb45ee-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-11 16:29 ` Michal Hocko
[not found] ` <20180111162947.GG1732-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-01-11 21:59 ` Andrey Ryabinin
2018-01-12 12:24 ` Michal Hocko
[not found] ` <20180112122405.GK1732-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-01-12 22:57 ` Shakeel Butt
2018-01-15 12:29 ` Andrey Ryabinin
[not found] ` <e5e92227-0931-dfc1-841e-c036131e66a8-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-15 17:04 ` Shakeel Butt
2018-01-15 12:30 ` Andrey Ryabinin
2018-01-15 12:46 ` Michal Hocko
2018-01-15 12:53 ` Andrey Ryabinin
2018-01-15 12:58 ` Michal Hocko
[not found] ` <20180109165815.8329-1-aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-09 17:08 ` [PATCH v3 1/2] " Andrey Ryabinin
2018-01-09 17:22 ` Shakeel Butt
[not found] ` <20171220102429.31601-1-aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-19 13:25 ` [PATCH v5 1/2] mm/memcontrol.c: " Andrey Ryabinin
2018-01-19 13:25 ` [PATCH v5 2/2] mm/memcontrol.c: Reduce reclaim retries in mem_cgroup_resize_limit() Andrey Ryabinin
2018-01-19 13:35 ` Michal Hocko
[not found] ` <20180119133510.GD6584-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-01-19 14:49 ` Shakeel Butt
[not found] ` <CALvZod7HS6P0OU6Rps8JeMJycaPd4dF5NjxV8k1y2-yosF2bdA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-19 15:11 ` Michal Hocko
2018-01-19 15:24 ` Shakeel Butt
[not found] ` <CALvZod6q8ExRW-EkG_eMyJeGhhMcbSQZMQEqmHEHj7PhRYwJ1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-19 15:31 ` Michal Hocko [this message]
[not found] ` <20180119132544.19569-1-aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2018-01-19 13:32 ` [PATCH v5 1/2] mm/memcontrol.c: try harder to decrease [memory,memsw].limit_in_bytes Michal Hocko
2018-01-25 19:44 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119153132.GF6584@dhcp22.suse.cz \
--to=mhocko-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox