From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joel-QYYGw3jwrUn5owFQY34kdNi2O/JbrIOy@public.gmane.org,
rcu-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
frextrite-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] cgroup.c: Use built-in RCU list checking
Date: Wed, 29 Jan 2020 15:22:55 +0100 [thread overview]
Message-ID: <20200129142255.GE11384@blackbody.suse.cz> (raw)
In-Reply-To: <20200118031051.28776-1-madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello.
On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
I assume if you've seen the RCU warning, you haven't seen the warning
from cgroup_assert_mutex_or_rcu_locked() above.
The patch makes sense to me from the consistency POV.
Acked-by: Michal Koutný <mkoutny-IBi9RG/b67k@public.gmane.org>
Michal
next prev parent reply other threads:[~2020-01-29 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 3:10 [PATCH] cgroup.c: Use built-in RCU list checking madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20200118031051.28776-1-madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-29 14:22 ` Michal Koutný [this message]
2020-01-29 16:07 ` Madhuparna Bhowmik
2020-02-12 22:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129142255.GE11384@blackbody.suse.cz \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frextrite-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=joel-QYYGw3jwrUn5owFQY34kdNi2O/JbrIOy@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rcu-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox