From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: madhuparnabhowmik10@gmail.com, tj@kernel.org, lizefan@huawei.com,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
joel@joelfernandes.org, rcu@vger.kernel.org, frextrite@gmail.com
Subject: Re: [PATCH] cgroup.c: Use built-in RCU list checking
Date: Wed, 29 Jan 2020 21:37:52 +0530 [thread overview]
Message-ID: <20200129160752.GA15913@madhuparna-HP-Notebook> (raw)
In-Reply-To: <20200129142255.GE11384@blackbody.suse.cz>
On Wed, Jan 29, 2020 at 03:22:55PM +0100, Michal Koutný wrote:
> Hello.
>
> On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10@gmail.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> >
> > list_for_each_entry_rcu has built-in RCU and lock checking.
> > Pass cond argument to list_for_each_entry_rcu() to silence
> > false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> > by default.
> I assume if you've seen the RCU warning, you haven't seen the warning
> from cgroup_assert_mutex_or_rcu_locked() above.
>
No, I haven't seen any warning from cgroup_assert_mutex_or_rcu_locked(),
I am just doing the conversions to prevent any false lockdep warnings
because of CONFIG_PROVE_RCU_LIST in the future.
> The patch makes sense to me from the consistency POV.
>
Thank you,
Madhuparna
> Acked-by: Michal Koutný <mkoutny@suse.com>
>
> Michal
next prev parent reply other threads:[~2020-01-29 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 3:10 [PATCH] cgroup.c: Use built-in RCU list checking madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20200118031051.28776-1-madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-29 14:22 ` Michal Koutný
2020-01-29 16:07 ` Madhuparna Bhowmik [this message]
2020-02-12 22:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129160752.GA15913@madhuparna-HP-Notebook \
--to=madhuparnabhowmik10@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mkoutny@suse.com \
--cc=rcu@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox