From: Tejun Heo <tj@kernel.org>
To: madhuparnabhowmik10@gmail.com
Cc: lizefan@huawei.com, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, joel@joelfernandes.org,
rcu@vger.kernel.org, frextrite@gmail.com
Subject: Re: [PATCH] cgroup.c: Use built-in RCU list checking
Date: Wed, 12 Feb 2020 17:12:49 -0500 [thread overview]
Message-ID: <20200212221249.GJ80993@mtj.thefacebook.com> (raw)
In-Reply-To: <20200118031051.28776-1-madhuparnabhowmik10@gmail.com>
On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Even though the function css_next_child() already checks if
> cgroup_mutex or rcu_read_lock() is held using
> cgroup_assert_mutex_or_rcu_locked(), there is a need to pass
> cond to list_for_each_entry_rcu() to avoid false positive
> lockdep warning.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Applied to cgroup/for-5.7.
Thanks.
--
tejun
prev parent reply other threads:[~2020-02-12 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 3:10 [PATCH] cgroup.c: Use built-in RCU list checking madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20200118031051.28776-1-madhuparnabhowmik10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-29 14:22 ` Michal Koutný
2020-01-29 16:07 ` Madhuparna Bhowmik
2020-02-12 22:12 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212221249.GJ80993@mtj.thefacebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=madhuparnabhowmik10@gmail.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox